Re: RFR: 8332103: since-checker - Add missing @ since tags to java.desktop [v4]
On Wed, 26 Jun 2024 09:52:38 GMT, Nizar Benalla wrote: >> If you're currently reviewing this PR, thank you! >> Most fixes here are according to the reports by the since checker tool in >> #18934 and are pretty simple. >> >> To make reviewing easier >> - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for >> a long time so the default constructor (without parameters) didn't exist >> until JDK 16 >> >> For the `package-info` files, it is pretty hard to find source code of JDK >> 1-5 so I used the `grep` command to find the oldest instance of an `@since` >> in those packages. >> >> I found instances of `@since 1.1` in the other packages but >> `javax/swing/plaf/synth/package-info.java` might be worth checking as most >> classes there had no `@since`. > > Nizar Benalla has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains four commits: > > - Merge remote-tracking branch 'upstream/master' into JDK-8332103 > ># Conflicts: ># src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java > - See if an empty commit removes sponsor label > - Swing was added in JDK 1.2 > - Add `@since` tags to `java.desktop` @nizarbenalla Your change (at version 5e4e908975da353a5b3cd245af5ccf1f16401f38) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jdk/pull/19192#issuecomment-2191444573
Re: RFR: 8332103: since-checker - Add missing @ since tags to java.desktop [v4]
On Wed, 26 Jun 2024 09:52:38 GMT, Nizar Benalla wrote: >> If you're currently reviewing this PR, thank you! >> Most fixes here are according to the reports by the since checker tool in >> #18934 and are pretty simple. >> >> To make reviewing easier >> - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for >> a long time so the default constructor (without parameters) didn't exist >> until JDK 16 >> >> For the `package-info` files, it is pretty hard to find source code of JDK >> 1-5 so I used the `grep` command to find the oldest instance of an `@since` >> in those packages. >> >> I found instances of `@since 1.1` in the other packages but >> `javax/swing/plaf/synth/package-info.java` might be worth checking as most >> classes there had no `@since`. > > Nizar Benalla has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains four commits: > > - Merge remote-tracking branch 'upstream/master' into JDK-8332103 > ># Conflicts: ># src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java > - See if an empty commit removes sponsor label > - Swing was added in JDK 1.2 > - Add `@since` tags to `java.desktop` Thank you Aleksei! /Integrate - PR Comment: https://git.openjdk.org/jdk/pull/19192#issuecomment-2191349153
Re: RFR: 8332103: since-checker - Add missing @ since tags to java.desktop [v4]
On Wed, 26 Jun 2024 09:52:38 GMT, Nizar Benalla wrote: >> If you're currently reviewing this PR, thank you! >> Most fixes here are according to the reports by the since checker tool in >> #18934 and are pretty simple. >> >> To make reviewing easier >> - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for >> a long time so the default constructor (without parameters) didn't exist >> until JDK 16 >> >> For the `package-info` files, it is pretty hard to find source code of JDK >> 1-5 so I used the `grep` command to find the oldest instance of an `@since` >> in those packages. >> >> I found instances of `@since 1.1` in the other packages but >> `javax/swing/plaf/synth/package-info.java` might be worth checking as most >> classes there had no `@since`. > > Nizar Benalla has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains four commits: > > - Merge remote-tracking branch 'upstream/master' into JDK-8332103 > ># Conflicts: ># src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java > - See if an empty commit removes sponsor label > - Swing was added in JDK 1.2 > - Add `@since` tags to `java.desktop` Looks good to me. Thank you for waiting and then resolving the conflict. - Marked as reviewed by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19192#pullrequestreview-2141374861
Re: RFR: 8332103: since-checker - Add missing @ since tags to java.desktop [v4]
> If you're currently reviewing this PR, thank you! > Most fixes here are according to the reports by the since checker tool in > #18934 and are pretty simple. > > To make reviewing easier > - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for a > long time so the default constructor (without parameters) didn't exist until > JDK 16 > > For the `package-info` files, it is pretty hard to find source code of JDK > 1-5 so I used the `grep` command to find the oldest instance of an `@since` > in those packages. > > I found instances of `@since 1.1` in the other packages but > `javax/swing/plaf/synth/package-info.java` might be worth checking as most > classes there had no `@since`. Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge remote-tracking branch 'upstream/master' into JDK-8332103 # Conflicts: #src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java - See if an empty commit removes sponsor label - Swing was added in JDK 1.2 - Add `@since` tags to `java.desktop` - Changes: https://git.openjdk.org/jdk/pull/19192/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19192&range=03 Stats: 42 lines in 9 files changed: 34 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/19192.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19192/head:pull/19192 PR: https://git.openjdk.org/jdk/pull/19192