Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v4]

2024-06-24 Thread Alexey Ivanov
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan  
wrote:

>> The no-arg constructor BasicSliderUI() was added under 
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This 
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   javadoc fix

Marked as reviewed by aivanov (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2136431285


Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v4]

2024-06-24 Thread Phil Race
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan  
wrote:

>> The no-arg constructor BasicSliderUI() was added under 
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This 
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   javadoc fix

Marked as reviewed by prr (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2136363950


Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v4]

2024-06-24 Thread Kevin Rushforth
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan  
wrote:

>> The no-arg constructor BasicSliderUI() was added under 
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This 
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   javadoc fix

Marked as reviewed by kcr (Author).

-

PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2136280195


Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v4]

2024-06-24 Thread Prasanta Sadhukhan
> The no-arg constructor BasicSliderUI() was added under 
> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This 
> constructor should be deprecated for removal in future release

Prasanta Sadhukhan has updated the pull request incrementally with one 
additional commit since the last revision:

  javadoc fix

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/19819/files
  - new: https://git.openjdk.org/jdk/pull/19819/files/40312082..6844be05

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=19819=03
 - incr: https://webrevs.openjdk.org/?repo=jdk=19819=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/19819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19819/head:pull/19819

PR: https://git.openjdk.org/jdk/pull/19819