Re: RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v11]
On Tue, 16 Jan 2024 17:58:37 GMT, Harshitha Onkar wrote: > Ran the updated test on macOS 13 and 14.2, it works well with the > stabilization fix done for macOS 14.1. Changes look good. I ran a job with 50 repeats of the test in our CI, the test passes. I've submitted a new job, just in a case, with the most recent changes. - PR Comment: https://git.openjdk.org/jdk/pull/16396#issuecomment-1894241361
Re: RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v11]
On Tue, 16 Jan 2024 17:29:50 GMT, songpv-imt wrote: >> The root cause of the bug is because mousePress() method is invoked before >> mouseMove() event is completely processed causing the drag & drop behavior >> not being able to be recognized properly. This in turn makes the method >> dragSourceListener.isDropFinished() returns false and fail the test. To fix >> this, setAutoWaitForIdle(true) and Thread.Sleep is called to make sure the >> mouseMove() event is processed completely before moving to execute the >> mousePress() method. >> >> JBS issue: [JDK-8317287](https://bugs.openjdk.org/browse/JDK-8317287) > > songpv-imt has updated the pull request incrementally with one additional > commit since the last revision: > > Update InterJVMGetDropSuccessTest.java Ran the updated test on macOS 13 and 14.2, it works well with the stabilization fix done for macOS 14.1. Changes look good. - Marked as reviewed by honkar (Committer). PR Review: https://git.openjdk.org/jdk/pull/16396#pullrequestreview-1824464083
Re: RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v11]
On Tue, 16 Jan 2024 17:29:50 GMT, songpv-imt wrote: >> The root cause of the bug is because mousePress() method is invoked before >> mouseMove() event is completely processed causing the drag & drop behavior >> not being able to be recognized properly. This in turn makes the method >> dragSourceListener.isDropFinished() returns false and fail the test. To fix >> this, setAutoWaitForIdle(true) and Thread.Sleep is called to make sure the >> mouseMove() event is processed completely before moving to execute the >> mousePress() method. >> >> JBS issue: [JDK-8317287](https://bugs.openjdk.org/browse/JDK-8317287) > > songpv-imt has updated the pull request incrementally with one additional > commit since the last revision: > > Update InterJVMGetDropSuccessTest.java Marked as reviewed by aivanov (Reviewer). test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.java line 143: > 141: static final Object SYNC_LOCK = new Object(); > 142: static final int MOUSE_RELEASE_TIMEOUT = 1000; > 143: I'd rather preserve these blank lines because they separate blocks of fields: exit codes, timeout, sync object. - PR Review: https://git.openjdk.org/jdk/pull/16396#pullrequestreview-1824415165 PR Review Comment: https://git.openjdk.org/jdk/pull/16396#discussion_r1453768811
Re: RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v11]
> The root cause of the bug is because mousePress() method is invoked before > mouseMove() event is completely processed causing the drag & drop behavior > not being able to be recognized properly. This in turn makes the method > dragSourceListener.isDropFinished() returns false and fail the test. To fix > this, setAutoWaitForIdle(true) and Thread.Sleep is called to make sure the > mouseMove() event is processed completely before moving to execute the > mousePress() method. > > JBS issue: [JDK-8317287](https://bugs.openjdk.org/browse/JDK-8317287) songpv-imt has updated the pull request incrementally with one additional commit since the last revision: Update InterJVMGetDropSuccessTest.java - Changes: - all: https://git.openjdk.org/jdk/pull/16396/files - new: https://git.openjdk.org/jdk/pull/16396/files/16a1ec70..51c97fb1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=16396=10 - incr: https://webrevs.openjdk.org/?repo=jdk=16396=09-10 Stats: 33 lines in 1 file changed: 9 ins; 11 del; 13 mod Patch: https://git.openjdk.org/jdk/pull/16396.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16396/head:pull/16396 PR: https://git.openjdk.org/jdk/pull/16396
