Re: RFR: 8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only

2024-05-01 Thread Alexey Ivanov
On Wed, 1 May 2024 16:29:10 GMT, Alexey Ivanov  wrote:

> As soon as I integrated 
> `test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java` 
> #18957, the test started failing in CI on Linux and macOS. There are six 
> failures found so far.
> 
> Before starting code review and later, I ran the test many times on CI and I 
> never saw so many failures.
> 
> To reduce the noise, I'm limiting the test to **Windows only** where it's 
> stable.
> 
> I submitted [JDK-8331494](https://bugs.openjdk.org/browse/JDK-8331494) to 
> make the test more stable on Linux and macOS if possible.

@mrserb Could you approve it, please? Or anyone else.

This is trivial change, I'll enable automatic integration as soon as it's 
reviewed.

-

PR Comment: https://git.openjdk.org/jdk/pull/19038#issuecomment-2088735759


Re: RFR: 8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only

2024-05-01 Thread Phil Race
On Wed, 1 May 2024 16:29:10 GMT, Alexey Ivanov  wrote:

> As soon as I integrated 
> `test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java` 
> #18957, the test started failing in CI on Linux and macOS. There are six 
> failures found so far.
> 
> Before starting code review and later, I ran the test many times on CI and I 
> never saw so many failures.
> 
> To reduce the noise, I'm limiting the test to **Windows only** where it's 
> stable.
> 
> I submitted [JDK-8331494](https://bugs.openjdk.org/browse/JDK-8331494) to 
> make the test more stable on Linux and macOS if possible.

One reviewer is OK here.

-

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19038#pullrequestreview-2033940495