Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v30]
On Wed, 3 Sep 2025 09:22:17 GMT, Khalid Boulanouare wrote: >> Many Mixing tests failed because the work around click lands on the >> minimizing area in the window control and causes the tests to fail. >> >> This fix changes the width of base frames which allows most of tests to pass. > > Khalid Boulanouare has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 46 additional > commits since the last revision: > > - Merge branch 'openjdk:master' into jdk-8158801 > - Disposes frame at the end of testing. > - Moves latch logic inside ancestor frame block > - Merge branch 'openjdk:master' into jdk-8158801 > - Disposes frames after each AWT component test > - Removes redundant code for centring frames > - Merge branch 'openjdk:master' into jdk-8158801 > - Merge branch 'openjdk:master' into jdk-8158801 > - Centers missed frames in the middle of screen > - Uses KeyboardFocusManager instead of FocusManager > - ... and 36 more: https://git.openjdk.org/jdk/compare/ac65d7e8...a62416a9 @kboulanou Your change (at version 54087fa9c47f55fbe62e9050f410de49bed58803) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jdk/pull/25971#issuecomment-3253220234
Re: RFR: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist [v2]
On Fri, 5 Sep 2025 05:51:36 GMT, Sarvesh Kumar Jain wrote: >> test/jdk/ProblemList.txt line 263: >> >>> 261: java/awt/print/PrinterJob/PSQuestionMark.java 7003378 generic-all >>> 262: java/awt/print/PrinterJob/GlyphPositions.java 7003378 generic-all >>> 263: java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java 8366852 >>> generic-all >> >> are you sure it's a generic-all problem? It was not problemlisted for >> windows and I dont think we see any problem in CI in mainline in windows.. > > I attached the test execution link in the bug 8366852, please check. that was for 21 not mainline.. - PR Review Comment: https://git.openjdk.org/jdk/pull/27085#discussion_r2324167983
Re: RFR: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist [v2]
On Fri, 5 Sep 2025 05:31:31 GMT, Sarvesh Kumar Jain wrote: >> The test is problem listed with incorrect bug JDK-6849371, >> The bug JDK-6849371 is for a different test and it is closed. >> A new bug has been raised for ChoiceMouseWheelTest.java test failure. > > Sarvesh Kumar Jain has updated the pull request incrementally with one > additional commit since the last revision: > > Updated with new bugid @TheSarveshJain Your change (at version bf04b8e0284720ec7fabe62132068e4a6f3e5966) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jdk/pull/27085#issuecomment-3257218842
Re: RFR: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist
On Fri, 5 Sep 2025 05:05:21 GMT, Prasanta Sadhukhan wrote: > That new bugid 8366852 needs to be added in the problemlist for this bug then > instead of removing the entry. @prsadhuk Updated. - PR Comment: https://git.openjdk.org/jdk/pull/27085#issuecomment-3257117653
Re: RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java [v3]
On Fri, 5 Sep 2025 09:21:58 GMT, Srinivas Mandalika
wrote:
>> test/jdk/java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java line 151:
>>
>>> 149: robot.setAutoDelay(150);
>>> 150: robot.setAutoWaitForIdle(true);
>>> 151: if (!windowFocusGainedLatch.await(1500,
>>> TimeUnit.MILLISECONDS)) {
>>
>> Once there is a timeout, we know the frame did not gain focus. Can we throw
>> exception and stop execution ?
>
> Yes, that was the code initially. The previous review suggested removal of
> the code as being redundant in the presence of the main method's throws
> Exception. There are pros and con to argue on both ways. Please let me know
> if you strong reason to not ok to not have in the current form.
No, the code I asked to remove was for catching InterruptedException and
rethrowing..This is for throwing RTE upfront if timeout exceeded, not by
setting `passed `to `false `and continuing..I guess it has its merit of not
continuing..
-
PR Review Comment: https://git.openjdk.org/jdk/pull/26471#discussion_r2324586626
Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v30]
On Thu, 4 Sep 2025 11:19:10 GMT, Alexey Ivanov wrote:
>> Khalid Boulanouare has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 46
>> additional commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into jdk-8158801
>> - Disposes frame at the end of testing.
>> - Moves latch logic inside ancestor frame block
>> - Merge branch 'openjdk:master' into jdk-8158801
>> - Disposes frames after each AWT component test
>> - Removes redundant code for centring frames
>> - Merge branch 'openjdk:master' into jdk-8158801
>> - Merge branch 'openjdk:master' into jdk-8158801
>> - Centers missed frames in the middle of screen
>> - Uses KeyboardFocusManager instead of FocusManager
>> - ... and 36 more: https://git.openjdk.org/jdk/compare/e79df9f1...a62416a9
>
> test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 264:
>
>> 262: embedder.setPreferredSize(new Dimension(150, 150));
>> 263: container.add(embedder);
>> 264: if(container instanceof Window){
>
> Suggestion:
>
> if (container instanceof Window){
I didn't notice the missing space before the opening brace:
if (container instanceof Window) {
-
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2321731571
Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v36]
> Many Mixing tests failed because the work around click lands on the > minimizing area in the window control and causes the tests to fail. > > This fix changes the width of base frames which allows most of tests to pass. Khalid Boulanouare has updated the pull request incrementally with one additional commit since the last revision: Initialized MULTI_FRAMES_TEST using a method - Changes: - all: https://git.openjdk.org/jdk/pull/25971/files - new: https://git.openjdk.org/jdk/pull/25971/files/6fdad620..eeef198f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25971&range=35 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25971&range=34-35 Stats: 34 lines in 2 files changed: 8 ins; 23 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/25971.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25971/head:pull/25971 PR: https://git.openjdk.org/jdk/pull/25971
RFR: 8366149: JNI exception pending in Java_sun_awt_X11GraphicsDevice_pGetBounds of awt_GraphicsEnv.c:1484
In the scenario where AWT's UNLOCK API encounters a pendingException, the env pointer throws the pendingException (as seen in `awt.h`). However, in `Java_sun_awt_X11GraphicsDevice_pGetBounds`, after `AWT_UNLOCK`, the bounds var is set. The exception check does not occur until after the bounds is set, so the bounds may be set to an undesired value. This fix adds another exception check to look for this pendingException after `AWT_UNLOCK`. - Commit messages: - Initial commit - Merge branch 'master' of github.com:DamonGuy/jdk - Merge branch 'master' of github.com:DamonGuy/jdk - Merge branch 'master' of github.com:DamonGuy/jdk - Merge branch 'master' of github.com:DamonGuy/jdk - Merge branch 'master' of github.com:DamonGuy/jdk - Merge branch 'master' of github.com:DamonGuy/jdk - Merge branch 'master' of github.com:DamonGuy/jdk - Merge branch 'master' of github.com:DamonGuy/jdk - Merge branch 'master' of github.com:DamonGuy/jdk - ... and 2 more: https://git.openjdk.org/jdk/compare/b69a3849...f5e1521b Changes: https://git.openjdk.org/jdk/pull/27110/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=27110&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8366149 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/27110.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/27110/head:pull/27110 PR: https://git.openjdk.org/jdk/pull/27110
Re: RFR: 8364146: JList getScrollableUnitIncrement return 0 [v3]
On Fri, 22 Aug 2025 22:16:48 GMT, Phil Race wrote:
> And if the rectangle you pass in has a y that is = the height of the list,
> then scrolling in a positive direction also returns 0.
> If it is GREATER than the height, then I get back a negative increment !
I tried
Rectangle cell = list.getCellBounds(1, data.length);
cell.y = list.getHeight() + 10;
int unit = list.getScrollableUnitIncrement(
cell,
SwingConstants.VERTICAL,
-1);
System.out.println("Scrollable unit increment: " + unit);
and I get 117 in upward (-1) direction and -99 in downward (1) direction..
so it seems `getScrollableUnitIncrement` finds from `locationToIndex` that it's
last row so `r.y` points to TOP of last cell (90) but `visibleRect.y` points to
height past the last cell(207) so it has to backtrack -99 pixels [last cell
height=18 - (207-90) = 18-117] logically but I guess we need to restrict it to
0 since there is no incremental scrolling that can be done
-
PR Comment: https://git.openjdk.org/jdk/pull/26500#issuecomment-3257481618
Re: RFR: 8364146: JList getScrollableUnitIncrement return 0 [v4]
> It seems JList.getScrollableUnitIncrement can sometime return 0 instead of > positive number which is not specified in the javadoc which can lead to > confusion. Clarified javadoc as to when it can return 0. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Restrict negative increment - Changes: - all: https://git.openjdk.org/jdk/pull/26500/files - new: https://git.openjdk.org/jdk/pull/26500/files/b4d22ac9..ba88e12e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=26500&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26500&range=02-03 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/26500.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26500/head:pull/26500 PR: https://git.openjdk.org/jdk/pull/26500
Re: RFR: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist [v2]
On Fri, 5 Sep 2025 05:53:40 GMT, Prasanta Sadhukhan wrote: >> I attached the test execution link in the bug 8366852, please check. > > that was for 21 not mainline.. there are 2 links, first one is ML, 2nd is 21. - PR Review Comment: https://git.openjdk.org/jdk/pull/27085#discussion_r2324195947
