Re: [ClojureScript] GCL advanced compilation bug-- :foo-bar and :foo_bar both become :foo_bar

2015-03-13 Thread David Nolen 
These are all the same issue. Fixed in master and will be fixed in the next
release. In the meantime you should be able use to use `:optimize-constants
false` in your build settings to avoid this for now.

David

On Fri, Mar 13, 2015 at 6:01 AM, Michiel Borkent 
wrote:

> I have run into an issue in advanced mode when accessing a map with a
> keyword that contains an underscore:
>
> https://gist.github.com/borkdude/be911f120c1676108644
>
> I'm not sure if that is also fixed by CLJS-1105?
>
>
> On Friday, March 13, 2015 at 1:40:33 AM UTC+1, Mike Fikes wrote:
> > Perhaps the same: http://dev.clojure.org/jira/browse/CLJS-1105
> >
> >
> > Fixed with a recent commit:
> >
> >
> >
> >
> https://github.com/clojure/clojurescript/commit/4bcc95175e4282d43ed74bf0abd670550fc40140
> >
> >
> >
> >
> >
> >
> >
> > On Mar 12, 2015, at 8:18 PM, Karl Guertin  wrote:
> >
> >
> >
> > If you have two identically named keywords, one being dash separated and
> the other being underscore separated, both will come out as underscore
> separated after getting run through advanced mode compilation and only in
> advanced mode. The I'm posting this here because I'm unsure if it's a bug
> in Clojurescript or a bug in Closure Compiler. I'm happy to file it in JIRA
> instead.
> >
> >
> > Clojurescript standalone jar r3058
> >
> >
> > build.cljs:
> >
> > (require 'cljs.closure)
> >
> > (cljs.closure/build "src"
> > {:main 'kw-underscore.core
> >  :output-to "out/main.js"
> >  :optimizations :advanced
> >  :target :nodejs})
> >
> >
> > src/kw_underscore/core.cljs:
> >
> > (ns kw-underscore.core)
> >
> > (enable-console-print!)
> >
> > (defn -main [& args]
> >   (println :foo-bar :foo_bar))
> >
> > (set! *main-cli-fn* -main)
> >
> >
> > command:
> >
> > $ java -cp cljs.jar:src clojure.main build.clj
> >
> >
> > output:
> >
> >
> > $ node out/main.js
> > :foo_bar :foo_bar
> >
> >
> >
> >
> > --
> >
> > Note that posts from new members are moderated - please be patient with
> your first post.
> >
> > ---
> >
> > You received this message because you are subscribed to the Google
> Groups "ClojureScript" group.
> >
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to clojurescrip...@googlegroups.com.
> >
> > To post to this group, send email to clojur...@googlegroups.com.
> >
> > Visit this group at http://groups.google.com/group/clojurescript.
>
> --
> Note that posts from new members are moderated - please be patient with
> your first post.
> ---
> You received this message because you are subscribed to the Google Groups
> "ClojureScript" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clojurescript+unsubscr...@googlegroups.com.
> To post to this group, send email to clojurescript@googlegroups.com.
> Visit this group at http://groups.google.com/group/clojurescript.
>

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at http://groups.google.com/group/clojurescript.

Re: [ClojureScript] GCL advanced compilation bug-- :foo-bar and :foo_bar both become :foo_bar

2015-03-13 Thread Michiel Borkent 
I have done some further testing and I think this was the same issue.

PS: the data used was not an EDN literal, but was dynamically created.



On Friday, March 13, 2015 at 11:01:40 AM UTC+1, Michiel Borkent wrote:
> I have run into an issue in advanced mode when accessing a map with a keyword 
> that contains an underscore:
> 
> https://gist.github.com/borkdude/be911f120c1676108644
> 
> I'm not sure if that is also fixed by CLJS-1105?
> 
> 
> On Friday, March 13, 2015 at 1:40:33 AM UTC+1, Mike Fikes wrote:
> > Perhaps the same: http://dev.clojure.org/jira/browse/CLJS-1105
> > 
> > 
> > Fixed with a recent commit:
> > 
> > 
> > 
> > https://github.com/clojure/clojurescript/commit/4bcc95175e4282d43ed74bf0abd670550fc40140
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > On Mar 12, 2015, at 8:18 PM, Karl Guertin  wrote:
> > 
> > 
> > 
> > If you have two identically named keywords, one being dash separated and 
> > the other being underscore separated, both will come out as underscore 
> > separated after getting run through advanced mode compilation and only in 
> > advanced mode. The I'm posting this here because I'm unsure if it's a bug 
> > in Clojurescript or a bug in Closure Compiler. I'm happy to file it in JIRA 
> > instead.
> > 
> > 
> > Clojurescript standalone jar r3058
> > 
> > 
> > build.cljs:
> > 
> >     (require 'cljs.closure)
> >     
> >     (cljs.closure/build "src"
> >     {:main 'kw-underscore.core
> >  :output-to "out/main.js"
> >  :optimizations :advanced
> >  :target :nodejs})
> > 
> > 
> > src/kw_underscore/core.cljs:
> > 
> >     (ns kw-underscore.core)
> > 
> >     (enable-console-print!)
> > 
> >     (defn -main [& args]
> >   (println :foo-bar :foo_bar))
> > 
> >     (set! *main-cli-fn* -main)
> > 
> > 
> > command:
> > 
> >     $ java -cp cljs.jar:src clojure.main build.clj
> > 
> > 
> > output:
> > 
> > 
> >     $ node out/main.js
> >     :foo_bar :foo_bar
> > 
> > 
> > 
> > 
> > -- 
> > 
> > Note that posts from new members are moderated - please be patient with 
> > your first post.
> > 
> > --- 
> > 
> > You received this message because you are subscribed to the Google Groups 
> > "ClojureScript" group.
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an 
> > email to clojurescrip...@googlegroups.com.
> > 
> > To post to this group, send email to clojur...@googlegroups.com.
> > 
> > Visit this group at http://groups.google.com/group/clojurescript.

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at http://groups.google.com/group/clojurescript.

Re: [ClojureScript] GCL advanced compilation bug-- :foo-bar and :foo_bar both become :foo_bar

2015-03-13 Thread Michiel Borkent 
I have run into an issue in advanced mode when accessing a map with a keyword 
that contains an underscore:

https://gist.github.com/borkdude/be911f120c1676108644

I'm not sure if that is also fixed by CLJS-1105?


On Friday, March 13, 2015 at 1:40:33 AM UTC+1, Mike Fikes wrote:
> Perhaps the same: http://dev.clojure.org/jira/browse/CLJS-1105
> 
> 
> Fixed with a recent commit:
> 
> 
> 
> https://github.com/clojure/clojurescript/commit/4bcc95175e4282d43ed74bf0abd670550fc40140
> 
> 
> 
> 
> 
> 
> 
> On Mar 12, 2015, at 8:18 PM, Karl Guertin  wrote:
> 
> 
> 
> If you have two identically named keywords, one being dash separated and the 
> other being underscore separated, both will come out as underscore separated 
> after getting run through advanced mode compilation and only in advanced 
> mode. The I'm posting this here because I'm unsure if it's a bug in 
> Clojurescript or a bug in Closure Compiler. I'm happy to file it in JIRA 
> instead.
> 
> 
> Clojurescript standalone jar r3058
> 
> 
> build.cljs:
> 
>     (require 'cljs.closure)
>     
>     (cljs.closure/build "src"
>     {:main 'kw-underscore.core
>  :output-to "out/main.js"
>  :optimizations :advanced
>  :target :nodejs})
> 
> 
> src/kw_underscore/core.cljs:
> 
>     (ns kw-underscore.core)
> 
>     (enable-console-print!)
> 
>     (defn -main [& args]
>   (println :foo-bar :foo_bar))
> 
>     (set! *main-cli-fn* -main)
> 
> 
> command:
> 
>     $ java -cp cljs.jar:src clojure.main build.clj
> 
> 
> output:
> 
> 
>     $ node out/main.js
>     :foo_bar :foo_bar
> 
> 
> 
> 
> -- 
> 
> Note that posts from new members are moderated - please be patient with your 
> first post.
> 
> --- 
> 
> You received this message because you are subscribed to the Google Groups 
> "ClojureScript" group.
> 
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to clojurescrip...@googlegroups.com.
> 
> To post to this group, send email to clojur...@googlegroups.com.
> 
> Visit this group at http://groups.google.com/group/clojurescript.

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at http://groups.google.com/group/clojurescript.

Re: [ClojureScript] GCL advanced compilation bug-- :foo-bar and :foo_bar both become :foo_bar

2015-03-12 Thread Mike Fikes 
Perhaps the same: http://dev.clojure.org/jira/browse/CLJS-1105 


Fixed with a recent commit:

https://github.com/clojure/clojurescript/commit/4bcc95175e4282d43ed74bf0abd670550fc40140
 




> On Mar 12, 2015, at 8:18 PM, Karl Guertin  wrote:
> 
> If you have two identically named keywords, one being dash separated and the 
> other being underscore separated, both will come out as underscore separated 
> after getting run through advanced mode compilation and only in advanced 
> mode. The I'm posting this here because I'm unsure if it's a bug in 
> Clojurescript or a bug in Closure Compiler. I'm happy to file it in JIRA 
> instead.
> 
> Clojurescript standalone jar r3058
> 
> build.cljs:
> 
> (require 'cljs.closure)
> 
> (cljs.closure/build "src"
> {:main 'kw-underscore.core
>  :output-to "out/main.js"
>  :optimizations :advanced
>  :target :nodejs})
> 
> src/kw_underscore/core.cljs:
> 
> (ns kw-underscore.core)
> 
> (enable-console-print!)
> 
> (defn -main [& args]
>   (println :foo-bar :foo_bar))
> 
> (set! *main-cli-fn* -main)
> 
> command:
> 
> $ java -cp cljs.jar:src clojure.main build.clj
> 
> output:
> 
> $ node out/main.js
> :foo_bar :foo_bar
> 
> -- 
> Note that posts from new members are moderated - please be patient with your 
> first post.
> --- 
> You received this message because you are subscribed to the Google Groups 
> "ClojureScript" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to clojurescript+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to clojurescript@googlegroups.com 
> .
> Visit this group at http://groups.google.com/group/clojurescript 
> .

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at http://groups.google.com/group/clojurescript.