Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:scm-version into cloud-init:master
So https://review.openstack.org/#/c/350861 is the addition to pbr for the 'deb version' so this imho makes me lean towards using pbr vs this package, and using either over a custom hand rolled version calculation scheme. Because with a hand rolled scheme, I'll still need to be translating the output of that hand rolled scheme into a RPM compatible form, which means, at that point a automatic version derived from git isn't offering that much value (because a human still needs to translate it) :( -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301727 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:scm-version into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/digitalocean into lp:cloud-init
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:1265 https://jenkins.ubuntu.com/server/job/cloud-init-ci/5/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=amd64/5/console FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=ppc64el/5/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/5/rebuild -- https://code.launchpad.net/~utlemming/cloud-init/digitalocean/+merge/301123 Your team cloud init development team is requested to review the proposed merge of lp:~utlemming/cloud-init/digitalocean into lp:cloud-init. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:scm-version into cloud-init:master
I guess the only thing that I can think about that makes using these tools useful is that they can provide a consistent way of getting that version (instead of yet another one-off way of getting it); pbr also has the nice ability to generate a debian version string and a redhat version string, which are quite useful when actually creating a package. For example: $ python setup.py rpm_version running rpm_version [pbr] Extracting rpm version 1.32.0.dev6 Not quite sure where the pbr output for deb_version is (thought it had this, ha). That's usually the next question, ok, now that we have a version string crap here, well now I need a debian version of that string and I need a redhat version of that string. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301727 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:scm-version into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:space into cloud-init:master
some test needed. I'd suggest making 'handle' do very little other than call a helper that has sane function signatures. i'm fine with it in principle. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301731 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:space into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:newer-configobj into cloud-init:master
if we declare this as minimum version, i think there is some imrpvoement to
ConfigObj usage in
cloudinit/config/cc_mcollective.py
we had to do this:
try:
mcollective_config = ConfigObj(server_cfg, file_error=True)
existed = True
except IOError:
LOG.debug("Did not find file %s", server_cfg)
mcollective_config = ConfigObj()
existed = False
it'd be nicer if we had use caught the error with util.load_file and then done
ConfigObj with the contents. but an older version of ConfigObj did not support
that (i think ancient version, but i wasn't sure what versions were in what
distro).
could you make that change also ?
--
https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301728
Your team cloud init development team is requested to review the proposed merge
of ~harlowja/cloud-init:newer-configobj into cloud-init:master.
___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/digitalocean into lp:cloud-init
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:1264 https://jenkins.ubuntu.com/server/job/cloud-init-ci/4/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=amd64/4/console FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=ppc64el/4/console Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/4/rebuild -- https://code.launchpad.net/~utlemming/cloud-init/digitalocean/+merge/301123 Your team cloud init development team is requested to review the proposed merge of lp:~utlemming/cloud-init/digitalocean into lp:cloud-init. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:scm-version into cloud-init:master
This would be runtime dependency, right? i'd really rather not take that. I'm not opposed to this and woudl like version information to follow *some* standard. what i have now is just what comes out of git describe modified a bit. see tools/make-tarball # revname could be 0.7.5 or 0.7.5-NNN-gHASH # turn that into 0.7.5 or 0.7.5+NNN.gHASH that currently shows: 0.7.6+1026-gef54bea python -c 'from setuptools_scm import get_version; print(get_version())' shows 0.7.7.dev1023+ng72d6adc is .dev1023+ngHASH better in some way ? -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301727 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:scm-version into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
