Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:cleanup/integration-chrony-unittest2-skiptest into cloud-init:master
assuming it passes c-i and the failing test passes then looksk good to me. -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/355803 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:cleanup/integration-chrony-unittest2-skiptest into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:cleanup/integration-chrony-unittest2-skiptest into cloud-init:master
The proposal to merge ~chad.smith/cloud-init:cleanup/integration-chrony-unittest2-skiptest into cloud-init:master has been updated. Description changed to: to test: - make deb - tox -e citest -- run --verbose --preserve-data --data-dir results --platform lxd --os-name xenial --test modules/ntp_chrony --deb cloud-init_*deb For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/355803 -- Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:cleanup/integration-chrony-unittest2-skiptest into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:cleanup/integration-chrony-unittest2-skiptest into cloud-init:master
Chad Smith has proposed merging
~chad.smith/cloud-init:cleanup/integration-chrony-unittest2-skiptest into
cloud-init:master.
Commit message:
cii-tests: use unittest2.SkipTest in test_chrony due to new deps
Git commitish fc4b966ba928b30b1c586407e752e0b51b1031e8 changed integration
test dependencies from unittest to unittest2. Use unittest2.SkipTest in
test_chrony to avoid causing tracebacks.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/355803
--
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/cloud-init:cleanup/integration-chrony-unittest2-skiptest into
cloud-init:master.
diff --git a/tests/cloud_tests/testcases/modules/ntp_chrony.py b/tests/cloud_tests/testcases/modules/ntp_chrony.py
index 7d34177..0f4c3d0 100644
--- a/tests/cloud_tests/testcases/modules/ntp_chrony.py
+++ b/tests/cloud_tests/testcases/modules/ntp_chrony.py
@@ -1,7 +1,7 @@
# This file is part of cloud-init. See LICENSE file for license information.
"""cloud-init Integration Test Verify Script."""
-import unittest
+import unittest2
from tests.cloud_tests.testcases import base
@@ -13,7 +13,7 @@ class TestNtpChrony(base.CloudTestCase):
"""Skip this suite of tests on lxd and artful or older."""
if self.platform == 'lxd':
if self.is_distro('ubuntu') and self.os_version_cmp('artful') <= 0:
-raise unittest.SkipTest(
+raise unittest2.SkipTest(
'No support for chrony on containers <= artful.'
' LP: #1589780')
return super(TestNtpChrony, self).setUp()
___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~glasnt/cloud-init:topic/udevadm-sp into cloud-init:master
Hi, Thank you for contributing to cloud-init. To contribute, you must sign the Canonical Contributor License Agreement (CLA) [1]. If you have already signed it as an individual, your Launchpad user will be listed in the contributor-agreement-canonical launchpad group [2]. Unfortunately there is no easy way to check if an organization or company you are doing work for has signed. If you are unsure or have questions, email scott.mo...@canonical.com or ping smoser in #cloud-init channel via freenode. For information on how to sign, please see the HACKING document [3]. Thanks again, and please feel free to reach out with any questions. – [1] http://www.canonical.com/contributors [2] https://launchpad.net/~contributor-agreement-canonical/+members [3] http://cloudinit.readthedocs.io/en/latest/topics/hacking.html -- https://code.launchpad.net/~glasnt/cloud-init/+git/cloud-init/+merge/355287 Your team cloud-init commiters is requested to review the proposed merge of ~glasnt/cloud-init:topic/udevadm-sp into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
