Re: [Cluster-devel] [GFS2 PATCH] gfs2: clear buf_in_tr when ending a transaction in sweep_bh_for_rgrps

[Andreas Gruenbacher]

On Thu, Sep 12, 2019 at 7:59 PM Bob Peterson  wrote:
> Hi,
>
> In function sweep_bh_for_rgrps, which is a helper for punch_hole,
> it uses variable buf_in_tr to keep track of when it needs to commit
> pending block frees on a partial delete that overflows the
> transaction created for the delete. The problem is that the
> variable was initialized at the start of function sweep_bh_for_rgrps
> but it was never cleared, even when starting a new transaction.
>
> This patch reinitializes the variable when the transaction is
> ended, so the next transaction starts out with it cleared.
>
> Signed-off-by: Bob Peterson 

I've put this onto for-next for the current merge window.

Thanks,
Andreas

[Cluster-devel] [GFS2 PATCH] gfs2: clear buf_in_tr when ending a transaction in sweep_bh_for_rgrps

[Bob Peterson]

Hi,

In function sweep_bh_for_rgrps, which is a helper for punch_hole,
it uses variable buf_in_tr to keep track of when it needs to commit
pending block frees on a partial delete that overflows the
transaction created for the delete. The problem is that the
variable was initialized at the start of function sweep_bh_for_rgrps
but it was never cleared, even when starting a new transaction.

This patch reinitializes the variable when the transaction is
ended, so the next transaction starts out with it cleared.

Signed-off-by: Bob Peterson 
---
 fs/gfs2/bmap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index 9ef543dd38e2..f63df54a08c6 100644
--- a/fs/gfs2/bmap.c
+++ b/fs/gfs2/bmap.c
@@ -1632,6 +1632,7 @@ static int sweep_bh_for_rgrps(struct gfs2_inode *ip, 
struct gfs2_holder *rd_gh,
brelse(dibh);
up_write(>i_rw_mutex);
gfs2_trans_end(sdp);
+   buf_in_tr = false;
}
gfs2_glock_dq_uninit(rd_gh);
cond_resched();