Re: [Cluster-devel] [PATCH 08/12] ext4: Convert to private i_dquot field

2014-11-04 Thread Theodore Ts'o
On Tue, Nov 04, 2014 at 12:19:49PM +0100, Jan Kara wrote:
> CC: linux-e...@vger.kernel.org
> CC: "Theodore Ts'o" 
> Signed-off-by: Jan Kara 

Acked-by: Theodore Ts'o 

- Ted



[Cluster-devel] [PATCH 08/12] ext4: Convert to private i_dquot field

2014-11-04 Thread Jan Kara
CC: linux-e...@vger.kernel.org
CC: "Theodore Ts'o" 
Signed-off-by: Jan Kara 
---
 fs/ext4/ext4.h  | 4 
 fs/ext4/super.c | 8 
 2 files changed, 12 insertions(+)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index c55a1faaed58..db3f772e57ae 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -941,6 +941,10 @@ struct ext4_inode_info {
tid_t i_sync_tid;
tid_t i_datasync_tid;
 
+#ifdef CONFIG_QUOTA
+   struct dquot *i_dquot[MAXQUOTAS];
+#endif
+
/* Precomputed uuid+inum+igen checksum for seeding inode checksums */
__u32 i_csum_seed;
 };
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 1eda6ab0ef9d..07ca5711cbce 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -892,6 +892,7 @@ static struct inode *ext4_alloc_inode(struct super_block 
*sb)
spin_lock_init(&(ei->i_block_reservation_lock));
 #ifdef CONFIG_QUOTA
ei->i_reserved_quota = 0;
+   memset(&ei->i_dquot, 0, sizeof(ei->i_dquot));
 #endif
ei->jinode = NULL;
INIT_LIST_HEAD(&ei->i_rsv_conversion_list);
@@ -1068,6 +1069,11 @@ static int ext4_quota_enable(struct super_block *sb, int 
type, int format_id,
 unsigned int flags);
 static int ext4_enable_quotas(struct super_block *sb);
 
+static struct dquot **ext4_get_dquots(struct inode *inode)
+{
+   return EXT4_I(inode)->i_dquot;
+}
+
 static const struct dquot_operations ext4_quota_operations = {
.get_reserved_space = ext4_get_reserved_space,
.write_dquot= ext4_write_dquot,
@@ -1117,6 +1123,7 @@ static const struct super_operations ext4_sops = {
 #ifdef CONFIG_QUOTA
.quota_read = ext4_quota_read,
.quota_write= ext4_quota_write,
+   .get_dquots = ext4_get_dquots,
 #endif
.bdev_try_to_free_page = bdev_try_to_free_page,
 };
@@ -3928,6 +3935,7 @@ static int ext4_fill_super(struct super_block *sb, void 
*data, int silent)
sb->s_qcop = &ext4_qctl_sysfile_operations;
else
sb->s_qcop = &ext4_qctl_operations;
+   sb->s_quota_types = QTYPE_MASK_USR | QTYPE_MASK_GRP;
 #endif
memcpy(sb->s_uuid, es->s_uuid, sizeof(es->s_uuid));
 
-- 
1.8.1.4



[Cluster-devel] [PATCH 08/12] ext4: Convert to private i_dquot field

2014-10-21 Thread Jan Kara
CC: linux-e...@vger.kernel.org
CC: "Theodore Ts'o" 
Signed-off-by: Jan Kara 
---
 fs/ext4/ext4.h  | 4 
 fs/ext4/super.c | 8 
 2 files changed, 12 insertions(+)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index c55a1faaed58..db3f772e57ae 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -941,6 +941,10 @@ struct ext4_inode_info {
tid_t i_sync_tid;
tid_t i_datasync_tid;
 
+#ifdef CONFIG_QUOTA
+   struct dquot *i_dquot[MAXQUOTAS];
+#endif
+
/* Precomputed uuid+inum+igen checksum for seeding inode checksums */
__u32 i_csum_seed;
 };
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 1eda6ab0ef9d..7207799e5939 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -892,6 +892,7 @@ static struct inode *ext4_alloc_inode(struct super_block 
*sb)
spin_lock_init(&(ei->i_block_reservation_lock));
 #ifdef CONFIG_QUOTA
ei->i_reserved_quota = 0;
+   memset(&ei->i_dquot, 0, sizeof(ei->i_dquot));
 #endif
ei->jinode = NULL;
INIT_LIST_HEAD(&ei->i_rsv_conversion_list);
@@ -1068,6 +1069,11 @@ static int ext4_quota_enable(struct super_block *sb, int 
type, int format_id,
 unsigned int flags);
 static int ext4_enable_quotas(struct super_block *sb);
 
+static struct dquot **ext4_get_dquots(struct inode *inode)
+{
+   return EXT4_I(inode)->i_dquot;
+}
+
 static const struct dquot_operations ext4_quota_operations = {
.get_reserved_space = ext4_get_reserved_space,
.write_dquot= ext4_write_dquot,
@@ -1117,6 +1123,7 @@ static const struct super_operations ext4_sops = {
 #ifdef CONFIG_QUOTA
.quota_read = ext4_quota_read,
.quota_write= ext4_quota_write,
+   .get_dquots = ext4_get_dquots,
 #endif
.bdev_try_to_free_page = bdev_try_to_free_page,
 };
@@ -3928,6 +3935,7 @@ static int ext4_fill_super(struct super_block *sb, void 
*data, int silent)
sb->s_qcop = &ext4_qctl_sysfile_operations;
else
sb->s_qcop = &ext4_qctl_operations;
+   sb_dqopt(sb)->allowed_types = QTYPE_MASK_USR | QTYPE_MASK_GRP;
 #endif
memcpy(sb->s_uuid, es->s_uuid, sizeof(es->s_uuid));
 
-- 
1.8.1.4



[Cluster-devel] [PATCH 08/12] ext4: Convert to private i_dquot field

2014-10-10 Thread Jan Kara
CC: linux-e...@vger.kernel.org
CC: "Theodore Ts'o" 
Signed-off-by: Jan Kara 
---
 fs/ext4/ext4.h  |  4 
 fs/ext4/super.c | 10 ++
 2 files changed, 14 insertions(+)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index b0c225cdb52c..571a9f409e94 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -940,6 +940,10 @@ struct ext4_inode_info {
tid_t i_sync_tid;
tid_t i_datasync_tid;
 
+#ifdef CONFIG_QUOTA
+   struct dquot *i_dquot[MAXQUOTAS];
+#endif
+
/* Precomputed uuid+inum+igen checksum for seeding inode checksums */
__u32 i_csum_seed;
 };
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0b28b36e7915..ceac3c1b1552 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -895,6 +895,7 @@ static struct inode *ext4_alloc_inode(struct super_block 
*sb)
spin_lock_init(&(ei->i_block_reservation_lock));
 #ifdef CONFIG_QUOTA
ei->i_reserved_quota = 0;
+   memset(&ei->i_dquot, 0, sizeof(ei->i_dquot));
 #endif
ei->jinode = NULL;
INIT_LIST_HEAD(&ei->i_rsv_conversion_list);
@@ -1143,6 +1144,13 @@ static const struct super_operations ext4_nojournal_sops 
= {
.bdev_try_to_free_page = bdev_try_to_free_page,
 };
 
+static const int ext4_inode_fields[IF_FIELD_NR] = {
+#ifdef CONFIG_QUOTA
+   [IF_DQUOTS] = offsetof(struct ext4_inode_info, i_dquot) -
+ offsetof(struct ext4_inode_info, vfs_inode),
+#endif
+};
+
 static const struct export_operations ext4_export_ops = {
.fh_to_dentry = ext4_fh_to_dentry,
.fh_to_parent = ext4_fh_to_parent,
@@ -3916,7 +3924,9 @@ static int ext4_fill_super(struct super_block *sb, void 
*data, int silent)
sb->s_qcop = &ext4_qctl_sysfile_operations;
else
sb->s_qcop = &ext4_qctl_operations;
+   sb_dqopt(sb)->allowed_types = QTYPE_MASK_USR | QTYPE_MASK_GRP;
 #endif
+   sb_init_inode_fields(sb, ext4_inode_fields);
memcpy(sb->s_uuid, es->s_uuid, sizeof(es->s_uuid));
 
INIT_LIST_HEAD(&sbi->s_orphan); /* unlinked but open files */
-- 
1.8.1.4



[Cluster-devel] [PATCH 08/12] ext4: Convert to private i_dquot field

2014-10-01 Thread Jan Kara
CC: linux-e...@vger.kernel.org
CC: "Theodore Ts'o" 
Signed-off-by: Jan Kara 
---
 fs/ext4/ext4.h  |  4 
 fs/ext4/super.c | 10 ++
 2 files changed, 14 insertions(+)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index b0c225cdb52c..571a9f409e94 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -940,6 +940,10 @@ struct ext4_inode_info {
tid_t i_sync_tid;
tid_t i_datasync_tid;
 
+#ifdef CONFIG_QUOTA
+   struct dquot *i_dquot[MAXQUOTAS];
+#endif
+
/* Precomputed uuid+inum+igen checksum for seeding inode checksums */
__u32 i_csum_seed;
 };
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0b28b36e7915..a4cccf9fba60 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -895,6 +895,7 @@ static struct inode *ext4_alloc_inode(struct super_block 
*sb)
spin_lock_init(&(ei->i_block_reservation_lock));
 #ifdef CONFIG_QUOTA
ei->i_reserved_quota = 0;
+   memset(&ei->i_dquot, 0, sizeof(ei->i_dquot));
 #endif
ei->jinode = NULL;
INIT_LIST_HEAD(&ei->i_rsv_conversion_list);
@@ -1143,6 +1144,13 @@ static const struct super_operations ext4_nojournal_sops 
= {
.bdev_try_to_free_page = bdev_try_to_free_page,
 };
 
+static const int ext4_inode_fields[IF_FIELD_NR] = {
+#ifdef CONFIG_QUOTA
+   [IF_DQUOTS] = offsetof(struct ext4_inode_info, i_dquot) -
+ offsetof(struct ext4_inode_info, vfs_inode),
+#endif
+};
+
 static const struct export_operations ext4_export_ops = {
.fh_to_dentry = ext4_fh_to_dentry,
.fh_to_parent = ext4_fh_to_parent,
@@ -3916,7 +3924,9 @@ static int ext4_fill_super(struct super_block *sb, void 
*data, int silent)
sb->s_qcop = &ext4_qctl_sysfile_operations;
else
sb->s_qcop = &ext4_qctl_operations;
+   sb_dqopt(sb)->allowed_types = (1 << USRQUOTA) | (1 << GRPQUOTA);
 #endif
+   sb_init_inode_fields(sb, ext4_inode_fields);
memcpy(sb->s_uuid, es->s_uuid, sizeof(es->s_uuid));
 
INIT_LIST_HEAD(&sbi->s_orphan); /* unlinked but open files */
-- 
1.8.1.4