Re: [Cluster-devel] [PATCH V12 06/20] block: rename bvec helpers

2018-11-26 Thread Omar Sandoval
On Mon, Nov 26, 2018 at 10:17:06AM +0800, Ming Lei wrote:
> We will support multi-page bvec soon, and have to deal with
> single-page vs multi-page bvec. This patch follows Christoph's
> suggestion to rename all the following helpers:
> 
>   for_each_bvec
>   bvec_iter_bvec
>   bvec_iter_len
>   bvec_iter_page
>   bvec_iter_offset
> 
> into:
>   for_each_segment
>   segment_iter_bvec
>   segment_iter_len
>   segment_iter_page
>   segment_iter_offset
> 
> so that these helpers named with 'segment' only deal with single-page
> bvec, or called segment. We will introduce helpers named with 'bvec'
> for multi-page bvec.
> 
> bvec_iter_advance() isn't renamed becasue this helper is always operated
> on real bvec even though multi-page bvec is supported.
> 
> Suggested-by: Christoph Hellwig 

Reviewed-by: Omar Sandoval 

> Signed-off-by: Ming Lei 
> ---
>  .clang-format  |  2 +-
>  drivers/md/dm-integrity.c  |  2 +-
>  drivers/md/dm-io.c |  4 ++--
>  drivers/nvdimm/blk.c   |  4 ++--
>  drivers/nvdimm/btt.c   |  4 ++--
>  include/linux/bio.h| 10 +-
>  include/linux/bvec.h   | 20 +++-
>  include/linux/ceph/messenger.h |  2 +-
>  lib/iov_iter.c |  2 +-
>  net/ceph/messenger.c   | 14 +++---
>  10 files changed, 33 insertions(+), 31 deletions(-)



Re: [Cluster-devel] [PATCH V12 06/20] block: rename bvec helpers

2018-11-26 Thread Christoph Hellwig
On Mon, Nov 26, 2018 at 10:17:06AM +0800, Ming Lei wrote:
> We will support multi-page bvec soon, and have to deal with
> single-page vs multi-page bvec. This patch follows Christoph's
> suggestion to rename all the following helpers:
> 
>   for_each_bvec
>   bvec_iter_bvec
>   bvec_iter_len
>   bvec_iter_page
>   bvec_iter_offset
> 
> into:
>   for_each_segment
>   segment_iter_bvec
>   segment_iter_len
>   segment_iter_page
>   segment_iter_offset
> 
> so that these helpers named with 'segment' only deal with single-page
> bvec, or called segment. We will introduce helpers named with 'bvec'
> for multi-page bvec.
> 
> bvec_iter_advance() isn't renamed becasue this helper is always operated
> on real bvec even though multi-page bvec is supported.
> 
> Suggested-by: Christoph Hellwig 
> Signed-off-by: Ming Lei 

Looks fine,

Reviewed-by: Christoph Hellwig 



Re: [Cluster-devel] [PATCH V12 06/20] block: rename bvec helpers

2018-11-26 Thread Miguel Ojeda
On Mon, Nov 26, 2018 at 3:20 AM Ming Lei  wrote:
>
> We will support multi-page bvec soon, and have to deal with
> single-page vs multi-page bvec. This patch follows Christoph's
> suggestion to rename all the following helpers:
>
> for_each_bvec
> bvec_iter_bvec
> bvec_iter_len
> bvec_iter_page
> bvec_iter_offset
>
> into:
> for_each_segment
> segment_iter_bvec
> segment_iter_len
> segment_iter_page
> segment_iter_offset
>
> so that these helpers named with 'segment' only deal with single-page
> bvec, or called segment. We will introduce helpers named with 'bvec'
> for multi-page bvec.
>
> bvec_iter_advance() isn't renamed becasue this helper is always operated
> on real bvec even though multi-page bvec is supported.
>
> Suggested-by: Christoph Hellwig 
> Signed-off-by: Ming Lei 
> ---
>  .clang-format  |  2 +-

Acked-by: Miguel Ojeda 

Cheers,
Miguel



[Cluster-devel] [PATCH V12 06/20] block: rename bvec helpers

2018-11-25 Thread Ming Lei
We will support multi-page bvec soon, and have to deal with
single-page vs multi-page bvec. This patch follows Christoph's
suggestion to rename all the following helpers:

for_each_bvec
bvec_iter_bvec
bvec_iter_len
bvec_iter_page
bvec_iter_offset

into:
for_each_segment
segment_iter_bvec
segment_iter_len
segment_iter_page
segment_iter_offset

so that these helpers named with 'segment' only deal with single-page
bvec, or called segment. We will introduce helpers named with 'bvec'
for multi-page bvec.

bvec_iter_advance() isn't renamed becasue this helper is always operated
on real bvec even though multi-page bvec is supported.

Suggested-by: Christoph Hellwig 
Signed-off-by: Ming Lei 
---
 .clang-format  |  2 +-
 drivers/md/dm-integrity.c  |  2 +-
 drivers/md/dm-io.c |  4 ++--
 drivers/nvdimm/blk.c   |  4 ++--
 drivers/nvdimm/btt.c   |  4 ++--
 include/linux/bio.h| 10 +-
 include/linux/bvec.h   | 20 +++-
 include/linux/ceph/messenger.h |  2 +-
 lib/iov_iter.c |  2 +-
 net/ceph/messenger.c   | 14 +++---
 10 files changed, 33 insertions(+), 31 deletions(-)

diff --git a/.clang-format b/.clang-format
index e6080f5834a3..049200fbab94 100644
--- a/.clang-format
+++ b/.clang-format
@@ -120,7 +120,7 @@ ForEachMacros:
   - 'for_each_available_child_of_node'
   - 'for_each_bio'
   - 'for_each_board_func_rsrc'
-  - 'for_each_bvec'
+  - 'for_each_segment'
   - 'for_each_child_of_node'
   - 'for_each_clear_bit'
   - 'for_each_clear_bit_from'
diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
index bb3096bf2cc6..bb037ed2b4eb 100644
--- a/drivers/md/dm-integrity.c
+++ b/drivers/md/dm-integrity.c
@@ -1574,7 +1574,7 @@ static bool __journal_read_write(struct dm_integrity_io 
*dio, struct bio *bio,
char *tag_ptr = journal_entry_tag(ic, je);
 
if (bip) do {
-   struct bio_vec biv = 
bvec_iter_bvec(bip->bip_vec, bip->bip_iter);
+   struct bio_vec biv = 
segment_iter_bvec(bip->bip_vec, bip->bip_iter);
unsigned tag_now = min(biv.bv_len, 
tag_todo);
char *tag_addr;
BUG_ON(PageHighMem(biv.bv_page));
diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
index 81ffc59d05c9..d72ec2bdd333 100644
--- a/drivers/md/dm-io.c
+++ b/drivers/md/dm-io.c
@@ -208,8 +208,8 @@ static void list_dp_init(struct dpages *dp, struct 
page_list *pl, unsigned offse
 static void bio_get_page(struct dpages *dp, struct page **p,
 unsigned long *len, unsigned *offset)
 {
-   struct bio_vec bvec = bvec_iter_bvec((struct bio_vec *)dp->context_ptr,
-dp->context_bi);
+   struct bio_vec bvec = segment_iter_bvec((struct bio_vec 
*)dp->context_ptr,
+   dp->context_bi);
 
*p = bvec.bv_page;
*len = bvec.bv_len;
diff --git a/drivers/nvdimm/blk.c b/drivers/nvdimm/blk.c
index db45c6bbb7bb..dfae945216bb 100644
--- a/drivers/nvdimm/blk.c
+++ b/drivers/nvdimm/blk.c
@@ -89,9 +89,9 @@ static int nd_blk_rw_integrity(struct nd_namespace_blk *nsblk,
struct bio_vec bv;
void *iobuf;
 
-   bv = bvec_iter_bvec(bip->bip_vec, bip->bip_iter);
+   bv = segment_iter_bvec(bip->bip_vec, bip->bip_iter);
/*
-* The 'bv' obtained from bvec_iter_bvec has its .bv_len and
+* The 'bv' obtained from segment_iter_bvec has its .bv_len and
 * .bv_offset already adjusted for iter->bi_bvec_done, and we
 * can use those directly
 */
diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
index b123b0dcf274..2bbbc90c7b91 100644
--- a/drivers/nvdimm/btt.c
+++ b/drivers/nvdimm/btt.c
@@ -1154,9 +1154,9 @@ static int btt_rw_integrity(struct btt *btt, struct 
bio_integrity_payload *bip,
struct bio_vec bv;
void *mem;
 
-   bv = bvec_iter_bvec(bip->bip_vec, bip->bip_iter);
+   bv = segment_iter_bvec(bip->bip_vec, bip->bip_iter);
/*
-* The 'bv' obtained from bvec_iter_bvec has its .bv_len and
+* The 'bv' obtained from segment_iter_bvec has its .bv_len and
 * .bv_offset already adjusted for iter->bi_bvec_done, and we
 * can use those directly
 */
diff --git a/include/linux/bio.h b/include/linux/bio.h
index 6f6bc331a5d1..6a0ff02f4d1c 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -48,14 +48,14 @@
 #define bio_set_prio(bio, prio)((bio)->bi_ioprio = prio)
 
 #define bio_iter_iovec(bio,