[CMake] FindQt4 errors out when locating QtUITools under CMake 2.8.5

2011-07-25 Thread Charlie Sharpsteen
I ran into an issue after upgrading from CMake 2.8.4 to 2.8.5---the following
no longer works:

FIND_PACKAGE(Qt4 COMPONENTS QtUiTools REQUIRED)

I traced the problem down to a hunk in commit
e7f05d9759ec5bc393760daee91bb7223f6c56d0:

diff --git a/Modules/FindQt4.cmake b/Modules/FindQt4.cmake
index 108012a..86fce9d 100644
--- a/Modules/FindQt4.cmake
+++ b/Modules/FindQt4.cmake
@@ -608,18 +608,6 @@ IF (QT_QMAKE_EXECUTABLE AND QTVERSION)

If I `patch -R` this hunk before building and installing CMake 2.8.5 then
FIND_PACKAGE can successfully locate QtUiTools.

More details on GitHub:

https://github.com/Kitware/CMake/issues/7

-Charlie

--
View this message in context: 
http://cmake.3232098.n2.nabble.com/FindQt4-errors-out-when-locating-QtUITools-under-CMake-2-8-5-tp6619091p6619091.html
Sent from the CMake mailing list archive at Nabble.com.
___
Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


Re: [CMake] FindQt4 errors out when locating QtUITools under CMake 2.8.5

2011-07-25 Thread Clinton Stimpson
On Monday, July 25, 2011 10:55:58 am Charlie Sharpsteen wrote:
 I ran into an issue after upgrading from CMake 2.8.4 to 2.8.5---the
 following no longer works:
 
 FIND_PACKAGE(Qt4 COMPONENTS QtUiTools REQUIRED)
 
 I traced the problem down to a hunk in commit
 e7f05d9759ec5bc393760daee91bb7223f6c56d0:
 
 diff --git a/Modules/FindQt4.cmake b/Modules/FindQt4.cmake
 index 108012a..86fce9d 100644
 --- a/Modules/FindQt4.cmake
 +++ b/Modules/FindQt4.cmake
 @@ -608,18 +608,6 @@ IF (QT_QMAKE_EXECUTABLE AND QTVERSION)
 
 If I `patch -R` this hunk before building and installing CMake 2.8.5 then
 FIND_PACKAGE can successfully locate QtUiTools.
 
 More details on GitHub:
 
 https://github.com/Kitware/CMake/issues/7
 

Thanks for finding.  Its been fixed in git.

702538e Qt4: Fix reference of undefined variable when detecting frameworks on 
Mac OS X

-- 
Clinton Stimpson
Elemental Technologies, Inc
Computational Simulation Software, LLC
www.csimsoft.com
___
Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


Re: [CMake] FindQt4 errors out when locating QtUITools under CMake 2.8.5

2011-07-25 Thread Charlie Sharpsteen

Clinton Stimpson wrote:
 
 Thanks for finding.  Its been fixed in git.
 
 702538e Qt4: Fix reference of undefined variable when detecting frameworks
 on 
 Mac OS X
 

I can confirm that that patch fixes the problem. Thanks a bunch!

-Charlie


--
View this message in context: 
http://cmake.3232098.n2.nabble.com/FindQt4-errors-out-when-locating-QtUITools-under-CMake-2-8-5-tp6619091p6619700.html
Sent from the CMake mailing list archive at Nabble.com.
___
Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake