Re: [CMake] Warning in CMake Git HEAD

2013-09-19 Thread Williams, Norman K
It is a typo.  This is a warning generated by a very recent development
head version of CLang I built.

It looks like it was added to CMake by Andy Cedilnik in revision 9314bb;
It looks like an upstream typo that just happened never to cause a
real-world problem.
--
Kent Williams norman-k-willi...@uiowa.edu






On 9/19/13 11:15 AM, "Sean McBride"  wrote:

>On Thu, 19 Sep 2013 15:12:54 +, Williams, Norman K said:
>
>>This looks like a simple typo.  I could fix it and submit a gerrit topic,
>>but I'm busy with other stuff for the moment.
>>
>>Or is this a typo imported from CURL?
>>
>>In file included from
>>/scratch/kent/cmake/cmake/Utilities/cmcurl/http.c:99:
>>/scratch/kent/cmake/cmake/Utilities/cmcurl/parsedate.h:1:9: warning:
>>'__PARSEDATE_H' is used as a header guard here, followed
>>  by #define of a different macro [-Wheader-guard]
>>#ifndef __PARSEDATE_H
>>^
>>/scratch/kent/cmake/cmake/Utilities/cmcurl/parsedate.h:2:9: note:
>>'__PARSEDATEL_H' is defined here; did you mean
>>  '__PARSEDATE_H'?
>>#define __PARSEDATEL_H
>>^~
>>__PARSEDATE_H
>
>Strange that my dashboard is not showing this, I'll check on that.  It
>does look like a typo.  That's 3rd party code, right?  Maybe it is fixed
>upstream?  (Also, it's illegal to start an identifier with two
>underscores.)
>
>Cheers,
>
>--
>
>Sean McBride, B. Eng s...@rogue-research.com
>Rogue Researchwww.rogue-research.com
>Mac Software Developer  Montréal, Québec, Canada
>
>




Notice: This UI Health Care e-mail (including attachments) is covered by the 
Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and 
may be legally privileged.  If you are not the intended recipient, you are 
hereby notified that any retention, dissemination, distribution, or copying of 
this communication is strictly prohibited.  Please reply to the sender that you 
have received the message in error, then delete it.  Thank you.

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


Re: [CMake] Warning in CMake Git HEAD

2013-09-19 Thread Sean McBride
On Thu, 19 Sep 2013 15:12:54 +, Williams, Norman K said:

>This looks like a simple typo.  I could fix it and submit a gerrit topic,
>but I'm busy with other stuff for the moment.
>
>Or is this a typo imported from CURL?
>
>In file included from /scratch/kent/cmake/cmake/Utilities/cmcurl/http.c:99:
>/scratch/kent/cmake/cmake/Utilities/cmcurl/parsedate.h:1:9: warning:
>'__PARSEDATE_H' is used as a header guard here, followed
>  by #define of a different macro [-Wheader-guard]
>#ifndef __PARSEDATE_H
>^
>/scratch/kent/cmake/cmake/Utilities/cmcurl/parsedate.h:2:9: note:
>'__PARSEDATEL_H' is defined here; did you mean
>  '__PARSEDATE_H'?
>#define __PARSEDATEL_H
>^~
>__PARSEDATE_H

Strange that my dashboard is not showing this, I'll check on that.  It does 
look like a typo.  That's 3rd party code, right?  Maybe it is fixed upstream?  
(Also, it's illegal to start an identifier with two underscores.)

Cheers,

-- 

Sean McBride, B. Eng s...@rogue-research.com
Rogue Researchwww.rogue-research.com 
Mac Software Developer  Montréal, Québec, Canada


--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


Re: [CMake] Warning in CMake Git HEAD

2013-09-19 Thread Sean McBride
On Thu, 19 Sep 2013 17:08:21 +, Williams, Norman K said:

>It is a typo.  This is a warning generated by a very recent development
>head version of CLang I built.

My Rogue7 dashboard uses clang trunk, but I just noticed I never switched to a 
-Weverything + subtractive warning policy like I did for my VTK dashboards.  
Will fix that too.

>It looks like it was added to CMake by Andy Cedilnik in revision 9314bb;
>It looks like an upstream typo that just happened never to cause a
>real-world problem.

I've created a patch, which I'll share on the cmake-dev list...

Cheers,

-- 

Sean McBride, B. Eng s...@rogue-research.com
Rogue Researchwww.rogue-research.com 
Mac Software Developer  Montréal, Québec, Canada


--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake


[CMake] Warning in CMake Git HEAD

2013-09-19 Thread Williams, Norman K
This looks like a simple typo.  I could fix it and submit a gerrit topic,
but I'm busy with other stuff for the moment.

Or is this a typo imported from CURL?

In file included from /scratch/kent/cmake/cmake/Utilities/cmcurl/http.c:99:
/scratch/kent/cmake/cmake/Utilities/cmcurl/parsedate.h:1:9: warning:
'__PARSEDATE_H' is used as a header guard here, followed
  by #define of a different macro [-Wheader-guard]
#ifndef __PARSEDATE_H
^
/scratch/kent/cmake/cmake/Utilities/cmcurl/parsedate.h:2:9: note:
'__PARSEDATEL_H' is defined here; did you mean
  '__PARSEDATE_H'?
#define __PARSEDATEL_H
^~
__PARSEDATE_H



--
Kent Williams norman-k-willi...@uiowa.edu







Notice: This UI Health Care e-mail (including attachments) is covered by the 
Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and 
may be legally privileged.  If you are not the intended recipient, you are 
hereby notified that any retention, dissemination, distribution, or copying of 
this communication is strictly prohibited.  Please reply to the sender that you 
have received the message in error, then delete it.  Thank you.

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake