Re: [CMake] [ANNOUNCE] CMake 3.4.0-rc1 is now ready!

2015-11-09 Thread Alan W. Irwin 

On 2015-10-22 13:30-0400 Brad King wrote:

[...]

Plplot's Ada support uses CMake internal APIs so it is plplot's
responsibility to adapt to our changes:

[...]

Where Plplot currently writes:

 SET(CMAKE_Ada_COMPILE_OBJECT
   "  -c  -o 
   ")

try:

 if(NOT CMAKE_VERSION VERSION_LESS 3.4)
   set(CMAKE_Ada_COMPILE_OBJECT
 "   -c  -o ")
 else()
   set(CMAKE_Ada_COMPILE_OBJECT
 "  -c  -o ")
 endif()


To bring this thread to conclusion, Orion implemented Brad's idea for
PLplot's Ada language support (see
),
and I just did the same thing for PLplot's D language support (see
)
with good test results for Ada and D examples for both shared and
static libraries and both CMake-3.3.2 and CMake-3.4.0-rc3.

Thanks, Brad, for your essential help in solving these PLplot Ada and
D issues caused by the internal changes in CMake's language support
infrastructure for CMake-3.4.

Alan
__
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__

Linux-powered Science
__
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

Re: [CMake] [ANNOUNCE] CMake 3.4.0-rc1 is now ready!

2015-10-30 Thread Orion Poplawski 

On 10/22/2015 11:30 AM, Brad King wrote:

On 10/22/2015 11:28 AM, Orion Poplawski wrote:

This appears to have broken plplot's ada build on Fedora.


FYI - builds still fail with cmake 3.4.0-rc2.  Have had time to look at it
closer.  plplot issue seems to be triggered by a change in Ada_FLAGS:

-Ada_FLAGS =
-I/home/orion/fedora/plplot/plplot-5.11.1/build-3.3.2/examples/ada
-I/home/orion/fedora/plplot/plplot-5.11.1/bindings/ada
+Ada_FLAGS =

but plplot I believe has custom Ada cmake platform support.  I am still
concerned about possible regressions here.


Plplot's Ada support uses CMake internal APIs so it is plplot's
responsibility to adapt to our changes:

  
https://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/CMakeAddNewLanguage.txt;hb=v3.4.0-rc2
  Maintainers of external language support are responsible for porting
  it to each version of CMake as upstream changes are made.

Our 3.4.0-rc2 release notes point out a change likely causing this problem:

  
https://cmake.org/gitweb?p=cmake.git;a=blob;f=Help/release/3.4.rst;hb=v3.4.0-rc2#l271
  * The internal "CMAKE__COMPILE_OBJECT" rule variable now
substitutes compiler include flags in a separate ""
placeholder instead of the main "" placeholder.

Where Plplot currently writes:

   SET(CMAKE_Ada_COMPILE_OBJECT
 "  -c  -o 
 ")

try:

   if(NOT CMAKE_VERSION VERSION_LESS 3.4)
 set(CMAKE_Ada_COMPILE_OBJECT
   "   -c  -o ")
   else()
 set(CMAKE_Ada_COMPILE_OBJECT
   "  -c  -o ")
   endif()

-Brad



Ah, thank you very much.  The attached patch fixes this.

--
Orion Poplawski
Technical Manager 303-415-9701 x222
NWRA/CoRA DivisionFAX: 303-415-9702
3380 Mitchell Lane  or...@cora.nwra.com
Boulder, CO 80301  http://www.cora.nwra.com
diff -up plplot-5.11.1/cmake/modules/language_support/cmake/CMakeAdaInformation.cmake.cmake34 plplot-5.11.1/cmake/modules/language_support/cmake/CMakeAdaInformation.cmake
--- plplot-5.11.1/cmake/modules/language_support/cmake/CMakeAdaInformation.cmake.cmake34	2015-08-12 11:35:27.0 -0600
+++ plplot-5.11.1/cmake/modules/language_support/cmake/CMakeAdaInformation.cmake	2015-10-29 14:47:44.505370445 -0600
@@ -176,9 +176,13 @@ ENDIF(NOT CMAKE_Ada_CREATE_STATIC_LIBRAR
 
 # compile a Ada file into an object file
 IF(NOT CMAKE_Ada_COMPILE_OBJECT)
-  SET(CMAKE_Ada_COMPILE_OBJECT
-"  -c  -o 
-")
+  IF(NOT CMAKE_VERSION VERSION_LESS 3.4)
+SET(CMAKE_Ada_COMPILE_OBJECT
+  "   -c  -o ")
+  ELSE()
+SET(CMAKE_Ada_COMPILE_OBJECT
+  "  -c  -o ")
+  ENDIF()
 ENDIF(NOT CMAKE_Ada_COMPILE_OBJECT)
 
 # Constraints:  GNAT_EXECUTABLE_BUILDER = gnatmake
diff -up plplot-5.11.1/cmake/test_ada/cmake_experimental/Modules/CMakeAdaInformation.cmake.cmake34 plplot-5.11.1/cmake/test_ada/cmake_experimental/Modules/CMakeAdaInformation.cmake
--- plplot-5.11.1/cmake/test_ada/cmake_experimental/Modules/CMakeAdaInformation.cmake.cmake34	2015-08-12 11:35:27.0 -0600
+++ plplot-5.11.1/cmake/test_ada/cmake_experimental/Modules/CMakeAdaInformation.cmake	2015-10-29 14:49:01.544790784 -0600
@@ -147,9 +147,13 @@ ENDIF(NOT CMAKE_Ada_CREATE_STATIC_LIBRAR
 
 # compile a Ada file into an object file
 IF(NOT CMAKE_Ada_COMPILE_OBJECT)
-  SET(CMAKE_Ada_COMPILE_OBJECT
-"  -c  -o 
-")
+  IF(NOT CMAKE_VERSION VERSION_LESS 3.4)
+SET(CMAKE_Ada_COMPILE_OBJECT
+  "   -c  -o ")
+  ELSE()
+SET(CMAKE_Ada_COMPILE_OBJECT
+  "  -c  -o ")
+  ENDIF()
 ENDIF(NOT CMAKE_Ada_COMPILE_OBJECT)
 
 # Constraints:  GNAT_EXECUTABLE_BUILDER = gnatmake
diff -up plplot-5.11.1/cmake/test_ada/cmake_working/Modules/CMakeAdaInformation.cmake.cmake34 plplot-5.11.1/cmake/test_ada/cmake_working/Modules/CMakeAdaInformation.cmake
--- plplot-5.11.1/cmake/test_ada/cmake_working/Modules/CMakeAdaInformation.cmake.cmake34	2015-08-12 11:35:27.0 -0600
+++ plplot-5.11.1/cmake/test_ada/cmake_working/Modules/CMakeAdaInformation.cmake	2015-10-29 14:48:39.296954258 -0600
@@ -176,9 +176,13 @@ ENDIF(NOT CMAKE_Ada_CREATE_STATIC_LIBRAR
 
 # compile a Ada file into an object file
 IF(NOT CMAKE_Ada_COMPILE_OBJECT)
-  SET(CMAKE_Ada_COMPILE_OBJECT
-"  -c  -o 
-")
+  IF(NOT CMAKE_VERSION VERSION_LESS 3.4)
+SET(CMAKE_Ada_COMPILE_OBJECT
+  "   -c  -o ")
+  ELSE()
+SET(CMAKE_Ada_COMPILE_OBJECT
+  "  -c  -o ")
+  ENDIF()
 ENDIF(NOT CMAKE_Ada_COMPILE_OBJECT)
 
 # Constraints:  GNAT_EXECUTABLE_BUILDER = gnatmake
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to

Re: [CMake] [ANNOUNCE] CMake 3.4.0-rc1 is now ready!

2015-10-23 Thread Brad King 
On 10/07/2015 12:45 PM, Orion Poplawski wrote:
> There also appears to be a similar issue with building Paraview where the
> MPI_INLCUDE_PATH is no longer being passed to the compile line.

Can you provide any more detail on this problem?  There was only one
change to FindMPI between 3.3.2 and 3.4.0-rc1 and I don't think it
could cause this.  Also ParaView and VTK are not using the internal
CMake interface where the  placeholder was added.

Thanks,
-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

Re: [CMake] [ANNOUNCE] CMake 3.4.0-rc1 is now ready!

2015-10-22 Thread Brad King 
On 10/22/2015 11:28 AM, Orion Poplawski wrote:
>>> This appears to have broken plplot's ada build on Fedora.
> 
> FYI - builds still fail with cmake 3.4.0-rc2.  Have had time to look at it
> closer.  plplot issue seems to be triggered by a change in Ada_FLAGS:
> 
> -Ada_FLAGS =
> -I/home/orion/fedora/plplot/plplot-5.11.1/build-3.3.2/examples/ada
> -I/home/orion/fedora/plplot/plplot-5.11.1/bindings/ada
> +Ada_FLAGS =
> 
> but plplot I believe has custom Ada cmake platform support.  I am still
> concerned about possible regressions here.

Plplot's Ada support uses CMake internal APIs so it is plplot's
responsibility to adapt to our changes:

 
https://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/CMakeAddNewLanguage.txt;hb=v3.4.0-rc2
 Maintainers of external language support are responsible for porting
 it to each version of CMake as upstream changes are made.

Our 3.4.0-rc2 release notes point out a change likely causing this problem:

 
https://cmake.org/gitweb?p=cmake.git;a=blob;f=Help/release/3.4.rst;hb=v3.4.0-rc2#l271
 * The internal "CMAKE__COMPILE_OBJECT" rule variable now
   substitutes compiler include flags in a separate ""
   placeholder instead of the main "" placeholder.

Where Plplot currently writes:

  SET(CMAKE_Ada_COMPILE_OBJECT
"  -c  -o 
")

try:

  if(NOT CMAKE_VERSION VERSION_LESS 3.4)
set(CMAKE_Ada_COMPILE_OBJECT
  "   -c  -o ")
  else()
set(CMAKE_Ada_COMPILE_OBJECT
  "  -c  -o ")
  endif()

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

Re: [CMake] [ANNOUNCE] CMake 3.4.0-rc1 is now ready!

2015-10-22 Thread Alan W. Irwin 

On 2015-10-22 13:30-0400 Brad King wrote:


On 10/22/2015 11:28 AM, Orion Poplawski wrote:

This appears to have broken plplot's ada build on Fedora.


FYI - builds still fail with cmake 3.4.0-rc2.  Have had time to look at it
closer.  plplot issue seems to be triggered by a change in Ada_FLAGS:

-Ada_FLAGS =
-I/home/orion/fedora/plplot/plplot-5.11.1/build-3.3.2/examples/ada
-I/home/orion/fedora/plplot/plplot-5.11.1/bindings/ada
+Ada_FLAGS =

but plplot I believe has custom Ada cmake platform support.  I am still
concerned about possible regressions here.


Plplot's Ada support uses CMake internal APIs so it is plplot's
responsibility to adapt to our changes:

https://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/CMakeAddNewLanguage.txt;hb=v3.4.0-rc2
Maintainers of external language support are responsible for porting
it to each version of CMake as upstream changes are made.

Our 3.4.0-rc2 release notes point out a change likely causing this problem:

https://cmake.org/gitweb?p=cmake.git;a=blob;f=Help/release/3.4.rst;hb=v3.4.0-rc2#l271
* The internal "CMAKE__COMPILE_OBJECT" rule variable now
  substitutes compiler include flags in a separate ""
  placeholder instead of the main "" placeholder.

Where Plplot currently writes:

 SET(CMAKE_Ada_COMPILE_OBJECT
   "  -c  -o 
   ")

try:

 if(NOT CMAKE_VERSION VERSION_LESS 3.4)
   set(CMAKE_Ada_COMPILE_OBJECT
 "   -c  -o ")
 else()
   set(CMAKE_Ada_COMPILE_OBJECT
 "  -c  -o ")
 endif()


Hi Brad:

I will give your suggestion a try.

Alan
__
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__

Linux-powered Science
__
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

Re: [CMake] [ANNOUNCE] CMake 3.4.0-rc1 is now ready!

2015-10-22 Thread Orion Poplawski 
On 10/07/2015 10:45 AM, Orion Poplawski wrote:
> On 10/06/2015 09:00 PM, Orion Poplawski wrote:
>> On 10/06/2015 09:42 AM, Robert Maynard wrote:
>>> I am proud to announce the first CMake 3.4 release candidate.
>>
>> This appears to have broken plplot's ada build on Fedora. Previous good 
>> (cmake
>> 3.3.2):
>>
>> [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o
>> cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && 
>> /usr/bin/gnatgcc
>> -I/builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada
>> -I/builddir/build/BUILD/plplot-5.11.1/bindings/ada-c
>> /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o
>> CMakeFiles/x00a.dir/x00a.o
>>
>> New bad:
>>
>> [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o
>> cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada &&
>> /usr/bin/gnatgcc   -c
>> /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o
>> CMakeFiles/x00a.dir/x00a.o
>> x00a.adb:28:05: file "plplot_auxiliary.ads" not found
>> x00a.adb:29:05: file "plplot_traditional.ads" not found
>> examples/ada/CMakeFiles/x00a.dir/build.make:65: recipe for target
>> 'examples/ada/CMakeFiles/x00a.dir/x00a.o' failed
>>
>> So we're now missing the -I include dir options.
>>
>> That's all I have for now, I'll try to take a closer look later.
>>
> 
> There also appears to be a similar issue with building Paraview where the
> MPI_INLCUDE_PATH is no longer being passed to the compile line.
> 

FYI - builds still fail with cmake 3.4.0-rc2.  Have had time to look at it
closer.  plplot issue seems to be triggered by a change in Ada_FLAGS:


-Ada_FLAGS =
-I/home/orion/fedora/plplot/plplot-5.11.1/build-3.3.2/examples/ada
-I/home/orion/fedora/plplot/plplot-5.11.1/bindings/ada
+Ada_FLAGS =

but plplot I believe has custom Ada cmake platform support.  I am still
concerned about possible regressions here.

-- 
Orion Poplawski
Technical Manager 303-415-9701 x222
NWRA, Boulder/CoRA Office FAX: 303-415-9702
3380 Mitchell Lane   or...@nwra.com
Boulder, CO 80301   http://www.nwra.com
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

Re: [CMake] [ANNOUNCE] CMake 3.4.0-rc1 is now ready!

2015-10-07 Thread Orion Poplawski 
On 10/06/2015 09:00 PM, Orion Poplawski wrote:
> On 10/06/2015 09:42 AM, Robert Maynard wrote:
>> I am proud to announce the first CMake 3.4 release candidate.
> 
> This appears to have broken plplot's ada build on Fedora. Previous good (cmake
> 3.3.2):
> 
> [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o
> cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && /usr/bin/gnatgcc
> -I/builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada
> -I/builddir/build/BUILD/plplot-5.11.1/bindings/ada-c
> /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o
> CMakeFiles/x00a.dir/x00a.o
> 
> New bad:
> 
> [ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o
> cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada &&
> /usr/bin/gnatgcc   -c
> /builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o
> CMakeFiles/x00a.dir/x00a.o
> x00a.adb:28:05: file "plplot_auxiliary.ads" not found
> x00a.adb:29:05: file "plplot_traditional.ads" not found
> examples/ada/CMakeFiles/x00a.dir/build.make:65: recipe for target
> 'examples/ada/CMakeFiles/x00a.dir/x00a.o' failed
> 
> So we're now missing the -I include dir options.
> 
> That's all I have for now, I'll try to take a closer look later.
> 

There also appears to be a similar issue with building Paraview where the
MPI_INLCUDE_PATH is no longer being passed to the compile line.

-- 
Orion Poplawski
Technical Manager 303-415-9701 x222
NWRA, Boulder/CoRA Office FAX: 303-415-9702
3380 Mitchell Lane   or...@nwra.com
Boulder, CO 80301   http://www.nwra.com
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake

Re: [CMake] [ANNOUNCE] CMake 3.4.0-rc1 is now ready!

2015-10-06 Thread Orion Poplawski 

On 10/06/2015 09:42 AM, Robert Maynard wrote:

I am proud to announce the first CMake 3.4 release candidate.


This appears to have broken plplot's ada build on Fedora. Previous good 
(cmake 3.3.2):


[ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o
cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && 
/usr/bin/gnatgcc 
-I/builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada 
-I/builddir/build/BUILD/plplot-5.11.1/bindings/ada-c 
/builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o 
CMakeFiles/x00a.dir/x00a.o


New bad:

[ 22%] Building Ada object examples/ada/CMakeFiles/x00a.dir/x00a.o
cd /builddir/build/BUILD/plplot-5.11.1/fedora/examples/ada && 
/usr/bin/gnatgcc   -c 
/builddir/build/BUILD/plplot-5.11.1/examples/ada/x00a.adb -o 
CMakeFiles/x00a.dir/x00a.o

x00a.adb:28:05: file "plplot_auxiliary.ads" not found
x00a.adb:29:05: file "plplot_traditional.ads" not found
examples/ada/CMakeFiles/x00a.dir/build.make:65: recipe for target 
'examples/ada/CMakeFiles/x00a.dir/x00a.o' failed


So we're now missing the -I include dir options.

That's all I have for now, I'll try to take a closer look later.

--
Orion Poplawski
Technical Manager 303-415-9701 x222
NWRA/CoRA DivisionFAX: 303-415-9702
3380 Mitchell Lane  or...@cora.nwra.com
Boulder, CO 80301  http://www.cora.nwra.com
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake