[cmake-developers] [CMake 0012944]: Feature enabling the CheckC*.cmake macros to use a path to source code as well as supplied source code
The following issue has been SUBMITTED. == http://cmake.org/Bug/view.php?id=12944 == Reported By:starseeker Assigned To: == Project:CMake Issue ID: 12944 Category: Modules Reproducibility:always Severity: feature Priority: normal Status: new == Date Submitted: 2012-02-07 20:36 EST Last Modified: 2012-02-07 20:36 EST == Summary:Feature enabling the CheckC*.cmake macros to use a path to source code as well as supplied source code Description: We often have our own .c file stored in our tree for TRY_RUN testing, and it is convenient to be able to use CHECK_C_RUNS_SOURCE for testing those .c files. At the moment, CHECK_C_RUNS_SOURCE assumes the incoming SOURCE variable actually holds the source code - our enhancement checks to see if SOURCE holds a valid file path first. If it DOES hold a valid file path, TRY_RUN then trys that .c file, otherwise the existing CHECK_C_RUNS_SOURCE is preserved. I don't know of any sane pathname that would be valid C code or vice versa, so there should be no danger of passing in a C source snippit and having it mistaken for a file path. Additional Information: http://www.cmake.org/pipermail/cmake/2012-January/048921.html == Issue History Date ModifiedUsername FieldChange == 2012-02-07 20:36 starseeker New Issue 2012-02-07 20:36 starseeker File Added: 0001-Teach-CheckC.-modules-to-use-a-source-file-as-well-a.patch == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0012943]: Make code groups in xcode match visual studio
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=12943
==
Reported By:Michael Pechner
Assigned To:
==
Project:CMake
Issue ID: 12943
Category: CMake
Reproducibility:always
Severity: minor
Priority: normal
Status: new
==
Date Submitted: 2012-02-07 17:28 EST
Last Modified: 2012-02-07 17:28 EST
==
Summary:Make code groups in xcode match visual studio
Description:
We have a product where 2 of the platforms are windown and osx. The groupings
of files in xcode should match visual studio.
I am submitting this in behalf of another engineer that left the company. I am
submitting this myself because it is the only way to contribute changes back.
OY!
Here is his explanation:
So the source group change fixed a problem specific to Xcode. It's possible to
specify a "\\" delimited directory structure as a group name. So you can do the
following:
source_group( foo foo.c)
source_group( foo\\bar bar.c)
In the VS generator that makes a group foo that contains a group bar and the
file foo.c. The group bar contains the file bar.c This behavior is documented.
Those same lines in the the xcode generator create two groups. One is called
foo and contains foo.c. The other is called "foo/bar" and contains bar.c. This
behavior is not documented
The change corrects the xcode generator behavior to match that of the visual
studio generator/documentation.
If memory serves... The code that was added iterates over the
platform-independent source_group data structure the right way (which preserves
nesting in a recursive fashion) rather than just enumerating every possible
group and adding them without nesting. The diff should be helpful here, because
I believe I checked the whole thing in as a single change.
Additional Information:
I'll include a diff of when we did for both cmGlobalXCodeGenerator.cxx and
cmGlobalXCodeGenerator.h
The diff is between 2.8.4 and 2.8.7.
Here is the .h file diff:
89,91d88
< cmXCodeObject* CreateSourceGroup(cmSourceGroup& sg,
< cmTarget& cmtarget,
< bool child_group);
93,94c90,92
< cmSourceGroup* sg,
< bool target_child);
---
> cmSourceGroup* sg);
> cmXCodeObject* CreatePBXGroup(cmXCodeObject *parent,
> cmStdString name);
127a126,127
> std::string GetOrCreateId(const char* name, const char* id);
>
197,198c197,198
< virtual const char* GetInstallTargetName() { return "install"; }
< virtual const char* GetPackageTargetName() { return "package"; }
---
> virtual const char* GetInstallTargetName() const { return "install"; }
> virtual const char* GetPackageTargetName() const { return "package"; }
201a202
> std::set XCodeObjectIDs;
204a206,208
> void addObject(cmXCodeObject *obj);
> std::string PostBuildMakeTarget(std::string const& tName,
> std::string const& configName);
==
Issue History
Date ModifiedUsername FieldChange
==
2012-02-07 17:28 Michael PechnerNew Issue
2012-02-07 17:28 Michael PechnerFile Added: cmGlobalXCodeGenerator_cxx.txt
==
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0012942]: Would like to specify a different default location for OSX binary
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=12942
==
Reported By:Michael Pechner
Assigned To:
==
Project:CMake
Issue ID: 12942
Category: CMake
Reproducibility:always
Severity: minor
Priority: normal
Status: new
==
Date Submitted: 2012-02-07 16:53 EST
Last Modified: 2012-02-07 16:53 EST
==
Summary:Would like to specify a different default location
for OSX binary
Description:
We don't put our apps in the default location. We have a change to
cmTarget.cxx to make this happen.
We means I finally got permission to report changes my employer made to the code
base.
Additional Information:
We defines a new property:
cm->DefineProperty
("MACOSX_BUNDLE_BINARY_PATH", cmProperty::TARGET,
"If unset, the actual linked binary is assumed to be in ",
"appname.app/Contents/MacOS/appname, if set, then ",
"appname.app/MACOSX_BUNDLE_BINARY_PATH/appname for iOS apps ",
"setting this to the NULL string is currently the correct thing");
In cmTarget::NormalGetLocation we added some code to over ride the default
location:
if(this->IsAppBundleOnApple())
{
this->Location += this->GetFullName(config, false);
//
// iOS binaries are not stored in contents/macos
//
const char* path_override = this->GetProperty( "MACOSX_BUNDLE_BINARY_PATH"
);
if( path_override == NULL )
{
this->Location += ".app/Contents/MacOS/";
}
else
{
this->Location += ".app/";
this->Location += path_override;
if( *path_override )
{
this->Location += "/";
}
}
}
==
Issue History
Date ModifiedUsername FieldChange
==
2012-02-07 16:53 Michael PechnerNew Issue
==
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0012940]: FindBoost.cmake cannot find libraries built with clang on Darwin.
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=12940 == Reported By:David Rogers Assigned To: == Project:CMake Issue ID: 12940 Category: Modules Reproducibility:always Severity: tweak Priority: normal Status: new == Date Submitted: 2012-02-07 14:25 EST Last Modified: 2012-02-07 14:25 EST == Summary:FindBoost.cmake cannot find libraries built with clang on Darwin. Description: If boost libraries are built with clang, their compiler name ends up being clang-darwin instead of xgcc. Because of this, the script fails to locate them. Steps to Reproduce: Build boost with clang. Attempt to locate them in a script. == Issue History Date ModifiedUsername FieldChange == 2012-02-07 14:25 David Rogers New Issue == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
