Re: [cmake-developers] Ninja passes all tests on OS X
On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffman bill.hoff...@kitware.com wrote:
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to
cmNinjaTargetGenerator which
forwards the call to the Local/Global classes.
Lets just add the friend stuff for now so we can get the dashboard
building again.
You could not add friend class
cmNinjaTargetGenerator::MacOSXContentGeneratorType
because cmNinjaTargetGenerator is forward declared, and including
cmNinjaTargetGenerator.h
doesn't help because it includes cmLocalNinjaGenerator.h again.
Maybe making MacOSXContentGeneratorType global helps.
'
There is also a warning here:
C:/Users/hoffman/Work/My Builds/cmake/Source/cmNinjaTargetGenerator.cxx(60)
: warning C4355: 'this' : used in base member initializer list
Making the helper class global should fix the problem. What about a letter
envelope type of thing. Move the whole MacOSXContentGeneratorType into the
.cxx file. Then forward declare the pointer to it in the
cmNinjaTargetGenerator class.
class cmMacOSXContentGeneratorType;
class cmNinjaTargetGenerator
{
...
cmMacOSXContentGeneratorType* MacOSXContentGenerator;
Then create it with new in the constructor. This would get rid of the above
warning as well. I would like to clean this up before the nightly
dashboards get going so we don't have a bunch of red tomorrow.
Bill,
You can find two patches in the following branch which should fix
these compilation issues. I have tested them with clang and gcc on Mac
OS X.
https://github.com/polrop/CMake/commits/ninja/fix_build
https://github.com/polrop/CMake/commit/5497caf3e0e14430a222e92f190d8d9ea4ee6e8a
https://github.com/polrop/CMake/commit/ae24daf591b12d8c23fa481f93a13270c9a0c00f
Note that this branch has been created from next so you better cherry
picked these two patches than merge them back to next.
Cheers,
Nico
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Ninja passes all tests on OS X
On 18.07.2012 11:58, Nicolas Desprès wrote:
On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffmanbill.hoff...@kitware.com wrote:
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to
cmNinjaTargetGenerator which
forwards the call to the Local/Global classes.
Lets just add the friend stuff for now so we can get the dashboard
building again.
You could not add friend class
cmNinjaTargetGenerator::MacOSXContentGeneratorType
because cmNinjaTargetGenerator is forward declared, and including
cmNinjaTargetGenerator.h
doesn't help because it includes cmLocalNinjaGenerator.h again.
Maybe making MacOSXContentGeneratorType global helps.
'
There is also a warning here:
C:/Users/hoffman/Work/My Builds/cmake/Source/cmNinjaTargetGenerator.cxx(60)
: warning C4355: 'this' : used in base member initializer list
Making the helper class global should fix the problem. What about a letter
envelope type of thing. Move the whole MacOSXContentGeneratorType into the
.cxx file. Then forward declare the pointer to it in the
cmNinjaTargetGenerator class.
class cmMacOSXContentGeneratorType;
class cmNinjaTargetGenerator
{
...
cmMacOSXContentGeneratorType* MacOSXContentGenerator;
Then create it with new in the constructor. This would get rid of the above
warning as well. I would like to clean this up before the nightly
dashboards get going so we don't have a bunch of red tomorrow.
Bill,
You can find two patches in the following branch which should fix
these compilation issues. I have tested them with clang and gcc on Mac
OS X.
https://github.com/polrop/CMake/commits/ninja/fix_build
https://github.com/polrop/CMake/commit/5497caf3e0e14430a222e92f190d8d9ea4ee6e8a
https://github.com/polrop/CMake/commit/ae24daf591b12d8c23fa481f93a13270c9a0c00f
Note that this branch has been created from next so you better cherry
picked these two patches than merge them back to next.
Cheers,
Nico
I'm busy on this too. But I've removed the friend by making some functions
public.
Peter
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Ninja passes all tests on OS X
On 18.07.2012 11:58, Nicolas Desprès wrote:
On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffmanbill.hoff...@kitware.com wrote:
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to
cmNinjaTargetGenerator which
forwards the call to the Local/Global classes.
Lets just add the friend stuff for now so we can get the dashboard
building again.
You could not add friend class
cmNinjaTargetGenerator::MacOSXContentGeneratorType
because cmNinjaTargetGenerator is forward declared, and including
cmNinjaTargetGenerator.h
doesn't help because it includes cmLocalNinjaGenerator.h again.
Maybe making MacOSXContentGeneratorType global helps.
'
There is also a warning here:
C:/Users/hoffman/Work/My Builds/cmake/Source/cmNinjaTargetGenerator.cxx(60)
: warning C4355: 'this' : used in base member initializer list
Making the helper class global should fix the problem. What about a letter
envelope type of thing. Move the whole MacOSXContentGeneratorType into the
.cxx file. Then forward declare the pointer to it in the
cmNinjaTargetGenerator class.
class cmMacOSXContentGeneratorType;
class cmNinjaTargetGenerator
{
...
cmMacOSXContentGeneratorType* MacOSXContentGenerator;
Then create it with new in the constructor. This would get rid of the above
warning as well. I would like to clean this up before the nightly
dashboards get going so we don't have a bunch of red tomorrow.
Bill,
You can find two patches in the following branch which should fix
these compilation issues. I have tested them with clang and gcc on Mac
OS X.
https://github.com/polrop/CMake/commits/ninja/fix_build
https://github.com/polrop/CMake/commit/5497caf3e0e14430a222e92f190d8d9ea4ee6e8a
https://github.com/polrop/CMake/commit/ae24daf591b12d8c23fa481f93a13270c9a0c00f
Thanks for the Cannot pass a reference to an anonymous object commit
I already wondered if it will work on all compilers.
Peter
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Ninja passes all tests on OS X
On Wed, Jul 18, 2012 at 12:10 PM, Peter Kümmel syntheti...@gmx.net wrote:
On 18.07.2012 11:58, Nicolas Desprès wrote:
On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffmanbill.hoff...@kitware.com
wrote:
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to
cmNinjaTargetGenerator which
forwards the call to the Local/Global classes.
Lets just add the friend stuff for now so we can get the dashboard
building again.
You could not add friend class
cmNinjaTargetGenerator::MacOSXContentGeneratorType
because cmNinjaTargetGenerator is forward declared, and including
cmNinjaTargetGenerator.h
doesn't help because it includes cmLocalNinjaGenerator.h again.
Maybe making MacOSXContentGeneratorType global helps.
'
There is also a warning here:
C:/Users/hoffman/Work/My
Builds/cmake/Source/cmNinjaTargetGenerator.cxx(60)
: warning C4355: 'this' : used in base member initializer list
Making the helper class global should fix the problem. What about a
letter
envelope type of thing. Move the whole MacOSXContentGeneratorType into
the
.cxx file. Then forward declare the pointer to it in the
cmNinjaTargetGenerator class.
class cmMacOSXContentGeneratorType;
class cmNinjaTargetGenerator
{
...
cmMacOSXContentGeneratorType* MacOSXContentGenerator;
Then create it with new in the constructor. This would get rid of the
above
warning as well. I would like to clean this up before the nightly
dashboards get going so we don't have a bunch of red tomorrow.
Bill,
You can find two patches in the following branch which should fix
these compilation issues. I have tested them with clang and gcc on Mac
OS X.
https://github.com/polrop/CMake/commits/ninja/fix_build
https://github.com/polrop/CMake/commit/5497caf3e0e14430a222e92f190d8d9ea4ee6e8a
https://github.com/polrop/CMake/commit/ae24daf591b12d8c23fa481f93a13270c9a0c00f
Note that this branch has been created from next so you better cherry
picked these two patches than merge them back to next.
Cheers,
Nico
I'm busy on this too. But I've removed the friend by making some functions
public.
Ok. So I let you fix these errors too:
http://open.cdash.org/viewBuildError.php?buildid=2449176
Good luck,
Nico
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0013419]: Path mangled when searchign for lib64 directories
The following issue has been SUBMITTED.
==
http://www.cmake.org/Bug/view.php?id=13419
==
Reported By:Andy Piper
Assigned To:
==
Project:CMake
Issue ID: 13419
Category: CMake
Reproducibility:always
Severity: major
Priority: normal
Status: new
==
Date Submitted: 2012-07-18 10:51 EDT
Last Modified: 2012-07-18 10:51 EDT
==
Summary:Path mangled when searchign for lib64 directories
Description:
When searching for lib64 directories, all elements in the search-path that end
with lib are changed to lib64. This makes it impossible for CMake to find
the libraries.
Steps to Reproduce:
1. Start up a OpenSUSE or SLES machine
2. Create a directory /var/lib/myproject/lib64
2a (optional, if you don't want to be root):
# chown -R youruser:users /var/lib/myproject
...then do the remaining steps as youruser
3. Copy /usr/lib64/libz.so to /var/lib/myproject/lib64/
4. Create the file /var/lib/myproject/CMakeLists.txt with this content:
cmake_minimum_required(VERSION 2.8)
project(lib64bug)
set(CMAKE_FIND_ROOT_PATH ${CMAKE_SOURCE_DIR})
find_library(MYZLIB NAMES libz.so
ONLY_CMAKE_FIND_ROOT_PATH)
if(MYZLIB STREQUAL MYZLIB-NOTFOUND)
message(FATAL_ERROR Did not find zlib under ${CMAKE_SOURCE_DIR})
endif()
message(STATUS Found zlib: ${MYZLIB})
5. Create the directory /var/lib/myproject/build and cd into it
6. Run cmake ..
- The expected CMake output should end with
-- Found zlib: /var/myproject/lib64/libz.so
- The actual CMake output is :
CMake Error at CMakeLists.txt:7 (message):
Did not find zlib under /var/lib/myproject
-- Configuring incomplete, errors occurred!
7. To see the bug in action, run this command (under bash or sh):
strace cmake .. 21 | grep myproject/lib64
...the output will show the path /var/lib/myproject being mangled to
/var/lib64/myproject
Additional Information:
/var/lib/jenkins/workspace is the default workspace-root for Jenkins CI
installations on OpenSUSE (and possibly other Linux distributions). This exposes
all jenkins projects to this bug.
==
Issue History
Date ModifiedUsername FieldChange
==
2012-07-18 10:51 Andy Piper New Issue
==
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] cmake selftest use different compiler and binutils as configured on Darwin
On 7/16/2012 8:07 PM, Richard Wackerbarth wrote: With Ninja I have to look what happens. something goes still wrong. I have a ctest script that pulls and builds ninja before building CMake. You can see it here: http://open.cdash.org/viewNotes.php?buildid=2448273 -Bill -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] cmake 2.8.9 rc2 - OS X Lion
On 17/07/12 11:59 PM, David Cole wrote: On Tue, Jul 17, 2012 at 9:12 AM, Brad King brad.k...@kitware.com wrote: On 07/16/2012 07:10 PM, Nicholas Yue wrote: Hi, I came across this error while bootstrapping a build on OS X Lion. Has anyone else seen this ? /usr/include/c++/4.2.1/cstdarg:60: error: ‘::va_list’ has not been declared In file included from /usr/include/c++/4.2.1/iosfwd:45, from /usr/include/c++/4.2.1/ios:43, from /usr/include/c++/4.2.1/istream:44, from /usr/include/c++/4.2.1/fstream:45, from /Users/nicholas/temp/cmake-2.8.9-rc2/cmake-2.8.9-rc2/Source/cmStandardIncludes.h:84, from /Users/nicholas/temp/cmake-2.8.9-rc2/cmake-2.8.9-rc2/Source/cmStandardIncludes.cxx:12: /usr/include/c++/4.2.1/bits/c++locale.h: In function ‘int std::__convert_from_v(int* const, char*, int, const char*, ...)’: /usr/include/c++/4.2.1/bits/c++locale.h:76: error: ‘va_list’ was not declared in this scope /usr/include/c++/4.2.1/bits/c++locale.h:76: error: expected `;' before ‘__args’ /usr/include/c++/4.2.1/bits/c++locale.h:77: error: ‘__args’ was not declared in this scope make: *** [cmStandardIncludes.o] Error 1 - Error when bootstrapping CMake: Problem while running make - Log of errors: /Users/nicholas/temp/cmake-2.8.9-rc2/cmake-2.8.9-rc2/Bootstrap.cmk/cmake_bootstrap.log - Thanks for reporting back. Does this happen with CMake 2.8.8's sources or is this new in 2.8.9? This happens only with the 2.8.9 sources And please let us know what version of Mac OS X and what version of Xcode/gcc/clang you're using. OS X Lion : version 10.7.4 Xode : version 4.3.2 gcc : i686-apple-darwin11-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.9.00) clang : Apple clang version 3.1 (tags/Apple/clang-318.0.58) (based on LLVM 3.1svn) Let me know if you need additional information or tests I need to run. Regards -- Nicholas Yue Graphics - RenderMan, Visualization, OpenGL, HDF5 Custom Dev - C++ porting, OSX, Linux, Windows Management - Recruitment, career management http://www.proceduralinsight.com/ http://au.linkedin.com/in/nicholasyue -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] cmake 2.8.9 rc2 - OS X Lion
How did you get the 2.8.9 sources? Please use the file cmake-2.8.9-rc2.tar.gz (or cmake-2.8.9-rc2.zip on Windows) -- the -src.tar.bz2 file is only meant for cygwin. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Why not disable the Unix Makefiles generator for Darwin?
I am happy to see it works now and Ninja is eanabled and Mac Thanks to all Claus CMakeLists.txt Revision: 52160bf68f2d3b948efda5a7a64642e7e0969d9e by Peter Kümmel Ninja: enable ninja on Mac so all Mac CDash-builds are tested, cleanup later On 14.07.2012, at 19:40, Nicolas Desprès wrote: I am almost ready to push a branch fixing all the failing tests on Darwin with Ninja. So it is coming soon. Cheers, Nico -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
