[cmake-developers] Expression unit test
A unit tests for expressions is broken for ninja: http://open.cdash.org/testDetails.php?test=161505814build=2596684 ninja prints the wrong parameter as it is used in the cmake file, include_directories($TARGET_PROPERTY:Invali/dTarget,INCLUDE_DIRECTORIES) but the test wants the $ escaped one: Expected stderr to match: expect-err \$TARGET_PROPERTY:Invali/dTarget,INCLUDE_DIRECTORIES Actual stderr: actual-err $TARGET_PROPERTY:Invali/dTarget,INCLUDE_DIRECTORIES Is this a bug in the test (and the other generators) or in the ninja generator? Peter -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0013573]: RPATH not supported when cross compiling for FreeBSD
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=13573 == Reported By:muhkuh Assigned To: == Project:CMake Issue ID: 13573 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2012-10-05 10:01 EDT Last Modified: 2012-10-05 10:01 EDT == Summary:RPATH not supported when cross compiling for FreeBSD Description: We have a MinGW hosted gcc cross compiler for windows that that targets FreeBSD. The created makefiles for MinGW make don't add any -rpath options to the linker command line. Steps to Reproduce: I don't really know how how to provide a test case. The cross compiler is pretty large as it needs a lot of system libraries and headers to function properly. I can provide it if neccessary. Additional Information: I think the reason for this is in: CMAKE_ROOT/share/cmake-2.8/Modules/Platform/FreeBSD.cmake. If I comment out the checks for existence of a file /usr/include/dlfcn.h everything starts working. Unfortunately I don't know the proper way to deal with this in a way that it still checks what it is supposed to check in a cross compiling environment. == Issue History Date ModifiedUsername FieldChange == 2012-10-05 10:01 muhkuh New Issue == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] I: I want to become a maintainer of several modules.
On 10/05/2012 08:29 AM, Aleksey Avdeev wrote:
I modified the proposed modules.
Thanks for working on them. Let's start with FindIcotool since it
is pretty simple and doesn't depend on the other modules. After
that we can move on to the others. Please proceed with step 5
of the new maintainer instructions:
http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer
to get Git access.
1. FindIcotool
http://git.altlinux.org/people/solo/public/cmake-modules.git?p=cmake-modules.git;a=blob;f=Modules/FindIcotool.cmake;h=97543113756a72e59175c778eace0dc00220a1e0;hb=ea809d0c5b1cd36b83437043d916fd6eacc1dc5f
Good. Please tweak the documentation:
(1) Remove the leading/first # line that is otherwise empty.
(2) Remove the (since CMake 2.8.8) note since the module was
not in CMake 2.8.8.
Also when the module is put in CMake the line
include(FindPackageHandleStandardArgs)
will need to be
include(${CMAKE_CURRENT_LIST_DIR}/FindPackageHandleStandardArgs.cmake)
Done. Value ICOTOOL_VERSION_STRING up over the output:
icotool --version
The output parsing can be a bit simpler if you use the CMAKE_MATCH_1
variable result from the if(... MATCHES ...) command. It is
mentioned at the bottom of the regex documentation in string():
http://www.cmake.org/cmake/help/v2.8.9/cmake.html#command:string
Thanks,
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] patch for cmake that adds a new timestamp command
My initial thought was that NOTFOUND would be a good idea since it evaluates to false and the get_*_property commands also seem to use it. Looking at the documentation for if() again only -NOTFOUND as a suffix should evaluate to false though (I assume the documentation is incomplete here?). On second though relying on timestamps to evaluate to false on failure is probably a bad idea since I could have a format string of e.g. %w (day of the week) which might produce a valid timestamp 0 which would also evaluate to false. Nils On 10/05/2012 07:34 PM, Brad King wrote: On 09/29/2012 05:47 AM, Nils Gladitz wrote: I've updated the patch (attached) to include a TIMESTAMP sub-command for file as well (I hope indentation is also fixed). Thanks. Use of std::time_t and std::tm will not compile on all of CMake's platforms. Other code already uses #include time.h, time_t, and struct tm. Also, IMO the result in the case of failure should be the empty string rather than NOTFOUND. The latter is a convention in the find_* commands that should never have been used elsewhere. Thanks, -Brad -- Nils Gladitz, B.Sc. DICOM, Konnektivität und Entwicklung Scivis wissenschaftliche Bildverarbeitung GmbH Bertha-von-Suttner-Str. 5 D-37085 Göttingen GERMANY Handelsregister Nr. / Trade Register No. B3100 Göttingen Geschäftsführer / Managing Directors Dr. Gernot Ebel, Dr. Uwe Engeland Tel: 0049 (0)551 634181-28 E-Mail: glad...@scivis.de Web: www.scivis.de -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] patch for cmake that adds a new timestamp command
On 10/05/2012 02:53 PM, Nils Gladitz wrote: My initial thought was that NOTFOUND would be a good idea since it evaluates to false and the get_*_property commands also seem to use it. I wrote the more general get_property command to replace those and the newer command uses empty string rather than NOTFOUND. It is more useful when computing pieces of a string to put together, perhaps when appending to a property value. Looking at the documentation for if() again only -NOTFOUND as a suffix should evaluate to false though (I assume the documentation is incomplete here?). Yes, thanks for pointing it out. Fixed: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f63304d9 On second though relying on timestamps to evaluate to false on failure is probably a bad idea since I could have a format string of e.g. %w (day of the week) which might produce a valid timestamp 0 which would also evaluate to false. Yes, so a comparison against would be more reliable. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0013574]: Ninja: no transitive dependency for imported libraries
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=13574 == Reported By:Peter Kuemmel Assigned To:Peter Kuemmel == Project:CMake Issue ID: 13574 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: assigned == Date Submitted: 2012-10-05 15:41 EDT Last Modified: 2012-10-05 15:41 EDT == Summary:Ninja: no transitive dependency for imported libraries Description: ExternalProject_Add(x ) add_library(xLib STATIC IMPORTED GLOBAL) set_target_properties(xLib PROPERTIES IMPORTED_LOCATION libx.a) add_dependencies(xLib x) target_link_library(y x) This is broken for ninja. Ninja starts building y and stops because three is no rule for libx.a. == Issue History Date ModifiedUsername FieldChange == 2012-10-05 15:41 Peter Kuemmel New Issue 2012-10-05 15:41 Peter Kuemmel Status new = assigned 2012-10-05 15:41 Peter Kuemmel Assigned To = Peter Kuemmel == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0013575]: No print messages after PROJECT(name)
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=13575 == Reported By:Krzysiek Assigned To: == Project:CMake Issue ID: 13575 Category: CMake Reproducibility:always Severity: text Priority: normal Status: new == Date Submitted: 2012-10-05 17:13 EDT Last Modified: 2012-10-05 17:13 EDT == Summary:No print messages after PROJECT(name) Description: Hi, In file in main project CMakeLists.txt after line PROJECT(name) the message is not printing. Of course before line PROJECT() messages works. == Issue History Date ModifiedUsername FieldChange == 2012-10-05 17:13 Krzysiek New Issue == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
