Re: [cmake-developers] A CMAKE_EMULATOR variable

2015-04-05 Thread Matt McCormick 
 In each place that you ExpandListArgument to get the emulator
 command and arguments and write them out before an executable
 name, you need to be sure to make the proper call to escape
 each argument.  In each case the code just below your hunk
 does this for the test arguments.

Good catch.  Fixed.


 The Tests/RunCMake/pseudo_emulator.cxx tool must be able to
 compile with any of the compilers we test, not just those that
 host the build of CMake.  It will be more portable to use a
 .c file with stdio.h and printf.  Also, please make it print
 out each argument in quotes so one could match expected output
 in the future.

Done. If I recall correctly, there are not other tests that try to
verify try_run output, so I did not open that can of worms.


 +RunCMake_TEST:STRING=AddTest

 Why is this needed in InitialCache.cmake?

Seems like leftover cruft.  Removed.


Thanks for the review. The new branch has been force pushed to the
stage as emulator-property.

Thanks,
Matt
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] [CMake 0015497]: Eclipse CDT4 Generator incorrectly process CMAKE_MAKE_PROGRAM with arguments

2015-04-05 Thread Mantis Bug Tracker 

The following issue has been SUBMITTED. 
== 
http://www.cmake.org/Bug/view.php?id=15497 
== 
Reported By:Hendy Irawan
Assigned To:
== 
Project:CMake
Issue ID:   15497
Category:   CMake
Reproducibility:always
Severity:   minor
Priority:   normal
Status: new
== 
Date Submitted: 2015-04-06 00:05 EDT
Last Modified:  2015-04-06 00:05 EDT
== 
Summary:Eclipse CDT4 Generator incorrectly process
CMAKE_MAKE_PROGRAM with arguments
Description: 
Eclipse requires separate build command and build arguments settings.

Steps to Reproduce: 
CMakeLists.txt:

set(CMAKE_MAKE_COMMAND ${CMAKE_MAKE_PROGRAM} -j8)

Generated files - INCORRECT

.project:

dictionary

keyorg.eclipse.cdt.make.core.build.command/key
value/usr/bin/make -j8/value
/dictionary

.cproject:

storageModule 
moduleId=org.eclipse.cdt.make.core.buildtargets
buildTargets
target name=: rebuild_cache path=
targetID=org.eclipse.cdt.make.MakeTargetBuilder
buildCommand/usr/bin/make 
-j8/buildCommand
buildArguments/

buildTargetrebuild_cache/buildTarget
stopOnErrortrue/stopOnError

useDefaultCommandfalse/useDefaultCommand
/target
target name=[exe] vpercnode path=
targetID=org.eclipse.cdt.make.MakeTargetBuilder
buildCommand/usr/bin/make 
-j8/buildCommand
buildArguments/

buildTargetvpercnode/buildTarget
stopOnErrortrue/stopOnError

useDefaultCommandfalse/useDefaultCommand
/target
target name=[exe] vpercnode/fast 
path=
targetID=org.eclipse.cdt.make.MakeTargetBuilder
buildCommand/usr/bin/make 
-j8/buildCommand
buildArguments/

buildTargetvpercnode/fast/buildTarget
stopOnErrortrue/stopOnError

useDefaultCommandfalse/useDefaultCommand
/target
target name=Build 
path=[Targets]/[exe] vpercnode
targetID=org.eclipse.cdt.make.MakeTargetBuilder
buildCommand/usr/bin/make 
-j8/buildCommand
buildArguments-C 
/home/ceefour/git/vpercnode /buildArguments

buildTargetvpercnode/buildTarget
stopOnErrortrue/stopOnError

useDefaultCommandfalse/useDefaultCommand
/target
target name=Clean 
path=[Targets]/[exe] vpercnode
targetID=org.eclipse.cdt.make.MakeTargetBuilder

buildCommand/usr/bin/cmake/buildCommand
buildArguments-E chdir 
/home/ceefour/git/vpercnode /usr/bin/cmake -P
CMakeFiles/vpercnode.dir/cmake_clean.cmake/buildArguments
buildTarget/
stopOnErrortrue/stopOnError

useDefaultCommandfalse/useDefaultCommand
/target
target name=: all path=
targetID=org.eclipse.cdt.make.MakeTargetBuilder
buildCommand/usr/bin/make 
-j8/buildCommand
buildArguments/
buildTargetall/buildTarget