Re: [cmake-developers] Listing source-tree files encountered
On 07/21/2015 12:33 PM, Brad King wrote: I'll take a look at this when I get a chance. Applied, thanks: Add SOURCE_DIR and BINARY_DIR target properties http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=45c5f8ca There is some coverage of the SOURCES property in other tests but having a dedicated check for it would be worthwhile too. This can be provided in a follow-up patch. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patch for FindBZip2.cmake BZIP2_NEED_PREFIX issue with cross compiled mingw32 applications
On 07/21/2015 12:10 PM, Ralf Habacker wrote: updated patch appended Applied, thanks: FindBZip2: Check BZIP2_NEED_PREFIX with real prototype http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=23876eda -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Is this warning really needed: You have called ADD_LIBRARY for library foobar without any source files.?
On 07/22/2015 08:25 AM, Erik Sjölund wrote:
I think this warning could be removed: You have called ADD_LIBRARY
for library foobar without any source files. This typically indicates
a problem with your CMakeLists.txt file
Yes, since we started allowing sources to be modified after the call
this warning no longer makes sense. Instead we need to make sure there
is a proper diagnostic if at generate time no SOURCES are available.
Even if that is already the case we also need to make sure the test
suite covers the errors in Tests/RunCMake somewhere, perhaps in new
Tests/RunCMake/{add_library,add_executable} cases.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [CMake] CTest threshold exceeds 1024 bytes
On 07/21/2015 06:16 PM, Roman Wüger wrote: I've attached a patch which learns CTest to handle it. I hope this patch could be merged. Good start. Please also update Help/manual/ctest.1.rst with documentation for the new options. Also please extend the test suite, likely in Tests/RunCMake/CTestCommandLine, to cover the options. See Tests/RunCMake/README.rst for information about how the existing test works. You could perhaps add a case that uses a -check.cmake script to verify the length of the output in a Test.xml file after running ctest -M Experimental -T Test plus the new options. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0015659]: Visual Studio 2015: check_function_exists doesn't work for stdio functions
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15659 == Reported By:Alex Lamaison Assigned To: == Project:CMake Issue ID: 15659 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2015-07-22 17:34 EDT Last Modified: 2015-07-22 17:34 EDT == Summary:Visual Studio 2015: check_function_exists doesn't work for stdio functions Description: check_function_exists worked with previous versions of VS and correctly detected the absence of presence of stdio functions like the printf/scanf families, but with VS2015, those functions are always 'not found' With Visual Studio 2015, those functions are now defined *inline* in stdio.h. This means that CheckFunctionExists.c, which doesn't included stdio.h, can't find any definition of the function to link with. Previously this would have linked with the symbol in the CRT. Steps to Reproduce: Add check_function_exists(snprintf) to a project. Configure with VS2015 generator. It should say 'Looking for snprintf - found'. Instead it says 'Looking for snprintf - not found'. Additional Information: A workaround is to add legacy_stdio_definitions.lib to CMAKE_REQUIRED_LIBRARIES. However, that is not ideal because it requires knowing that library is available and required in the first place. That defeats the object of feature detection. More info here: https://msdn.microsoft.com/en-us/library/bb531344.aspx == Issue History Date ModifiedUsername FieldChange == 2015-07-22 17:34 Alex Lamaison New Issue == -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Is this warning really needed: You have called ADD_LIBRARY for library foobar without any source files.?
Hi,
I think this warning could be removed: You have called ADD_LIBRARY
for library foobar without any source files. This typically indicates
a problem with your CMakeLists.txt file
If you have a function that populates sources to a target, let us say
something like this:
function(activate_feature target_name)
target_sources(${target_name} PRIVATE feature.cc)
endfunction()
you would like to be able to do
add_library(foobar SHARED)
activate_feature(foobar)
without any CMake warning.
I've started using that design scheme more and more. That is, to have
a function setting up a target where the target name is given as an
input parameter. The nice thing about it is that I can pass both an
executable target and a shared library target as input to such a
function.
cheers,
Erik Sjölund
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
