Re: [cmake-developers] Patch: Remove superfluous semicolon after method

2016-02-01 Thread Brad King
On 01/29/2016 05:43 PM, Christoph Grüninger wrote:
> please find attached a minimal patch to fix a GCC 6 pedantic warning
> concerning a superfluous semicolon after a method.

Applied, thanks:

 cmAlgorithms.h: remove superfluous semicolon after method
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ccb2d5c0

> Additional I got the following warning:
>> CMake/Source/cmGeneratorTarget.cxx:4835:52: warning: format ‘%u’ expects
>> argument of type ‘unsigned int*’, but argument 3 has type ‘int*’ [-Wformat=]
>>sscanf(config_reps, "%u", &iface.Multiplicity);
> 
> Same on 4840:45, 5543:51, 5548:44 in the same file. It is not obvious to
> me whether you want to change the types in cmOptionalLinkInterface,
> change the type in sscanf or cast the types.

There is no reason to have negative values for that, so please update
both cmLinkInterface::Multiplicity and cmGeneratorTarget::Multiplicity
to use `unsigned int` and follow through with any further changes
needed for that (I don't think there are any but have not checked).

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] install(EXCLUDE_FROM_ALL) new feature - request for comment

2016-02-01 Thread Nick Lewis
There is currently no way to exclude a component install() from a full
installation. Current workarounds using OPTIONAL do not work reliably
because they depend on previous builds and on the order of the execution of
the
build and install commands for the components and the default target

Let us take an example of a project that has some tests in a component that
need to be installed into a dedicated test package. The user expectation is
that the result could be achieved by typing the following:

 make
 make tests
 make install
 DESTDIR=/testpkgs make install-tests

However this results in test components in the default installation as well
as the testpkg

Judging by questions on the mail list, users typically try to overcome this
problem by adding the EXCLUDE_FROM_ALL keyword to the install() command but
this is currently unsupported. The patch uploaded to the issue tracker
provides support for it.

Brad has further suggested that the install(EXCLUDE_FROM_ALL) should be
implicitly set when installing components built with
add_executable/library(EXCLUDE_FROM_ALL)

I welcome your views on these ideas

https://cmake.org/Bug/view.php?id=14921

Best Regards
Nick

-- 
Nick Lewis
nick.le...@amag.com
+44 1684 277137 <+441684277137>
www.amag.com
AMAG Technology, Challenge House, International Drive, Tewkesbury Business
Park, TEWKESBURY, GL20 8UQ, U.K.

-- 



This company is part of the G4S group of companies. This communication 
contains information which may be confidential, personal and/or privileged. 
It is for the exclusive use of the intended recipient(s). If you are not 
the intended recipient(s), please note that any distribution, forwarding, 
copying or use of this communication or the information in it is strictly 
prohibited. Any personal views expressed in this e-mail are those of the 
individual sender and the Company does not endorse or accept responsibility 
for them. Prior to taking any action based upon this e-mail message, you 
should seek appropriate confirmation of its authenticity. This message has 
been checked for viruses on behalf of the Company.
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Is there a way to disable soname versioning?

2016-02-01 Thread Nils Gladitz

On 01.02.2016 00:09, Eric Wing wrote:

This has been an ongoing nuisance for me, so I thought I would finally
ask. Is there a way I can force soname versioning without modifying
everybody's CMake build scripts?

The main problem is Android. Using soname versioning on Android will
basically cause things to break at runtime. It would be nice if the
CMake commands that set the version would be ignored in the Android
case. (I know Android is not officially supported by CMake and
cross-compile toolchains are being used, but if I knew how to put this
in the toolchain, that would be a big help.)


The "Android" platform file included with CMake contains:
set(CMAKE_PLATFORM_NO_VERSIONED_SONAME 1)

Which should do just that.

All you should have to do for this to take effect is have:
set(CMAKE_SYSTEM_NAME Android)

In your toolchain file (instead of what ever you've got it set to now).

Nils
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers