Re: [cmake-developers] CMake API for warnings

2016-04-25 Thread Brad King
On 04/23/2016 12:11 AM, Ruslan Baratov wrote:
> It means ignoring directory properties. So by default we will inherit 
> settings.
[snip]
> To disable inheriting we need to add extra argument (?) to *_compile_warnings:
> 
>  add_compile_warnings(DISABLE warn-A)
>  target_compile_warnings(foo DISABLE warn-B IGNORE DIRECTORY)

We don't have such a feature for any of the other build settings so
there is no precedent for how to represent this or its exact semantics.

We may not need the capability at all.  For other properties like
COMPILE_OPTIONS and INCLUDE_DIRECTORIES the target-level property
is initialized from the directory-level property when the target
is created.  After that the directory-level property has no meaning
to the target.  One may then set the target-level property to
erase any content previously taken from the directory-level
property.  This allows specific targets to ignore the directory-level
property in special cases.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] 0016046: GHS Multi Generator: duplicate object file names

2016-04-25 Thread Brad King
On 04/24/2016 03:57 PM, Geoffrey Viola wrote:
> Attached is a patch that handles duplicate filenames by prepending
> collided filepaths with the absolute paths.

Applied, thanks.

> There's also a test that should work with the other generators.

I renamed it to be GhsMulti-specific since it is only added for
that generator right now.  I'm pretty sure the case is covered
elsewhere in the test suite for other generators.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] Autogen message cleanups

2016-04-25 Thread Brad King
On 04/24/2016 09:55 AM, Sebastian Holtermann wrote:
> Two more autogen patches with message cleanups/tweaks.

Thanks!  Applied:

 Autogen: Message cleanups: Compose messages in std::stringstream
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9b58190c

 Autogen: Message tweaks: Compiler type (moc/qrc/ui) added to progress messages
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9647af3f

I ran `s/msg/err/g` on the hunks of the first patch in order to
avoid shadowing other `msg` locals in a few places.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers