Re: [cmake-developers] Some CPackRPM Debug print is printing without DEBUG On

[Domen Vrankar]

> Doh. Less haste more speed. Thanks. Patch 2.

Pushed to next:
https://cmake.org/gitweb?p=cmake.git;a=commit;h=49df5d480045ea77295825f2968ec57c4146b5d8

Thanks,
Domen
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] CpackRPM doesn't escape filenames

[Brad King]

On 07/11/2016 11:32 AM, Harry Mallon wrote:
> When using CPackRPM my filenames in auto generated RPM SPEC
> look like "/usr/share/foo/bar10%.xml" when the "%" symbol
> (which is in the filename should be escaped to "%%".

Thanks.  Please open an issue here:

 https://gitlab.kitware.com/cmake/cmake/issues

Ideally please include a http://sscce.org/ showing how to
reproduce the problem.  Then perhaps it can be adapted as
a test case.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] cmake -E capabilities

[Tobias Hunger]

Hello Developers,

https://github.com/hunger/CMake/commits/cmake-capabilities

is in a state now that could use another review.

It addresses all the issues that Stephen brought up, with small patches
extending the information reported via GeneratorInfo bit by bit. Only
when all that is in place, the new cmake -E capabilities is added.

This now creates extra generators (all of them), which does not seem to effect
run time of cmake -E capabilities by much on Linux. I have not tested this on
Windows/Mac though as I do not have those platforms handy.

If that is not acceptable, then some string-parsing is going to be necessary.
I'd move that into cmake::GetRegisteredGenerators, where it is more of an
implementation detail than in the code that actually handles the capability
reporting.

Best Regards,
Tobias

-- Tobias Hunger, Senior Software Engineer | The Qt Company
The Qt Company GmbH, Rudower Chaussee 13, D-12489 Berlin
Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho. Sitz der
Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Don't enclose CMake version to generated files

[Alan W. Irwin]

On 2016-07-11 17:17+0200 Christoph Grüninger wrote:


Hi Ben,
this comes from the open build system, which is the system used by
openSuse to generate the packages. If the CMake version is updated,
which happens quite often, the generated files are altered and the
packages are rebuild, repackaged and republished.
Without the version number in the generated files, it wouldn't
happen.


Hi Christoph:

For the use case you describe, shouldn't that rebuild happen to maintain
consistency between the openSuse version of CMake and all the openSuse
packages that are built with CMake? CMake does have a large degree of
backwards compatibility, but it is not perfect so I think the version
does matter.

Another way of saying this is you might want to consider CMake to be
part of the tool chain (like gcc is) where any version difference is
presumably considered to be quite significant and therefore worth a
rebuild of binary packages.  I don't know what openSuse policy is for
gcc version changes, but presumably such changes are heavily
controlled to reduce rebuilds, and openSuse has the option of
following that heavy control of version change policy for CMake
instead of doing what I consider to be a workaround which is patching
CMake to remove version information from the generated results.

Alan
__
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__

Linux-powered Science
__
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Don't enclose CMake version to generated files

[Christoph Grüninger]

Hi Brad, hi Ben,

> I've applied the "export" parts of the patch:
> 
>  Do not place CMake version in export files
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c376c5bc

Hu, that was fast. Thank you. I wanted to discuss whether openSuse
or CMake should change. I'll apply the patch to our package and
check whether everybody is satisfied.

Bye
Christoph
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Don't enclose CMake version to generated files

[Brad King]

On 07/11/2016 11:17 AM, Christoph Grüninger wrote:
> this comes from the open build system, which is the system used by
> openSuse to generate the packages. If the CMake version is updated,
> which happens quite often, the generated files are altered and the
> packages are rebuild, repackaged and republished.
> Without the version number in the generated files, it wouldn't
> happen.

I think dropping the version number from the various Export generators
should be sufficient for this.  The generated build system files like
build.ninja should not affect the results of package installation.

I've applied the "export" parts of the patch:

 Do not place CMake version in export files
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c376c5bc

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Don't enclose CMake version to generated files

[Ben Boeckel]

On Mon, Jul 11, 2016 at 17:16:22 +0200, Christoph Grüninger wrote:
> this comes from the open build system, which is the system used by
> openSuse to generate the packages. If the CMake version is updated,
> which happens quite often, the generated files are altered and the
> packages are rebuild, repackaged and republished.
> Without the version number in the generated files, it wouldn't
> happen.

Why do the generated makefiles and ninja files cause this problem? Are
they packaged too? I grant that the export header one makes sense, but
the others not as much (and certainly not the Qt IFW file since I would
be surprised to see a Linux distro using it).

In any case, such information would be nice to have in the commit
message.

Thanks,

--Ben
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Don't enclose CMake version to generated files

[Christoph Grüninger]

Hi Ben,
this comes from the open build system, which is the system used by
openSuse to generate the packages. If the CMake version is updated,
which happens quite often, the generated files are altered and the
packages are rebuild, repackaged and republished.
Without the version number in the generated files, it wouldn't
happen.

Bye
Christoph
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Don't enclose CMake version to generated files

[Ben Boeckel]

On Sun, Jul 10, 2016 at 15:35:24 +0200, Christoph Grüninger wrote:
> I just updated openSuse's CMake package. We have a patch, that removes
> the CMake version from generated files. This is aiming to reduce the
> re-publishing of generated files. Please find the current patch attached.
> What do you think, can we get this somehow upstreamed? Or are you
> opposed to the general idea and keep the CMake version in the files?

Thanks!

> Enclosing the cmake version will cause a republish of generated files

What do you mean by "republish"? Do you mean "cause a rebuild"? The
files generated by CMake should, generally, not be put into source
control. If you mean "rebuild", only the header generation code needs to
really not put the version into the file. The version in generated
build.ninja, Makefiles, and CPack-related files shouldn't be a problem.

--Ben
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Some CPackRPM Debug print is printing without DEBUG On

[Harry Mallon]

Doh. Less haste more speed. Thanks. Patch 2.

H


Harry Mallon
CODEX | Software Engineer
60 Poland Street | London | England | W1F 7NT
E ha...@codexdigital.com | T +44 203 7000 989


0001-Make-sure-CPackRPM-Debug-print-about-Auto-Filelist-o.patch
Description: 0001-Make-sure-CPackRPM-Debug-print-about-Auto-Filelist-o.patch


> On 11 Jul 2016, at 13:13, Domen Vrankar  wrote:
> 
> 2016-07-11 13:50 GMT+02:00 Harry Mallon :
>> I get this line printed a lot even without CPACK_RPM_PACKAGE_DEBUG turned on.
>> 
>> "CPackRPM:Debug: Adding 
>> /usr/lib/systemd;/usr/lib/systemd/system;/usr/lib/systemd/system-preset;/usr/lib/udev;/usr/lib/udev/rules.d;/usr/etc;/etc/security;/etc/security/limits.d
>>  to builtin omit list."
>> 
>> Patch attached
> 
> Provided patchi disables both debug message as well as
> CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST functionality. That if statement
> should not be changed and instead a new if statement wrapping only
> message should be added.
> 
> Regards,
> Domen
> 

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Some CPackRPM Debug print is printing without DEBUG On

[Domen Vrankar]

2016-07-11 13:50 GMT+02:00 Harry Mallon :
> I get this line printed a lot even without CPACK_RPM_PACKAGE_DEBUG turned on.
>
> "CPackRPM:Debug: Adding 
> /usr/lib/systemd;/usr/lib/systemd/system;/usr/lib/systemd/system-preset;/usr/lib/udev;/usr/lib/udev/rules.d;/usr/etc;/etc/security;/etc/security/limits.d
>  to builtin omit list."
>
> Patch attached

Provided patchi disables both debug message as well as
CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST functionality. That if statement
should not be changed and instead a new if statement wrapping only
message should be added.

Regards,
Domen
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] Some CPackRPM Debug print is printing without DEBUG On

[Harry Mallon]

I get this line printed a lot even without CPACK_RPM_PACKAGE_DEBUG turned on.

"CPackRPM:Debug: Adding 
/usr/lib/systemd;/usr/lib/systemd/system;/usr/lib/systemd/system-preset;/usr/lib/udev;/usr/lib/udev/rules.d;/usr/etc;/etc/security;/etc/security/limits.d
 to builtin omit list."

Patch attached

Harry


Harry Mallon
CODEX | Software Engineer
60 Poland Street | London | England | W1F 7NT
E ha...@codexdigital.com | T +44 203 7000 989


0001-Make-sure-CPackRPM-Debug-print-about-Auto-Filelist-o.patch
Description: 0001-Make-sure-CPackRPM-Debug-print-about-Auto-Filelist-o.patch
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers