Re: [cmake-developers] Cannot control the name of dependfile set in Ninja generator

2018-01-27 Thread Claus Klein
Hi Chris,

done, but:
commit 4f48fef4 

 is not allowed because the following files are not formatted according to the 
'clang-format-3.8' check: Source/cmNinjaTargetGenerator.cxx. Post a comment 
ending in the line Do: reformat to rewrite the MR source branch automatically.

I have no clang-format?

Only xcode installed.

Claus

> Am 27.01.2018 um 22:23 schrieb Christian Pfeiffer :
> 
> That GitHub repository is a read-only mirror of the GitLab, where all the 
> work takes place:https://gitlab.kitware.com/cmake/cmake 
>  . Please 
> seehttps://gitlab.kitware.com/cmake/cmake/blob/master/CONTRIBUTING.rst 
>  on how 
> to submit merge requests.
>  
> Chris

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
https://cmake.org/mailman/listinfo/cmake-developers


Re: [cmake-developers] Cannot control the name of dependfile set in Ninja generator

2018-01-27 Thread Christian Pfeiffer
Hi Claus,

That GitHub repository is a read-only mirror of the GitLab, where all the work 
takes place: https://gitlab.kitware.com/cmake/cmake . Please see 
https://gitlab.kitware.com/cmake/cmake/blob/master/CONTRIBUTING.rst on how to 
submit merge requests.

Chris

From: Claus Klein
Sent: Saturday, January 27, 2018 10:08 PM
To: Brad King
Cc: cmake-developers@cmake.org
Subject: Re: [cmake-developers] Cannot control the name of dependfile set in 
Ninja generator

Hi Brad,

I have prepared a patch which works vor cpp files fine.

But I have no idea why not for c files?

see https://github.com/Kitware/CMake/pull/318

Claus

> Am 19.01.2018 um 15:07 schrieb Brad King :
>
> * Extend the Ninja generator with settings to tell it about the above
>  names.

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
https://cmake.org/mailman/listinfo/cmake-developers

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
https://cmake.org/mailman/listinfo/cmake-developers


Re: [cmake-developers] Cannot control the name of dependfile set in Ninja generator

2018-01-27 Thread Claus Klein
Hi Brad,

I have prepared a patch which works vor cpp files fine.

But I have no idea why not for c files?

see https://github.com/Kitware/CMake/pull/318

Claus

> Am 19.01.2018 um 15:07 schrieb Brad King :
> 
> * Extend the Ninja generator with settings to tell it about the above
>  names.

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
https://cmake.org/mailman/listinfo/cmake-developers