Re: [cmake-developers] [CMake] ADD_DEPENDENCIES() and NonExisitngDependent is NOT an error?
Hi David, I have prepared a new patch for master which works fine now. claus-kleins-macbook-pro:CmakeBuildDir clausklein$ bin/cmake --help- policy CMP0019 cmake version 2.8.8.20120628-g01d97-dirty CMP0019 add_dependencies(target-name depend-target1 depend-target2 ...) Dependent targets must all exist. In CMake 2.8.10 and above this policy determines whether or not the case is an error. The OLD behavior for this policy is to silently ignore the problem. The NEW behavior for this policy is to report an error. This policy was introduced in CMake version 2.8.10. CMake version 2.8.8.20120628-g01d97-dirty warns when the policy is not set and uses OLD behavior. Use the cmake_policy command to set it to OLD or NEW explicitly. Claus prepareCheckForDependingTargetThatDoesNotExistNowButWillBeAddedLater.patch Description: Binary data On 27.07.2012, at 20:59, David Cole wrote: I will have no problem getting it into CMake 'master' immediately after the 2.8.9 release is final. P.S. for which date is the release planed? -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [CMake] ADD_DEPENDENCIES() and NonExisitngDependent is NOT an error?
Sorry I don't have the bandwidth to chime in on this very much, but just so you don't waste any more of your time on this (unless you're really passionate about it and would do it anyhow...): I'm not going to rush a change like this into CMake just before the 2.8.9 release. The best possible scenario here is for a change like this to go into 'master' right after the 2.8.9 release and be ready for when 2.8.10 rolls around. This "bug" has been around for a mighty long time, and once you know about it, you just "don't do that" anymore. Having said that, we're not going to put in a semi-fix for this one "for now" and then fix it up more later: we'll spend the effort and time on it to get it right the first time, or we'll just leave well enough alone. Thanks, David On Fri, Jul 27, 2012 at 2:02 PM, Claus Klein wrote: > Third try ... > > I have a Problem to really break the generation if the target does not > exist: > > claus-kleins-macbook-pro:build clausklein$ > /Users/clausklein/Downloads/CmakeBuildDir/bin/cmake -G Ninja .. > -- Configuring done > CMake Error: > Policy CMP0019 is not set: add_dependencies() Dependent targets must all > exist. Run "cmake --help-policy CMP0019" for policy details. Use the > cmake_policy command to set the policy and suppress this warning. > ftpcpp: Adding dependency to non-existent target: > target_that_does_not_exist_now_but_will_be_added_later > > -- Generating done > -- Build files have been written to: > /Users/clausklein/Workspace/cpp/ftplibpp-2.0.2/build > claus-kleins-macbook-pro:build clausklein$ > > > Can anyone please help? > > Thanks in advance > Best Regards > Claus > > On 27.07.2012, at 12:24, Claus Klein wrote: > > new patch with policy handling uploaded. > http://public.kitware.com/Bug/view.php?id=9188 > > Not sure if all is right, but as a basis for integration... > > > > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [CMake] ADD_DEPENDENCIES() and NonExisitngDependent is NOT an error?
Third try ... I have a Problem to really break the generation if the target does not exist: claus-kleins-macbook-pro:build clausklein$ /Users/clausklein/Downloads/ CmakeBuildDir/bin/cmake -G Ninja .. -- Configuring done CMake Error: Policy CMP0019 is not set: add_dependencies() Dependent targets must all exist. Run "cmake --help-policy CMP0019" for policy details. Use the cmake_policy command to set the policy and suppress this warning. ftpcpp: Adding dependency to non-existent target: target_that_does_not_exist_now_but_will_be_added_later -- Generating done -- Build files have been written to: /Users/clausklein/Workspace/cpp/ ftplibpp-2.0.2/build claus-kleins-macbook-pro:build clausklein$ Can anyone please help? Thanks in advance Best Regards Claus On 27.07.2012, at 12:24, Claus Klein wrote: new patch with policy handling uploaded. http://public.kitware.com/Bug/view.php?id=9188 Not sure if all is right, but as a basis for integration... -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [CMake] ADD_DEPENDENCIES() and NonExisitngDependent is NOT an error?
Update, new patch with policy handling uploaded. http://public.kitware.com/Bug/view.php?id=9188 Not sure if all is right, but as a basis for integration... Claus On 26.07.2012, at 23:25, Claus Klein wrote: Thanks David, here is my patch, I have tested it today which "ninja Experimental" -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [CMake] ADD_DEPENDENCIES() and NonExisitngDependent is NOT an error?
Thanks David,here is my patch, I have tested it today which "ninja Experimental"There should be a test too ...It would be nice if it could fixed before next release.Claus checkForExistingDependencyTarget.patch Description: Binary data On 26.07.2012, at 18:18, David Cole wrote:The gory details are here: http://public.kitware.com/Bug/view.php?id=9188It's well known, and in the backlog, but nobody is currently activelyworking on fixing it to the best of my knowledge.Sorry,David-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
