Re: [cmake-developers] [CMake] Problem with CMake 3.3.0-rc3

2015-07-13 Thread Clifford Yapp
On Sat, Jul 11, 2015 at 5:07 AM, Stephen Kelly  wrote:
> Brad King wrote:
>
>> Steve, please take a look.  It looks like the cmState methods
>> RemoveUserDefinedCommands and RenameCommand need to work better
>> together.  This needs to be fixed for 3.3.
>
> Fixed with
>
>  http://www.cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f2ee169d
>  cmState: Restore renamed commands on cleanup

Confirmed in rc4 - thanks!

CY
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] [CMake] Problem with CMake 3.3.0-rc3

2015-07-09 Thread Brad King
On 07/09/2015 01:43 PM, Clifford Yapp wrote:
> OK, more info - it looks like the problem is limited to the CMake GUI
> configure (although I haven't been able to test ccmake, the basic
> cmake works) and the test file is pretty simple:

Thanks.  I've narrowed it down to this session:

-
$ cat ../CMakeLists.txt
cmake_minimum_required(VERSION 3.2)
project(Sample NONE)
message("message")
function(message)
  _message(${ARGN})
endfunction()

$ cmake-gui  ..
(click configure twice)
-

It bisects to this commit:

 cmake: Simplify command clean up loop.
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=97e53ebb

Steve, please take a look.  It looks like the cmState methods
RemoveUserDefinedCommands and RenameCommand need to work better
together.  This needs to be fixed for 3.3.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers