Re: [cmake-developers] [PATCH] ExternalProject: Added new USES_TERMINAL options

2015-07-06 Thread Brad King
On 07/06/2015 01:52 AM, James Johnston wrote:
 I worked on a patch to allow you to pass USES_TERMINAL through
 ExternalProject to the underlying add_custom_command().

Very nice.  I applied the commit:

 ExternalProject: Added new USES_TERMINAL options
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e4947639

I tweaked UsesTerminal-check.cmake with a better way to avoid
the CMP0012 warning (by just ensuring the policy is set to NEW).

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] [PATCH] ExternalProject: Added new USES_TERMINAL options

2015-07-06 Thread James Johnston
Hi,

I worked on a patch to allow you to pass USES_TERMINAL through
ExternalProject to the underlying add_custom_command().  Here is the commit
message:

ExternalProject:  Added new USES_TERMINAL options

Added new USES_TERMINAL option to the ExternalProject_Add_Step
function.  This option passes USES_TERMINAL to the underlying
add_custom_command call so that the Ninja console pool is used.
Also, corresponding new USES_TERMINAL_step options were added
to the ExternalProject_Add function.

Justification: if using Ninja with a CMake superbuild, it's often
desirable to limit the superbuild to ONE sub-Ninja process at a
time to avoid oversubscribing the CPU.  Using the console pool also
makes it easy to monitor the progress of the sub-Ninja process.

Independent USES_TERMINAL_step arguments are passed to
ExternalProject_Add instead of one USES_TERMINAL argument that
controls everything.  Users may wish to run some steps in parallel
but not others (e.g. parallelize configure but not build).

Best regards,

James Johnston


0001-ExternalProject-Added-new-USES_TERMINAL-options.patch
Description: Binary data
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers