Re: [cmake-developers] [PATCH] FindMPI: Intel-MPI 5+ workaround

2015-07-10 Thread Brad King 
On 07/10/2015 02:56 AM, Rolf Eike Beer wrote:
> Am Donnerstag, 9. Juli 2015, 11:05:13 schrieb Brad King:
>>  FindMPI: Extend Intel-MPI 5+ workaround for recent GCCs
>>  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5d7653a0
> 
> For the usual reasons, can we please change this from
> "${cmdline}" to cmdline?

Yes, revised:

 FindMPI: Extend Intel-MPI 5+ workaround for recent GCCs
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cfd23d3f

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] FindMPI: Intel-MPI 5+ workaround

2015-07-10 Thread Rolf Eike Beer 
Am Donnerstag, 9. Juli 2015, 14:42:13 schrieb Brennan, Sean M:
> See attached git patch.
> 
> FindMPI: Intel-MPI 5+ workaround needs an additional/alternate keyword to
> recognize this case with recent GCCs.
> 
> Confirmed working with intel-mpi/5.0.1 using gcc/4.4.7, gcc/4.6.1,
> gcc/4.7.2, gcc/4.8.2, intel/11.1.072, intel/12.1.5, intel/13.1.3,
> intel/14.0.4, intel/15.0.090, pgi/10.9, pgi/12.6, pgi/13.7, pgi/14.10.
> Tested by building LLNL's PnMPI library.

That's quite an impressive list of tools. Is there any chance that we can get 
an automated nigthly build that has access to them?

Eike

signature.asc
Description: This is a digitally signed message part.
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] FindMPI: Intel-MPI 5+ workaround

2015-07-10 Thread Rolf Eike Beer 
Am Donnerstag, 9. Juli 2015, 11:05:13 schrieb Brad King:
> On 07/09/2015 10:42 AM, Brennan, Sean M wrote:
> > See attached git patch.
> 
> Applied, thanks:
> 
>  FindMPI: Extend Intel-MPI 5+ workaround for recent GCCs
>  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5d7653a0

For the usual reasons, can we please change this from "${cmdline}" to cmdline?

Eike

signature.asc
Description: This is a digitally signed message part.
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] FindMPI: Intel-MPI 5+ workaround

2015-07-09 Thread Brad King 
On 07/09/2015 10:42 AM, Brennan, Sean M wrote:
> See attached git patch.

Applied, thanks:

 FindMPI: Extend Intel-MPI 5+ workaround for recent GCCs
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5d7653a0

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] [PATCH] FindMPI: Intel-MPI 5+ workaround

2015-07-09 Thread Brennan, Sean M 
See attached git patch.

FindMPI: Intel-MPI 5+ workaround needs an additional/alternate keyword to 
recognize this case with recent GCCs.

Confirmed working with intel-mpi/5.0.1 using gcc/4.4.7, gcc/4.6.1, gcc/4.7.2, 
gcc/4.8.2, intel/11.1.072, intel/12.1.5, intel/13.1.3, intel/14.0.4, 
intel/15.0.090, pgi/10.9, pgi/12.6, pgi/13.7, pgi/14.10. Tested by building 
LLNL's PnMPI library.



Sean M. Brennan, Ph.D.

High Performance Computing Systems
Los Alamos National Laboratory
PO Box 1663, MS T080
Los Alamos, NM 87545

(505) 667-1092, fax: (505) 667-7665From c7282a89609b79f8c65c0efa86d0cb74e843e80e Mon Sep 17 00:00:00 2001
From: Sean Brennan 
Date: Thu, 9 Jul 2015 08:34:19 -0600
Subject: [PATCH] FindMPI: Intel-MPI 5+ workaround needs an
 additional/alternate keyword to recognize this case with recent GCCs.

---
 Modules/FindMPI.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Modules/FindMPI.cmake b/Modules/FindMPI.cmake
index 545b077..039f109 100644
--- a/Modules/FindMPI.cmake
+++ b/Modules/FindMPI.cmake
@@ -204,7 +204,7 @@ function (_mpi_check_compiler compiler options cmdvar resvar)
   # Intel MPI 5.0.1 will return a zero return code even when the
   # argument to the MPI compiler wrapper is unknown.  Attempt to
   # catch this case.
-  if("${cmdline}" MATCHES "undefined reference")
+  if("${cmdline}" MATCHES "undefined reference" OR "${cmdline}" MATCHES "unrecognized")
 set(success 255 )
   endif()
   set(${cmdvar} "${cmdline}" PARENT_SCOPE)
-- 
2.1.0

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers