Re: [cmake-developers] [PATCH] Help: Fix cmake-server typo and message type consistency

[Brad King]

On 10/21/2016 10:30 AM, Tobias Hunger wrote:
> Yes, this change is correct. I stumbled over this myself this afternoon.

Thanks.  I've submitted a MR with the prose updated too here:

 https://gitlab.kitware.com/cmake/cmake/merge_requests/191

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Help: Fix cmake-server typo and message type consistency

[Brad King]

On 10/21/2016 09:51 AM, Sylvain Joubert wrote:
> Please find attached a patch that corrects a typo and a inconsistency
> in a code snippet.

Thanks!

BTW, since you last contributed we've switched from using the mailing
list for patches to using GitLab merge requests:

  https://gitlab.kitware.com/cmake/cmake

Please see the updated CONTRIBUTING.rst.

> -This requist will generate build system files in the build directory and
> +This request will generate build system files in the build directory and

Good catch.

> -  {"type":"project"}
> +  {"type":"codemodel"}
...
> -"inReplyTo":"project",
> +"inReplyTo":"codemodel",

Tobias, please confirm that this change is correct.

It looks like `"project"` is used in the prose shortly after those hunks.
Should those instances be changed too?

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] [PATCH] Help: Fix cmake-server typo and message type consistency

[Sylvain Joubert]

Hello,

Please find attached a patch that corrects a typo and a inconsistency in a
code snippet.
The patch is based on the 'release' branch.

Regards,
Sylvain
From c861c3341a59ca635f98e6f56caee7104f16dc32 Mon Sep 17 00:00:00 2001
From: Sylvain Joubert 
Date: Fri, 21 Oct 2016 15:46:12 +0200
Subject: [PATCH] Help: Fix cmake-server typo and message type consistency

---
 Help/manual/cmake-server.7.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Help/manual/cmake-server.7.rst b/Help/manual/cmake-server.7.rst
index afd4e2b..a3a4237 100644
--- a/Help/manual/cmake-server.7.rst
+++ b/Help/manual/cmake-server.7.rst
@@ -403,7 +403,7 @@ CMake will reply like this (after reporting progress for some time)::
 Type "compute"
 ^^
 
-This requist will generate build system files in the build directory and
+This request will generate build system files in the build directory and
 is only available after a project was successfully "configure"d.
 
 Example::
@@ -520,7 +520,7 @@ sourceDirectory of the target.
 Example::
 
   [== CMake Server ==[
-  {"type":"project"}
+  {"type":"codemodel"}
   ]== CMake Server ==]
 
 CMake will reply::
@@ -529,7 +529,7 @@ CMake will reply::
   {
 "cookie":"",
 "type":"reply",
-"inReplyTo":"project",
+"inReplyTo":"codemodel",
 
 "projects":
 [
-- 
2.9.3

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers