Re: [cmake-developers] [PATCH 1/2] cmPropertyDefinition::IsChained is const
On 2/29/2012 7:56 AM, Yury G. Kudryashov wrote: Brad King wrote: Please add -Woverloaded-virtual and try again. Done, fixed. Pushed to the same branch. Merged, thanks. I squashed the two Is* method fixes into the original commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=737c49a3 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=261491fe -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 1/2] cmPropertyDefinition::IsChained is const
Brad King wrote: > On Tue, Feb 28, 2012 at 4:07 PM, Yury G. Kudryashov > wrote: >> This branch compiles with -Werror here: >> git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git add-const- >> qualifiers > > I still get warnings like: > > Source/cmCommand.h:99:16: warning: ‘virtual bool > cmCommand::IsScriptable() const’ was hidden [-Woverloaded-virtual] > Source/cmMacroCommand.cxx:53:16: warning: by ‘virtual bool > cmMacroHelperCommand::IsScriptable()’ [-Woverloaded-virtual] > > Please add -Woverloaded-virtual and try again. Done, fixed. Pushed to the same branch. -- Yury G. Kudryashov, mailto: ur...@mccme.ru -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 1/2] cmPropertyDefinition::IsChained is const
On Tue, Feb 28, 2012 at 4:07 PM, Yury G. Kudryashov wrote: > This branch compiles with -Werror here: > git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git add-const- > qualifiers I still get warnings like: Source/cmCommand.h:99:16: warning: ‘virtual bool cmCommand::IsScriptable() const’ was hidden [-Woverloaded-virtual] Source/cmMacroCommand.cxx:53:16: warning: by ‘virtual bool cmMacroHelperCommand::IsScriptable()’ [-Woverloaded-virtual] Please add -Woverloaded-virtual and try again. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 1/2] cmPropertyDefinition::IsChained is const
Brad King wrote: > On 2/25/2012 3:19 AM, Yury G. Kudryashov wrote: >> Yury G. Kudryashov wrote: >> >>> From: "Yury G. Kudryashov" >>> >> Mailman says that the next patch is too big. The compressed version is >> attached. > > While building I get: This branch compiles with -Werror here: git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git add-const- qualifiers -- Yury G. Kudryashov, mailto: ur...@mccme.ru -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 1/2] cmPropertyDefinition::IsChained is const
On 2/25/2012 3:19 AM, Yury G. Kudryashov wrote: Yury G. Kudryashov wrote: From: "Yury G. Kudryashov" Mailman says that the next patch is too big. The compressed version is attached. While building I get: Source/cmCommand.h:108:16: warning: 'virtual bool cmCommand::IsDiscouraged() const' was hidden [-Woverloaded-virtual] Source/cmExecProgramCommand.h:87:16: warning: by 'virtual bool cmExecProgramCommand::IsDiscouraged()' [-Woverloaded-virtual] I think you missed some IsDiscouraged instances. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 1/2] cmPropertyDefinition::IsChained is const
Yury G. Kudryashov wrote: > From: "Yury G. Kudryashov" > Mailman says that the next patch is too big. The compressed version is attached. -- Yury G. Kudryashov, mailto: ur...@mccme.ru 0002-Add-const-qualifier-to-some-cmCommand-members.patch.xz Description: application/xz -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [PATCH 1/2] cmPropertyDefinition::IsChained is const
From: "Yury G. Kudryashov"
---
Source/cmPropertyDefinition.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Source/cmPropertyDefinition.h b/Source/cmPropertyDefinition.h
index f68db87..58d1472 100644
--- a/Source/cmPropertyDefinition.h
+++ b/Source/cmPropertyDefinition.h
@@ -31,7 +31,7 @@ public:
cmPropertyDefinition() { this->Chained = false; };
// is it chained?
- bool IsChained() {return this->Chained; };
+ bool IsChained() const { return this->Chained; };
// Get the section if any
const std::string &GetDocumentationSection() const {
--
1.7.8
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
