Re: [cmake-developers] [patch] fix Info.plist support for CFBundles

2014-03-26 Thread Brad King
On 03/25/2014 11:19 AM, Tim Blechmann wrote:
> Info.plist files were generated in the wrong place when generating
> CFBundles. attached patch fixes this behavior.

Applied, thanks!

 OS X: Fix Info.plist placement in a CFBundle
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=90e22f8f

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


[cmake-developers] [patch] fix Info.plist support for CFBundles

2014-03-25 Thread Tim Blechmann
Info.plist files were generated in the wrong place when generating
CFBundles. attached patch fixes this behavior.

>From 7750f35bee583d280519e87ce8efd6faaf121fca Mon Sep 17 00:00:00 2001
From: Tim Blechmann 
Date: Tue, 25 Mar 2014 16:16:51 +0100
Subject: [PATCH] osx bundle generator: correctly generate Info.plist

Info.plist was placed into CMAKE_BINARY_DIR, not CMAKE_CURRENT_BINARY_DIR
because the target path was not generated correctly
---
 Source/cmOSXBundleGenerator.cxx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Source/cmOSXBundleGenerator.cxx b/Source/cmOSXBundleGenerator.cxx
index 6f16913..786e6e2 100644
--- a/Source/cmOSXBundleGenerator.cxx
+++ b/Source/cmOSXBundleGenerator.cxx
@@ -178,7 +178,7 @@ void cmOSXBundleGenerator::CreateCFBundle(const 
std::string& targetName,
 
   // Configure the Info.plist file.  Note that it needs the executable name
   // to be set.
-  std::string plist =
+  std::string plist = root + "/" +
 this->GT->Target->GetCFBundleDirectory(this->ConfigName, true);
   plist += "/Info.plist";
   this->LocalGenerator->GenerateAppleInfoPList(this->GT->Target,
-- 
1.9.1

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers