Re: [cmake-developers] 185 - CMakeOnly.AllFindModules (Failed)
On Thu, Mar 8, 2012 at 5:33 PM, Rolf Eike Beer wrote: > David Cole wrote: >> Eike, >> >> I've got a test machine setup where I'm using the latest Xcode 4.3 >> from Apple, and I'm getting output like this from the AllFindModules >> test: >> >> CMake Error at CMakeLists.txt:52 (message): >> GIT_VERSION_STRING has unexpected content 1.7.7.5 (Apple Git-26) >> >> Is there a way to say "it's ok for the version string to have extra >> stuff after the version number" without breaking your concept of >> "expected content" too much? Really, our expectation of a version >> number string in CMake is anything that's useful with VERSION_LESS and >> VERSION_GREATER comparisons. The above string is useful, and would be >> valid for version comparisons. >> >> Perhaps we could use the regex you're using now, but only care about >> the *start* of the string? > > I have no problem if you change the ending to "( .*)?" (or whatever is > correct). It now has been proven that the expectation of what would come out > of this is too narrow. > > On the other hand I wonder if we should simply cut away that trailing stuff in > FindGit.cmake. > > Eike > -- > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers I've finally committed and merged to 'next' a fix for this test: http://public.kitware.com/gitweb?p=cmake.git;a=commitdiff;h=a5ee62851973713e15147d046d7d0d4abcfdd078 See the commit message and the diff for details. Let me know if you think I've relaxed things too much, or if you disagree with any of the expectations I've encoded here. Thanks, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] 185 - CMakeOnly.AllFindModules (Failed)
David Cole wrote: > Eike, > > I've got a test machine setup where I'm using the latest Xcode 4.3 > from Apple, and I'm getting output like this from the AllFindModules > test: > > CMake Error at CMakeLists.txt:52 (message): > GIT_VERSION_STRING has unexpected content 1.7.7.5 (Apple Git-26) > > Is there a way to say "it's ok for the version string to have extra > stuff after the version number" without breaking your concept of > "expected content" too much? Really, our expectation of a version > number string in CMake is anything that's useful with VERSION_LESS and > VERSION_GREATER comparisons. The above string is useful, and would be > valid for version comparisons. > > Perhaps we could use the regex you're using now, but only care about > the *start* of the string? I have no problem if you change the ending to "( .*)?" (or whatever is correct). It now has been proven that the expectation of what would come out of this is too narrow. On the other hand I wonder if we should simply cut away that trailing stuff in FindGit.cmake. Eike -- signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] 185 - CMakeOnly.AllFindModules (Failed)
On Mon, Feb 13, 2012 at 12:44 PM, Rolf Eike Beer wrote: > Am Montag, 13. Februar 2012, 11:33:14 schrieb Bill Hoffman: >> On our linux release machine we are getting an error in the modules >> that is preventing the release from being made. The error is: >> >> CMake Error at CMakeLists.txt:58 (message): >> GNUPLOT_VERSION_STRING has unexpected content >> >> -- Configuring incomplete, errors occurred! >> CMake Error at Test.cmake:11 (message): >> CMake failed to configure AllFindModules >> >> The gnuplot on that machine is sooo old it does not respond to --version... >> >> The linux is very old so that CMake is forward compatible with other >> machines. > > I have no problem in removing this check (and in fact I will). This test is > only that strict to find if there are actually versions out there where the > version check does not work. Looks like there are gnuplot versions where this > will never work, so the check will go. > > Eike > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers Eike, I've got a test machine setup where I'm using the latest Xcode 4.3 from Apple, and I'm getting output like this from the AllFindModules test: CMake Error at CMakeLists.txt:52 (message): GIT_VERSION_STRING has unexpected content 1.7.7.5 (Apple Git-26) Is there a way to say "it's ok for the version string to have extra stuff after the version number" without breaking your concept of "expected content" too much? Really, our expectation of a version number string in CMake is anything that's useful with VERSION_LESS and VERSION_GREATER comparisons. The above string is useful, and would be valid for version comparisons. Perhaps we could use the regex you're using now, but only care about the *start* of the string? Thanks, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] 185 - CMakeOnly.AllFindModules (Failed)
Am Montag, 13. Februar 2012, 11:33:14 schrieb Bill Hoffman: > On our linux release machine we are getting an error in the modules > that is preventing the release from being made. The error is: > > CMake Error at CMakeLists.txt:58 (message): >GNUPLOT_VERSION_STRING has unexpected content > > -- Configuring incomplete, errors occurred! > CMake Error at Test.cmake:11 (message): >CMake failed to configure AllFindModules > > The gnuplot on that machine is sooo old it does not respond to --version... > > The linux is very old so that CMake is forward compatible with other > machines. I have no problem in removing this check (and in fact I will). This test is only that strict to find if there are actually versions out there where the version check does not work. Looks like there are gnuplot versions where this will never work, so the check will go. Eike signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] 185 - CMakeOnly.AllFindModules (Failed)
On 2/13/2012 11:33 AM, Bill Hoffman wrote: CMake Error at CMakeLists.txt:58 (message): GNUPLOT_VERSION_STRING has unexpected content [snip] The gnuplot on that machine is sooo old it does not respond to --version... FYI, the version is: gnuplot-3.7.1 but I had to get that information from the package manager. The man page lists no flags to get the version. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] 185 - CMakeOnly.AllFindModules (Failed)
On our linux release machine we are getting an error in the modules that is preventing the release from being made. The error is: CMake Error at CMakeLists.txt:58 (message): GNUPLOT_VERSION_STRING has unexpected content -- Configuring incomplete, errors occurred! CMake Error at Test.cmake:11 (message): CMake failed to configure AllFindModules The gnuplot on that machine is sooo old it does not respond to --version... The linux is very old so that CMake is forward compatible with other machines. -Bill -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
