Re: [cmake-developers] Avoid merging stderr/stdout in RunSingleCommand
Sure, attached files. /Johan On Mon, Jul 25, 2011 at 5:32 PM, Brad King brad.k...@kitware.com wrote: On 07/20/2011 05:48 AM, Johan Björk wrote: Finally got around to fix this properly. Let me know what you think. Cool, thanks! Please split the patch into one that converts the boolean to an enumeration value with just OUTPUT_NONE and OUTPUT_MERGE and a second patch that adds OUTPUT_NORMAL and the new implementation. That will be easier to review. Thanks, -Brad 0001-cmSystemTools-RunSingleCommand-now-takes-a-enum-inst.patch Description: Binary data 0002-cmSystemTools-RunSingleCommand-add-a-OUTPUT_NORMAL-f.patch Description: Binary data ___ cmake-developers mailing list cmake-developers@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Avoid merging stderr/stdout in RunSingleCommand
On 07/20/2011 05:48 AM, Johan Björk wrote: Finally got around to fix this properly. Let me know what you think. Cool, thanks! Please split the patch into one that converts the boolean to an enumeration value with just OUTPUT_NONE and OUTPUT_MERGE and a second patch that adds OUTPUT_NORMAL and the new implementation. That will be easier to review. Thanks, -Brad ___ cmake-developers mailing list cmake-developers@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Avoid merging stderr/stdout in RunSingleCommand
Hi Brad, Finally got around to fix this properly. Let me know what you think. Cheers /Johan On Mon, May 16, 2011 at 6:58 PM, Brad King brad.k...@kitware.com wrote: On 05/16/2011 10:05 AM, Johan Björk wrote: Would it be possible to change the verbose flag to output the results on the corresponding stream as it was read on? Instead replace the verbose boolean with an enumeration that chooses among off, on, or split verbosity. I don't quite understand the StdoutCallback and Error callbacks inside cmSystemTools. Anyone can tell me what they are used for? IIRC they're used inside cmake-gui to capture the output of child processes for display in the window instead of the real stdout and stderr. See attached patch. Not sure if I propose it, as it will break for anyone expecting all output in stdout. I guess we could introduce a --no-merge-output or something flag. That makes sense. The flag would just map through to the proper argument of RunSingleCommand. -Brad 0001-Replace-the-verbose-flag-in-cmSystemTools-RunSingleC.patch Description: Binary data ___ cmake-developers mailing list cmake-developers@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
