Re: [cmake-developers] Bug introduced in generate-time target checking code
Stephen Kelly wrote: Stephen Kelly wrote: Stephen Kelly wrote: None of the outputs have a backtrace. Any idea why? Can a backtrace be provided? Reading the code, I'm not seeing which iteration is going past the end. I added some asserts and found that the problem is in iterating over comma tokens somehow. I'll see about fixing it. I wrote a topic to attempt to fix this, but it seems to have had mixed results. Bcc still fails, vs10 passes, but has a new failure in RunCMake.TargetPropertyGeneratorExpressions: http://open.cdash.org/viewTest.php?onlyfailedbuildid=2614187 http://open.cdash.org/viewTest.php?onlydeltabuildid=2614232 I'm not sure if the new failure is the result of the merge or not. I'd probably need a backtrace to diagnose the bcc failure. The RunCMake.TargetPropertyGeneratorExpressions failure was probably a side- effect of the incremental builds of the Continuous configuration. Still, some of the platforms fail the test, and don't give any information about why: http://open.cdash.org/testSummary.php?project=1name=GeneratorExpressiondate=2012-10-16 Can someone please provide more information (backtrace or further investigation) for one of the failing platforms? Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Bug introduced in generate-time target checking code
On 10/16/2012 08:43 AM, Stephen Kelly wrote: Still, some of the platforms fail the test, and don't give any information about why: http://open.cdash.org/testSummary.php?project=1name=GeneratorExpressiondate=2012-10-16 Can someone please provide more information (backtrace or further investigation) for one of the failing platforms? Borland Make and NMake both have an inline file syntax that starts with : http://msdn.microsoft.com/en-us/library/z440c98k.aspx The custom command generated by this test accidentally triggers that. I don't know if there is a way to escape it. It's probably simplest for your purposes to just do something else in the test. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Bug introduced in generate-time target checking code
Stephen Kelly wrote: Thoughts? I've pushed a fix-NOTFOUND-processing branch to next. It preprocesses the INCLUDE_DIRECTORIES property content to remove generator expressions before checking them. This way, all entries which are well-defined at configure- time will still report an error as before. For entries which are only evaluated at generate-time, we'll still need a solution in the following release I think. This is somewhat related to [1] because I'll be changing how linking works then too. [1] http://public.kitware.com/Bug/view.php?id=13588 Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Bug introduced in generate-time target checking code
On 10/15/2012 04:54 AM, Stephen Kelly wrote: Stephen Kelly wrote: Thoughts? I've pushed a fix-NOTFOUND-processing branch to next. It preprocesses the INCLUDE_DIRECTORIES property content to remove generator expressions before checking them. This way, all entries which are well-defined at configure- time will still report an error as before. Thanks for working on the fix, but the GeneratorExpression test is failing on Windows builds so it cannot be merged to master yet. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Bug introduced in generate-time target checking code
Brad King wrote:
On 10/15/2012 04:54 AM, Stephen Kelly wrote:
Stephen Kelly wrote:
Thoughts?
I've pushed a fix-NOTFOUND-processing branch to next. It preprocesses the
INCLUDE_DIRECTORIES property content to remove generator expressions
before checking them. This way, all entries which are well-defined at
configure- time will still report an error as before.
Thanks for working on the fix, but the GeneratorExpression test is failing
on Windows builds so it cannot be merged to master yet.
That's failing in the nightlies, so it's coming from a branch I merged
before ('generator-expression-bug-fixes').
None of the outputs have a backtrace. Any idea why? Can a backtrace be
provided? Reading the code, I'm not seeing which iteration is going past the
end.
Thanks,
Steve.
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Bug introduced in generate-time target checking code
Stephen Kelly wrote: None of the outputs have a backtrace. Any idea why? Can a backtrace be provided? Reading the code, I'm not seeing which iteration is going past the end. I added some asserts and found that the problem is in iterating over comma tokens somehow. I'll see about fixing it. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Bug introduced in generate-time target checking code
Stephen Kelly wrote: Stephen Kelly wrote: None of the outputs have a backtrace. Any idea why? Can a backtrace be provided? Reading the code, I'm not seeing which iteration is going past the end. I added some asserts and found that the problem is in iterating over comma tokens somehow. I'll see about fixing it. I wrote a topic to attempt to fix this, but it seems to have had mixed results. Bcc still fails, vs10 passes, but has a new failure in RunCMake.TargetPropertyGeneratorExpressions: http://open.cdash.org/viewTest.php?onlyfailedbuildid=2614187 http://open.cdash.org/viewTest.php?onlydeltabuildid=2614232 I'm not sure if the new failure is the result of the merge or not. I'd probably need a backtrace to diagnose the bcc failure. Anyway, this should be unrelated to the fix-NOTFOUND-processing branch. The fix-INCLUDE_DIRECTORIES-multiconfig is also important for the release I think, but I haven't tested it with the multi-config generators. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Bug introduced in generate-time target checking code
Hi there, I just noticed that I probably introduced a bug in commit 290e92ada86c5b74669be48ee901494ae8e48ee3. I don't have time to fix it or even test it right now, but in that commit I changed a call to GetTargets into GetGeneratorTargets in cmGlobalGenerator::CheckLocalGenerators. The problem is that CheckLocalGenerators is called at configure time, so the GeneratorTargets is still empty. Can CheckLocalGenerators be invoked at generate time instead? It calls GetOriginalLinkLibraries, which I also need to call only at generate-time as it will need to be moved to cmGeneratorTarget and use generator expressions. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
