Re: [cmake-developers] Bugfix: Default behavior of CUDA_USE_STATIC_CUDA_RUNTIME
Hi Stephen, On 08/11/2016 03:37 PM, Sorley, Stephen L. wrote: > Recent changes to FindCUDA.cmake (commit 7229ae7) broke Thanks for these two fixes. I've applied them: FindCUDA: Restore default behavior of CUDA_USE_STATIC_CUDA_RUNTIME https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=aab1f6e9 FindCUDA: Fix missing librt on Linux when using static cuda runtime. https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1aa5c1be James, do these look good to you? Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Bugfix: Default behavior of CUDA_USE_STATIC_CUDA_RUNTIME
The previous fix uncovered another bug from commit 7229ae7. That commit dropped librt from the link line when using static linking with CUDA 7.0 or newer on Linux. However, librt is still required on the link line in newer CUDA versions, I get linker errors without it. I've attached a second patch to fix this extra bug. Thanks! Stephen Sorley From: Sorley, Stephen L. Sent: Thursday, August 11, 2016 3:37 PM To: cmake-developers@cmake.org Subject: Bugfix: Default behavior of CUDA_USE_STATIC_CUDA_RUNTIME Recent changes to FindCUDA.cmake (commit 7229ae7) broke the documented behavior of the CUDA_USE_STATIC_CUDA_RUNTIME option. Per the documentation, this option should be enabled by default if libcudart_static is present in the selected version of CUDA, and silently disabled if it's not. After commit 7229ae7, the option is disabled by default instead. I've attached a small patch (based on master) that fixes the problem. Thanks! Stephen Sorley 0001-Fix-for-missing-librt-on-Linux-when-using-static-cud.patch Description: 0001-Fix-for-missing-librt-on-Linux-when-using-static-cud.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Bugfix: Default behavior of CUDA_USE_STATIC_CUDA_RUNTIME
Recent changes to FindCUDA.cmake (commit 7229ae7) broke the documented behavior of the CUDA_USE_STATIC_CUDA_RUNTIME option. Per the documentation, this option should be enabled by default if libcudart_static is present in the selected version of CUDA, and silently disabled if it's not. After commit 7229ae7, the option is disabled by default instead. I've attached a small patch (based on master) that fixes the problem. Thanks! Stephen Sorley 0001-Restore-default-behavior-of-CUDA_USE_STATIC_CUDA_RUN.patch Description: 0001-Restore-default-behavior-of-CUDA_USE_STATIC_CUDA_RUN.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
