Re: [cmake-developers] CTest update broken with non-ASCII filenames
On 09.04.2015 20:39, Rolf Eike Beer wrote: Am Donnerstag, 9. April 2015, 10:30:35 schrieb Brad King: On 04/09/2015 10:28 AM, Nils Gladitz wrote: What was the original problem you were trying to fix? You pointed out test failures on "nibble.ngladitz" which I then tried to fix: https://open.cdash.org/testDetails.php?test=316350872&build=3711574 Right, I forgot about that, thanks. So, this was exposed by using the zh_HK locale. Just guessing: C will be "ASCII", i.e. "every 8 bit character gets mangled" (or at least everything not being able to be displayed in a 256 byte codepage). So a fix could be to use something like en_US.UTF-8, if that is available on the system, which sadly may not always be the case. I merged "c-locale-messages" which tries to preserve LC_CTYPE (which affects filename encodings) in the presence of LC_ALL and sets LC_MESSAGES to C (which affects output messages). This does seem to fix both cases for me. Forcing UTF-8 might not be the correct way to go since people might be using other encoding beyond ASCII and UTF-8. It has been a while but I think I used to run linux distros with e.g. something similar to "en_US.ISO-8859-1". Haven't seen anything like that since but I am not really that familiar with what other system use ... also aren't locale names themselves platform specific? I implemented this outside of CTest hoping this might be something that could be reused elsewhere as well. Since running external processes with english ASCII messages is a common pattern I was thinking it could be added to e.g. execute_process() with a new e.g. "C_LOCALE_MESSAGES" flag? Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] CTest update broken with non-ASCII filenames
Am Donnerstag, 9. April 2015, 10:30:35 schrieb Brad King: > On 04/09/2015 10:28 AM, Nils Gladitz wrote: > >> What was the original problem you were trying to fix? > > > > You pointed out test failures on "nibble.ngladitz" which I then tried to > > fix: > > > > https://open.cdash.org/testDetails.php?test=316350872&build=3711574 > > Right, I forgot about that, thanks. So, this was exposed by > using the zh_HK locale. Just guessing: C will be "ASCII", i.e. "every 8 bit character gets mangled" (or at least everything not being able to be displayed in a 256 byte codepage). So a fix could be to use something like en_US.UTF-8, if that is available on the system, which sadly may not always be the case. Eike signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] CTest update broken with non-ASCII filenames
On 04/09/2015 10:28 AM, Nils Gladitz wrote: >> What was the original problem you were trying to fix? > > You pointed out test failures on "nibble.ngladitz" which I then tried to > fix: > > https://open.cdash.org/testDetails.php?test=316350872&build=3711574 Right, I forgot about that, thanks. So, this was exposed by using the zh_HK locale. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] CTest update broken with non-ASCII filenames
On 04/09/2015 04:15 PM, Brad King wrote: On 04/09/2015 07:54 AM, Nils Gladitz wrote: With c771f9d945444f6cfe41195e26653f368aff7f42 "CTest: To enforce the C locale use LC_ALL instead of LC_MESSAGES." I think you meant commit 6a661f06: CTest: To enforce the C locale use LC_ALL instead of LC_MESSAGES. http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6a661f06 Yes, sorry ... not sure how that happened. I broke svn updates for repositories which contain non-ASCII filenames. This is apparently due to me not only changing how messages are encoded but also how svn interprets filename encodings. I'll try to find a more appropriate fix. Thanks. If you are not able to find a good approach soon please revert the original change. Will do. What was the original problem you were trying to fix? You pointed out test failures on "nibble.ngladitz" which I then tried to fix: https://open.cdash.org/testDetails.php?test=316350872&build=3711574 Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] CTest update broken with non-ASCII filenames
On 04/09/2015 07:54 AM, Nils Gladitz wrote: > With c771f9d945444f6cfe41195e26653f368aff7f42 "CTest: To enforce the C > locale use LC_ALL instead of LC_MESSAGES." I think you meant commit 6a661f06: CTest: To enforce the C locale use LC_ALL instead of LC_MESSAGES. http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6a661f06 > I broke svn updates for repositories which contain non-ASCII filenames. > > This is apparently due to me not only changing how messages are encoded > but also how svn interprets filename encodings. > > I'll try to find a more appropriate fix. Thanks. If you are not able to find a good approach soon please revert the original change. What was the original problem you were trying to fix? -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] CTest update broken with non-ASCII filenames
With c771f9d945444f6cfe41195e26653f368aff7f42 "CTest: To enforce the C locale use LC_ALL instead of LC_MESSAGES." I broke svn updates for repositories which contain non-ASCII filenames. This is apparently due to me not only changing how messages are encoded but also how svn interprets filename encodings. I'll try to find a more appropriate fix. Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
