Re: [cmake-developers] EXCLUDE_FROM_DEFAULT_BUILD testing
On 11/12/2012 08:25 AM, Petr Kmoch wrote: Fixed (that is, works for me) and rebased to 3b7abfd. Thanks. Applied: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b777272b http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d1f8828c http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e31d83b3 I tweaked the first patch to avoid configuring anything into the test's build tree while configuring CMake itself. This way the test directory can be deleted by hand without needing to re-run CMake before the test can pass again. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] EXCLUDE_FROM_DEFAULT_BUILD testing
On 11/13/2012 09:18 AM, Brad King wrote: On 11/12/2012 08:25 AM, Petr Kmoch wrote: Fixed (that is, works for me) and rebased to 3b7abfd. Thanks. Applied: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b777272b http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d1f8828c http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e31d83b3 I tweaked the first patch to avoid configuring anything into the test's build tree while configuring CMake itself. This way the test directory can be deleted by hand without needing to re-run CMake before the test can pass again. I added one commit to fix parallel test invocations: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=739f1665 -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] EXCLUDE_FROM_DEFAULT_BUILD testing
On Tue, Nov 13, 2012 at 4:55 PM, Brad King brad.k...@kitware.com wrote: On 11/13/2012 09:18 AM, Brad King wrote: On 11/12/2012 08:25 AM, Petr Kmoch wrote: Fixed (that is, works for me) and rebased to 3b7abfd. Thanks. Applied: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b777272b http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d1f8828c http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e31d83b3 I tweaked the first patch to avoid configuring anything into the test's build tree while configuring CMake itself. This way the test directory can be deleted by hand without needing to re-run CMake before the test can pass again. I added one commit to fix parallel test invocations: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=739f1665 -Brad Thanks. I'm not that versed in CTest, so it's easy for me to fail to consider something. Petr -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] EXCLUDE_FROM_DEFAULT_BUILD testing
On Thu, Nov 8, 2012 at 10:54 AM, Petr Kmoch petr.km...@gmail.com wrote: Attached are modified patches adding EXCLUDE_FROM_DEFAULT_BUILD_CONFIG. The tests do not pass for me on VS 10. For example, VSExcludeFromDefaultBuild-Debug output contains: Run Build Command: ...\devenv.com VSExcludeFromDefaultBuild.sln /build Debug /project ALL_BUILD 11-- Skipped Build: Project: BuiltInDebug, Configuration: Debug x64 -- 11Project not selected to build for this solution configuration ... CMake Error at ResultTest.cmake:11 (message): File .../Debug/BuiltInDebug.exe was expected to exist! -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] EXCLUDE_FROM_DEFAULT_BUILD testing
Hi Brad. Now that 2.8.10 is released, do you think you'd have time to come back to my patch for per-config EXCLUDE_FROM_DEFAULT_BUILD? I verified that the tests fail when CMAKE_MAKE_PROGRAM points to msbuild, because 'cmake --build' does not operate on the .sln in such case. This means it makes no sense to run the tests when using msbuild. Shall I send you a patch to disable the tests for it? And if so, on what commit should I base it? Petr On Wed, Oct 17, 2012 at 12:53 PM, Brad King brad.k...@kitware.com wrote: On 10/17/2012 3:24 AM, Petr Kmoch wrote: I'm a bit confused. We occasionally use MSBuild for driving builds at work, but we always feed it solution files. How do you run it so that it doesn't read them? And how does it then cope with project dependencies etc.? I haven't fully investigated yet, but all of the dashboard builds that failed the tests were using MSBuild as the tool. Try building with CMAKE_MAKE_PROGRAM set to MSBuild.exe instead of devenv.exe and run the test. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] EXCLUDE_FROM_DEFAULT_BUILD testing
On 11/06/2012 08:22 AM, Petr Kmoch wrote: I verified that the tests fail when CMAKE_MAKE_PROGRAM points to msbuild, because 'cmake --build' does not operate on the .sln in such case. FYI, a recent issue was filed that may require cmake --build to read the .sln file: http://www.cmake.org/Bug/view.php?id=13623 It has some overlap with your work in case you want to try fixing it. This means it makes no sense to run the tests when using msbuild. Shall I send you a patch to disable the tests for it? And if so, on what commit should I base it? Please rebase all your commits on master and squash the not-on-msbuild part into the same commit that adds the test. Include a comment explaining why it can't run with MSBuild. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] EXCLUDE_FROM_DEFAULT_BUILD testing
On Tue, Nov 6, 2012 at 2:31 PM, Brad King brad.k...@kitware.com wrote: On 11/06/2012 08:22 AM, Petr Kmoch wrote: I verified that the tests fail when CMAKE_MAKE_PROGRAM points to msbuild, because 'cmake --build' does not operate on the .sln in such case. FYI, a recent issue was filed that may require cmake --build to read the .sln file: http://www.cmake.org/Bug/view.php?id=13623 It has some overlap with your work in case you want to try fixing it. This means it makes no sense to run the tests when using msbuild. Shall I send you a patch to disable the tests for it? And if so, on what commit should I base it? Please rebase all your commits on master and squash the not-on-msbuild part into the same commit that adds the test. Include a comment explaining why it can't run with MSBuild. Yup, I'll do that. Petr -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] EXCLUDE_FROM_DEFAULT_BUILD testing
On Tue, Oct 16, 2012 at 5:26 PM, Brad King brad.k...@kitware.com wrote: On 10/16/2012 11:04 AM, Brad King wrote: I tested it locally on VS 6, 7.1, 8, 9, 10, and 11 all with spaces in the path. I need to investigate the failures on the dashboard to identify the problem. Since we're trying to keep the dashboard as clean as possible right now (to more directly test any changes meant to fix any regressions in 2.8.10-rc1) I'm reverting the change: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=69e305f2 until after the final 2.8.10 release and when we've resolved these failures. We can restore the topic later. OK, I understand release candidate mode is not the time to add new features :-) The problem is that MSBuild may be used as the build tool instead of devenv, especially for VS Express editions. The MSBuild tool doesn't even read the .sln so this property does not make sense. One option is to run the test only when the build tool is devenv. I'm a bit confused. We occasionally use MSBuild for driving builds at work, but we always feed it solution files. How do you run it so that it doesn't read them? And how does it then cope with project dependencies etc.? Anyway, the test only makes sense in cases where the property applies, so if MSBuild doesn't honour the build/don't build settings in the .sln, there's no point in running it with MSBuild. Petr -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] EXCLUDE_FROM_DEFAULT_BUILD testing
On 10/17/2012 3:24 AM, Petr Kmoch wrote: I'm a bit confused. We occasionally use MSBuild for driving builds at work, but we always feed it solution files. How do you run it so that it doesn't read them? And how does it then cope with project dependencies etc.? I haven't fully investigated yet, but all of the dashboard builds that failed the tests were using MSBuild as the tool. Try building with CMAKE_MAKE_PROGRAM set to MSBuild.exe instead of devenv.exe and run the test. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] EXCLUDE_FROM_DEFAULT_BUILD testing
On 10/16/2012 11:04 AM, Brad King wrote: I tested it locally on VS 6, 7.1, 8, 9, 10, and 11 all with spaces in the path. I need to investigate the failures on the dashboard to identify the problem. Since we're trying to keep the dashboard as clean as possible right now (to more directly test any changes meant to fix any regressions in 2.8.10-rc1) I'm reverting the change: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=69e305f2 until after the final 2.8.10 release and when we've resolved these failures. We can restore the topic later. The problem is that MSBuild may be used as the build tool instead of devenv, especially for VS Express editions. The MSBuild tool doesn't even read the .sln so this property does not make sense. One option is to run the test only when the build tool is devenv. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
