Re: [cmake-developers] OS X packaging updates
I had to revert again because it causes the Qt4Deploy to fail. The topic changes the signature of gp_file_type. User projects could be calling that, so we can't change it. In this case it is the Modules/DeployQt4.cmake file that was calling it. Thanks for spotting that. I've send updated 3/6 patch that now takes executable as an optional argument so we don't change any existing function signatures. --Adam -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] OS X packaging updates
On 09/05/2014 08:33 AM, Brad King wrote: Thanks. I've re-built the topic with those locally. I've merged to 'next' for testing: BundleUtilities: Use 'find' on UNIX for fast executable lookup http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=02dfaa31 GetPrerequisites: Make sure dyld placeholders are prefixes http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=195ec6b3 BundleUtilities: Resolve replace @rpath placeholders http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7747b13e BundleUtilities: Process executables first when scanning bundle http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ea9e35be BundleUtilities: Codesign needs framework's Contents/Info.plist http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd67c3ea cmake-gui: Make sure we bundle Qt5 Cocoa platform plugin http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c106311f -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] OS X packaging updates
On 09/08/2014 01:17 PM, Brad King wrote: On 09/05/2014 08:33 AM, Brad King wrote: Thanks. I've re-built the topic with those locally. I've merged to 'next' for testing: I had to revert again because it causes the Qt4Deploy to fail. The topic changes the signature of gp_file_type. User projects could be calling that, so we can't change it. In this case it is the Modules/DeployQt4.cmake file that was calling it. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] OS X packaging updates
I have sent updated 3/6 4/6. Rest of patches remain the same. I've tested on all 3 platforms: OSX, Windows Linux. Tests are now running fine. Regards -- Adam -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] OS X packaging updates
On 09/05/2014 07:53 AM, Adam Strzelecki wrote: I have sent updated 3/6 4/6. Rest of patches remain the same. I've tested on all 3 platforms: OSX, Windows Linux. Thanks. I've re-built the topic with those locally. I will merge again for testing next week when some issues caused by other topics have been resolved. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] OS X packaging updates (was: [PATCH 1/6] Use find on UNIX for fast executable lookup)
Hi Adam, Thanks. I've applied the series and merged to 'next' for testing: BundleUtilities: Use 'find' on UNIX for fast executable lookup http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=634b4d5a GetPrerequisites: Make sure dyld placeholders are prefixes http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4f577985 BundleUtilities: Resolve and replace @rpath placeholders http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=591380da BundleUtilities: Process executables first when scanning bundle http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=32a38bbc BundleUtilities: Codesign needs framework's Contents/Info.plist http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5361697b cmake-gui: Make sure we bundle Qt5 Cocoa platform plugin http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=da78e01c For the last change, might something like that be needed on Windows too? Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] OS X packaging updates (was: [PATCH 1/6] Use find on UNIX for fast executable lookup)
Thanks. I've applied the series and merged to 'next' for testing: Thanks! For the last change, might something like that be needed on Windows too? Yes, this is very likely. I can investigate that how it looks for Windows apps. --Adam -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] OS X packaging updates
On 09/04/2014 12:45 PM, Adam Strzelecki wrote: Thanks. I've applied the series and merged to 'next' for testing: Thanks! I had to revert the topic because it fails the BundleUtilities test on Linux and Windows on our continuous builds: http://open.cdash.org/testDetails.php?test=278873429build=3476297 http://open.cdash.org/testDetails.php?test=278879098build=3476366 Please run the CMake test: ctest -C Debug -R BundleUtilities -V locally on these platforms and revise accordingly. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] OS X packaging updates
Please run the CMake test: ctest -C Debug -R BundleUtilities -V locally on these platforms and revise accordingly. Okay, will do tommorow. Thanks for follow up. --Adam -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
