Re: [cmake-developers] Patches for some clang warnings
On 09/24/2013 08:32 AM, Eric Noulard wrote: >> Can you please fill in the docs for these? > > Yep. > Just done and merged to next: Great, thanks! -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patches for some clang warnings
2013/9/24 Brad King : > Hi Eric, > > On 09/19/2013 03:53 PM, Brad King wrote: >> On 09/19/2013 03:34 PM, Sean McBride wrote: >>> Thanks. Here are two more patches. > > Sean's -Wdocumentation build produces these warnings: > > .../Source/CPack/cmCPackGenerator.h:163:38: warning: empty paragraph passed > to '@param' command [-Wdocumentation] >* @param[in] initialPackageFileName > ^ > .../Source/CPack/cmCPackGenerator.h:164:36: warning: empty paragraph passed > to '@param' command [-Wdocumentation] >* @param[in] groupOrComponentName > ~~^ > .../Source/CPack/cmCPackGenerator.h:165:27: warning: empty paragraph passed > to '@param' command [-Wdocumentation] >* @param[in] isGroupName > ~^ > .../Source/CPack/cmCPackGenerator.h:175:10: warning: empty paragraph passed > to '@pre' command [-Wdocumentation] >* @pre @ref toplevel has been filled-in > ^ > > Can you please fill in the docs for these? Yep. Just done and merged to next: Fetching upstream next Merge topic 'fixDocumentationComment' into next e507bf2 CPack: Fix clang -Wdocumentation warnings -- Erk L'élection n'est pas la démocratie -- http://www.le-message.org -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patches for some clang warnings
Hi Eric, On 09/19/2013 03:53 PM, Brad King wrote: > On 09/19/2013 03:34 PM, Sean McBride wrote: >> Thanks. Here are two more patches. Sean's -Wdocumentation build produces these warnings: .../Source/CPack/cmCPackGenerator.h:163:38: warning: empty paragraph passed to '@param' command [-Wdocumentation] * @param[in] initialPackageFileName ^ .../Source/CPack/cmCPackGenerator.h:164:36: warning: empty paragraph passed to '@param' command [-Wdocumentation] * @param[in] groupOrComponentName ~~^ .../Source/CPack/cmCPackGenerator.h:165:27: warning: empty paragraph passed to '@param' command [-Wdocumentation] * @param[in] isGroupName ~^ .../Source/CPack/cmCPackGenerator.h:175:10: warning: empty paragraph passed to '@pre' command [-Wdocumentation] * @pre @ref toplevel has been filled-in ^ Can you please fill in the docs for these? Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patches for some clang warnings
On 09/19/2013 03:34 PM, Sean McBride wrote: > Thanks. Here are two more patches. I took the one to the third-party libs, but the one to cmListFileLexer.c is in generated code so it will not stick. Another topic already re-generates that file so this one will have to wait. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patches for some clang warnings
On Thu, 19 Sep 2013 13:53:54 -0400, Brad King said: >On 09/19/2013 01:22 PM, Sean McBride wrote: >> Attached are some patches to fix some warnings. > >Applied, thanks. Here is the merge to 'next': > > http://cmake.org/gitweb?p=cmake.git;a=commit;h=3964de62 Thanks. Here are two more patches. Once they are all in, there will be about 10 new warnings on Rogue7 for someone to fix... Cheers, -- Sean McBride, B. Eng s...@rogue-research.com Rogue Researchwww.rogue-research.com Mac Software Developer Montréal, Québec, Canada 0008-Populated-empty-doxygen-param-comment.patch Description: Binary data 0009-Suppressed-warnings-by-setting-initial-value.patch Description: Binary data -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patches for some clang warnings
On 09/19/2013 01:22 PM, Sean McBride wrote: > Attached are some patches to fix some warnings. Applied, thanks. Here is the merge to 'next': http://cmake.org/gitweb?p=cmake.git;a=commit;h=3964de62 -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Patches for some clang warnings
Hi all, After Kent's message on the other list, I realized I didn't have my CMake + clang trunk dashboard configured the way I thought I did, namely some warnings I thought were enabled were not. Attached are some patches to fix some warnings. There are a couple of others that will appear on the Rogue7 dashboard that are easy to fix by someone that knows the code better. Specifically: CMake/Source/cmCreateTestSourceList.h:18:10: warning: empty paragraph passed to '\brief' command [-Wdocumentation] * \brief ~~^ CMake/Source/CPack/cmCPackGenerator.h:163:38: warning: empty paragraph passed to '@param' command [-Wdocumentation] * @param[in] initialPackageFileName ^ CMake/Source/CPack/cmCPackGenerator.h:164:36: warning: empty paragraph passed to '@param' command [-Wdocumentation] * @param[in] groupOrComponentName ~~^ CMake/Source/CPack/cmCPackGenerator.h:165:27: warning: empty paragraph passed to '@param' command [-Wdocumentation] * @param[in] isGroupName ~^ CMake/Source/CPack/cmCPackGenerator.h:175:10: warning: empty paragraph passed to '@pre' command [-Wdocumentation] * @pre @ref toplevel has been filled-in ^ Cheers, -- Sean McBride, B. Eng s...@rogue-research.com Rogue Researchwww.rogue-research.com Mac Software Developer Montréal, Québec, Canada 0001-Fixed-typo-in-header-include-guard.patch Description: Binary data 0002-Removed-useless-semi-colon.patch Description: Binary data 0003-Add-extra-space-in-comment-to-suppress-warning.patch Description: Binary data 0004-Fixed-warning-about-brief-usage.patch Description: Binary data 0005-Properly-escape-char-in-doxygen-comments.patch Description: Binary data 0006-Populated-empty-doxygen-param-comment.patch Description: Binary data 0007-Fixed-a-few-doxygen-comment-errors.patch Description: Binary data -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
