Re: [cmake-developers] Questions on staged topic branches
On Tue, Sep 11, 2012 at 6:06 PM, James Bigler jamesbig...@gmail.com wrote: On Tue, Sep 4, 2012 at 11:48 AM, David Cole david.c...@kitware.com wrote: If you are on the To line, please reply to this email, and answer the questions below: Brad and I have questions on these staged topic branches before we consider them for merging to 'master'. ## # James Bigler: # topics/FindCUDA/Add-CUDA_HOST_COMPILER | master=0 next=1 Is CUDA_HOST_COMPILER a path to a directory or a file? It appears to take on different values depending on which if branch you go through. Is that true? Or should it always be a full path to the compiler? It can technically be either. --compiler-bindir path(-ccbin) Specify the directory in which the compiler executable (Microsoft Visual Studio cl, or a gcc derivative) resides. By default, this executable is expected in the current executable search path. For a different compiler, or to specify these compilers with a different executable name, specify the path to the compiler including the executable name. What is the best course of action in this case? What I've implemented seems to work, so I didn't think too much about it. As far as rebasing on the changes to the compiler id stuff, I would rather not until it becomes a must have feature. I've tried to make FindCUDA work on older than TOT versions of CMake to facilitate my local developer pool. James I was just asking the questions for clarification. If you think it is best as-is, and do not want to make further changes to it, we can accept it as-is into master. I think a variable that could be either a full path name to a compiler, or just the directory that contains a compiler (if it's this one, how do you know what the compiler in the directory is...?) -- I think it's just confusing and unclear. But if it works as expected for people who are using FindCUDA, I guess it's ok. (as you can probably tell, I'm not one of them...) We'll merge it next time around, unless you reply again and say you want to make further changes on the topic first. Thanks for the reply, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Questions on staged topic branches
On 09/04/2012 02:12 PM, Peter Kümmel wrote:
The problem is $ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}
because $ENV{DESTDIR} is absolute without final / and
is relative without initial /.
see
http://public.kitware.com/Bug/view.php?id=11785
I re-started discussion in the issue tracker entry.
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Questions on staged topic branches
By the way, James, you may be able to rebase your topic on current
'master' if you think it would make your change better to depend on
the recently added compiler id available everywhere for all
generators feature:
# feature added in this commit:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=66cb3356
# merged to 'master' here:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=34a02846
On Tue, Sep 4, 2012 at 1:48 PM, David Cole david.c...@kitware.com wrote:
If you are on the To line, please reply to this email, and answer
the questions below:
Brad and I have questions on these staged topic branches before we
consider them for merging to 'master'.
##
# Peter Kuemmel and Eric Noulard:
#cpack-stripping | master=0 next=1
This one should not be necessary. Can you tell us what problem it
fixes? The only valid install path that should ever go under DESTDIR
has to be an absolute path already anyways. So it will either start
with a / already, or a $ because it begins with
${CMAKE_INSTALL_PREFIX}... so this change is unnecessary, and in
fact harmful in the case where DESTDIR doesn't end with a / but the
install rule does begin with ${CMAKE_INSTALL_PREFIX}. (Or are we
misreading this somehow?)
##
# Eric Noulard:
# CPackRPM_handleAttrDirectiveProperly | master=0 next=1
The character set used in the REGEX here has errors in it: [A-Za-z\(\)-\,]
1) The comma does not need to be escaped in this character set
context, but \\ does if you mean to include the backslash character.
2) The hyphen, if meant to be matched is not matched here, but used as
a range separator from the \) to the \,
What's the intent of the change? To handle commas and hyphens, you
would add ,- at the end of the existing character set. If more
characters need to be matched, then add them, but keep the hyphen last
or make it first or escape it in order to match it here.
##
# James Bigler:
# topics/FindCUDA/Add-CUDA_HOST_COMPILER | master=0 next=1
Is CUDA_HOST_COMPILER a path to a directory or a file? It appears to
take on different values depending on which if branch you go through.
Is that true? Or should it always be a full path to the compiler?
Thanks all -- depending on the answers, we may take these next time we
merge, or they might need additional work first.
David
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Questions on staged topic branches
2012/9/4 David Cole david.c...@kitware.com:
If you are on the To line, please reply to this email, and answer
the questions below:
Brad and I have questions on these staged topic branches before we
consider them for merging to 'master'.
##
# Peter Kuemmel and Eric Noulard:
#cpack-stripping | master=0 next=1
This one should not be necessary. Can you tell us what problem it
fixes? The only valid install path that should ever go under DESTDIR
has to be an absolute path already anyways. So it will either start
with a / already, or a $ because it begins with
${CMAKE_INSTALL_PREFIX}... so this change is unnecessary, and in
fact harmful in the case where DESTDIR doesn't end with a / but the
install rule does begin with ${CMAKE_INSTALL_PREFIX}. (Or are we
misreading this somehow?)
##
# Eric Noulard:
# CPackRPM_handleAttrDirectiveProperly | master=0 next=1
The character set used in the REGEX here has errors in it: [A-Za-z\(\)-\,]
1) The comma does not need to be escaped in this character set
context, but \\ does if you mean to include the backslash character.
Only comma and hypen should be matched. Not backslash.
2) The hyphen, if meant to be matched is not matched here, but used as
a range separator from the \) to the \,
Right really sorry I overlooked that one.
What's the intent of the change? To handle commas and hyphens, you
would add ,- at the end of the existing character set. If more
characters need to be matched, then add them, but keep the hyphen last
or make it first or escape it in order to match it here.
I'll do that, but may be only this Week-End.
This corresponds to this bug
http://public.kitware.com/Bug/view.php?id=0013468
I did reopen it.
--
Erk
Le gouvernement représentatif n'est pas la démocratie --
http://www.le-message.org
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
