Re: [cmake-developers] Review request: FindTBB module
Hi all, I also came across these FindTBB modules while in need for one. As the more recent one from the OGRE project did not support MSVS 2015 yet, and also does not create import targets for a more convenient and “modern” CMake use of the TBB library targets, I wrote my own module. Features: - Makes use of COMPONENTS argument of find_package to look for the different TBB libraries. - Adds IMPORTED library targets with IMPORTED_* and INTERFACE_* properties set appropriately. - Considers TBB_ROOT as user hint and bases library search on root derived from TBB_INCLUDE_DIR otherwise. - Uses PATH_SUFFIXES instead of full search paths as done by OGRE FindTBB module to take advantage of CMake’s default search paths. - Checks TBB_VERSION against VERSION argument of find_package using find_package_handle_standard_args. This module is part of my CMake BASIS project which, among other things, consists of custom CMake functions and modules which attempt to standardise and reduce the CMake code needed by most projects (in research). These CMake BASIS Modules can be found on GitHub: https://github.com/schuhschuh/cmake-basis-modules. Would be great if someone could review the FindTBB module at https://github.com/schuhschuh/cmake-basis-modules/blob/develop/FindTBB.cmake and provide some feedback about what needs to be modified before it can be added to the official CMake Modules. Best, Andreas > On 12 Mar 2015, at 00:04, Klaim - Joël Lamotte wrote: > > > Hi, > > did you manage to improve over the DaxToolkit FindTBB module? > > Thanks for your time. > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: http://cmake.org/cmake/help/support.html > CMake Consulting: http://cmake.org/cmake/help/consulting.html > CMake Training Courses: http://cmake.org/cmake/help/training.html > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review request: FindTBB module
Hi, did you manage to improve over the DaxToolkit FindTBB module? Thanks for your time. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review request: FindTBB module
It looks a lot cleaner than the one at https://code.google.com/p/findtbb/ I'll rebase on it maybe. J. - Mail original - > De: "Robert Maynard" > À: "Julien Schueller" > Cc: "Brad King" , "CMake Developers" > > Envoyé: Jeudi 3 Avril 2014 15:51:46 > Objet: Re: [cmake-developers] Review request: FindTBB module > > Dax projects has a different FindTBB, that is based off the FindTBB > that the OGRE3D project wrote. > I quickly scanned it, and it looks to me that it has better msvc support. > > Here is that FindTBB: > https://github.com/Kitware/DaxToolkit/blob/master/CMake/FindTBB.cmake > > On Thu, Apr 3, 2014 at 9:38 AM, Julien Schueller > wrote: > > Not really, it looks that's there's a lot more to do to properly support > > windows across msvc versions. > > I'll try to look into it. > > > > J. > > > > > > ----- Mail original - > >> De: "Brad King" > >> À: cmake-developers@cmake.org > >> Envoyé: Jeudi 3 Avril 2014 15:33:11 > >> Objet: Re: [cmake-developers] Review request: FindTBB module > >> > >> On 04/03/2014 03:45 AM, Julien Schueller wrote: > >> > I'd like to maintain a module for intel tbb computing library: > >> > https://gist.github.com/jschueller/9949814 > >> > > >> > Could someone have a look ? > >> > >> There appears to be a dedicated project for a FindTBB module here: > >> > >> https://code.google.com/p/findtbb/ > >> > >> https://code.google.com/p/findtbb/source/browse/trunk/CMake/FindTBB/FindTBB.cmake > >> > >> Have you tried it? > >> > >> -Brad > >> > >> -- > >> > >> Powered by www.kitware.com > >> > >> Please keep messages on-topic and check the CMake FAQ at: > >> http://www.cmake.org/Wiki/CMake_FAQ > >> > >> Kitware offers various services to support the CMake community. For more > >> information on each offering, please visit: > >> > >> CMake Support: http://cmake.org/cmake/help/support.html > >> CMake Consulting: http://cmake.org/cmake/help/consulting.html > >> CMake Training Courses: http://cmake.org/cmake/help/training.html > >> > >> Visit other Kitware open-source projects at > >> http://www.kitware.com/opensource/opensource.html > >> > >> Follow this link to subscribe/unsubscribe: > >> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers > >> > > > > -- > > Julien Schueller > > Ingénieur d'Études > > 04 73 28 93 66 > > > > Phimeca Engineering > > Centre d'Affaires du Zénith > > 34 rue de Sarliève > > 63800 Cournon d'Auvergne > > www.phimeca.com > > -- > > > > Powered by www.kitware.com > > > > Please keep messages on-topic and check the CMake FAQ at: > > http://www.cmake.org/Wiki/CMake_FAQ > > > > Kitware offers various services to support the CMake community. For more > > information on each offering, please visit: > > > > CMake Support: http://cmake.org/cmake/help/support.html > > CMake Consulting: http://cmake.org/cmake/help/consulting.html > > CMake Training Courses: http://cmake.org/cmake/help/training.html > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers > -- Julien Schueller Ingénieur d'Études 04 73 28 93 66 Phimeca Engineering Centre d'Affaires du Zénith 34 rue de Sarliève 63800 Cournon d'Auvergne www.phimeca.com -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review request: FindTBB module
Dax projects has a different FindTBB, that is based off the FindTBB that the OGRE3D project wrote. I quickly scanned it, and it looks to me that it has better msvc support. Here is that FindTBB: https://github.com/Kitware/DaxToolkit/blob/master/CMake/FindTBB.cmake On Thu, Apr 3, 2014 at 9:38 AM, Julien Schueller wrote: > Not really, it looks that's there's a lot more to do to properly support > windows across msvc versions. > I'll try to look into it. > > J. > > > - Mail original - >> De: "Brad King" >> À: cmake-developers@cmake.org >> Envoyé: Jeudi 3 Avril 2014 15:33:11 >> Objet: Re: [cmake-developers] Review request: FindTBB module >> >> On 04/03/2014 03:45 AM, Julien Schueller wrote: >> > I'd like to maintain a module for intel tbb computing library: >> > https://gist.github.com/jschueller/9949814 >> > >> > Could someone have a look ? >> >> There appears to be a dedicated project for a FindTBB module here: >> >> https://code.google.com/p/findtbb/ >> >> https://code.google.com/p/findtbb/source/browse/trunk/CMake/FindTBB/FindTBB.cmake >> >> Have you tried it? >> >> -Brad >> >> -- >> >> Powered by www.kitware.com >> >> Please keep messages on-topic and check the CMake FAQ at: >> http://www.cmake.org/Wiki/CMake_FAQ >> >> Kitware offers various services to support the CMake community. For more >> information on each offering, please visit: >> >> CMake Support: http://cmake.org/cmake/help/support.html >> CMake Consulting: http://cmake.org/cmake/help/consulting.html >> CMake Training Courses: http://cmake.org/cmake/help/training.html >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers >> > > -- > Julien Schueller > Ingénieur d'Études > 04 73 28 93 66 > > Phimeca Engineering > Centre d'Affaires du Zénith > 34 rue de Sarliève > 63800 Cournon d'Auvergne > www.phimeca.com > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: http://cmake.org/cmake/help/support.html > CMake Consulting: http://cmake.org/cmake/help/consulting.html > CMake Training Courses: http://cmake.org/cmake/help/training.html > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review request: FindTBB module
Not really, it looks that's there's a lot more to do to properly support windows across msvc versions. I'll try to look into it. J. - Mail original - > De: "Brad King" > À: cmake-developers@cmake.org > Envoyé: Jeudi 3 Avril 2014 15:33:11 > Objet: Re: [cmake-developers] Review request: FindTBB module > > On 04/03/2014 03:45 AM, Julien Schueller wrote: > > I'd like to maintain a module for intel tbb computing library: > > https://gist.github.com/jschueller/9949814 > > > > Could someone have a look ? > > There appears to be a dedicated project for a FindTBB module here: > > https://code.google.com/p/findtbb/ > > https://code.google.com/p/findtbb/source/browse/trunk/CMake/FindTBB/FindTBB.cmake > > Have you tried it? > > -Brad > > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: http://cmake.org/cmake/help/support.html > CMake Consulting: http://cmake.org/cmake/help/consulting.html > CMake Training Courses: http://cmake.org/cmake/help/training.html > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers > -- Julien Schueller Ingénieur d'Études 04 73 28 93 66 Phimeca Engineering Centre d'Affaires du Zénith 34 rue de Sarliève 63800 Cournon d'Auvergne www.phimeca.com -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review request: FindTBB module
The one in VTK is a version from the findtbb project. On Thu, Apr 3, 2014 at 9:33 AM, Brad King wrote: > On 04/03/2014 03:45 AM, Julien Schueller wrote: >> I'd like to maintain a module for intel tbb computing library: >> https://gist.github.com/jschueller/9949814 >> >> Could someone have a look ? > > There appears to be a dedicated project for a FindTBB module here: > > https://code.google.com/p/findtbb/ > > https://code.google.com/p/findtbb/source/browse/trunk/CMake/FindTBB/FindTBB.cmake > > Have you tried it? > > -Brad > > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: http://cmake.org/cmake/help/support.html > CMake Consulting: http://cmake.org/cmake/help/consulting.html > CMake Training Courses: http://cmake.org/cmake/help/training.html > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review request: FindTBB module
On 04/03/2014 03:45 AM, Julien Schueller wrote: > I'd like to maintain a module for intel tbb computing library: > https://gist.github.com/jschueller/9949814 > > Could someone have a look ? There appears to be a dedicated project for a FindTBB module here: https://code.google.com/p/findtbb/ https://code.google.com/p/findtbb/source/browse/trunk/CMake/FindTBB/FindTBB.cmake Have you tried it? -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Review request: FindTBB module
Hi, I'd like to maintain a module for intel tbb computing library: https://gist.github.com/jschueller/9949814 Could someone have a look ? -- Julien -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
