Re: [cmake-developers] SelectLibraryConfigurations regression (Was: [CMake] CMake 2.8.10-rc2 ready for testing!)

2012-10-21 Thread Rolf Eike Beer
Rolf Eike Beer wrote:
> Brad King wrote:
> > On 10/19/2012 01:54 PM, Rolf Eike Beer wrote:
> > > Doh! Good catch, thanks. Will push it soonish.
> > 
> > I think our emails crossed.  I just pushed it.
> 
> Ok, feel free to ignore my branch then. I'll create a new topic to test this
> module soonish, would be good if that could be merged together with your
> fix.

I pushed my test branch now and found another bug: if both the _RELEASE and 
_DEBUG variable were set to the same value, SelectLibraryConfigurations was 
not setting *_LIBRARY and *_LIBRARIES at all. Fix is in my branch (test-
SelectLibraryConfigurations).

Eike
-- 

signature.asc
Description: This is a digitally signed message part.
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] SelectLibraryConfigurations regression (Was: [CMake] CMake 2.8.10-rc2 ready for testing!)

2012-10-21 Thread Rolf Eike Beer
Brad King wrote:
> On 10/19/2012 01:54 PM, Rolf Eike Beer wrote:
> > Doh! Good catch, thanks. Will push it soonish.
> 
> I think our emails crossed.  I just pushed it.

Ok, feel free to ignore my branch then. I'll create a new topic to test this 
module soonish, would be good if that could be merged together with your fix.

Eike
-- 

signature.asc
Description: This is a digitally signed message part.
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] SelectLibraryConfigurations regression (Was: [CMake] CMake 2.8.10-rc2 ready for testing!)

2012-10-19 Thread Rolf Eike Beer
Thomas Arcila wrote:
> Hi,
> 
> I have just found a regression in latest rc with
> SelectLibraryConfigurations module.
> 
> Expected output (cmake 2.6.9) from the attached test case is:
> 
> -- mylib_LIBRARY_RELEASE mylib
> -- mylib_LIBRARY_DEBUG mylibD
> -- mylib_LIBRARIES optimized;mylib;debug;mylibD
> 
> while cmake 2.6.10-rc2 output is:
> 
> -- mylib_LIBRARY_RELEASE mylib
> -- mylib_LIBRARY_DEBUG mylibD
> -- mylib_LIBRARIES
> optimized;LISTS;optimized;mylib_LIBRARY_RELEASE;debug;LISTS;debug;mylib_LIBR
> ARY_DEBUG
> 
> You will find attached a patch fixing the issue.

Doh! Good catch, thanks. Will push it soonish.

Eike
-- 

signature.asc
Description: This is a digitally signed message part.
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] SelectLibraryConfigurations regression (Was: [CMake] CMake 2.8.10-rc2 ready for testing!)

2012-10-19 Thread Brad King
On 10/19/2012 12:17 PM, Thomas Arcila wrote:
> I have just found a regression in latest rc with SelectLibraryConfigurations 
> module.
> 
> You will find attached a patch fixing the issue.

Applied:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1cd2ec10

Thanks!
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


[cmake-developers] SelectLibraryConfigurations regression (Was: [CMake] CMake 2.8.10-rc2 ready for testing!)

2012-10-19 Thread Thomas Arcila
Hi,

I have just found a regression in latest rc with
SelectLibraryConfigurations module.

Expected output (cmake 2.6.9) from the attached test case is:

-- mylib_LIBRARY_RELEASE mylib
-- mylib_LIBRARY_DEBUG mylibD
-- mylib_LIBRARIES optimized;mylib;debug;mylibD

while cmake 2.6.10-rc2 output is:

-- mylib_LIBRARY_RELEASE mylib
-- mylib_LIBRARY_DEBUG mylibD
-- mylib_LIBRARIES
optimized;LISTS;optimized;mylib_LIBRARY_RELEASE;debug;LISTS;debug;mylib_LIBRARY_DEBUG

You will find attached a patch fixing the issue.

Regards,
Thomas



2012/10/19 David Cole 

> The CMake 2.8.10 release candidate stream continues! You can find the
> source and binaries here:
>
>   http://www.cmake.org/files/v2.8/?C=M;O=D
>
> This email is also available as blog posts:
>
>   http://www.kitware.com/blog/home/post/401
>   http://cmake.blogspot.com/2012/10/cmake-2810-rc2-ready-for-testing.html
>
> Some of the notable changes in this release are:
>
>  - file(DOWNLOAD now handles "https" URLs -- the pre-built binaries
> available from Kitware link to OpenSSL
>  - support for the latest available versions of Visual Studio (11 /
> 2012) and Xcode (4.3, 4.4, 4.5, developer previews)
>  - uniform compiler "id" and version number variables available for
> nearly all known compilers and platforms
>  - new way to arrange exported targets that depend on other targets
> into "export sets"
>  - new generator expressions
>  - generator expressions available in more contexts, namely in the
> INCLUDE_DIRECTORIES and COMPILE_DEFINITIONS target properties
>  - new target properties for PDB_OUTPUT_DIRECTORY and PDB_NAME,
> implemented for Visual Studio 7 and up
>  - and, as always, various minor bug fixes
>
> The bug tracker change log page for this version is at:
>
>   http://public.kitware.com/Bug/changelog_page.php?version_id=100
>
> Following is the complete list of changes in this rc since the first
> rc. Please try this version of CMake on your projects and report any
> issues to the list or the bug tracker. This release candidate will
> become the final release for 2.8.10 by the end of October unless
> somebody finds and reports a serious issue that needs to be fixed.
>
>
>
> Thanks!
>
>
>
> -Dave
>
>
>
> Changes in CMake 2.8.10-rc2 (since 2.8.10-rc1)
> --
> Alex Neundorf (2):
>   Document CMAKE_FIND_PACKAGE_NAME
>   Automoc: fix #13572: issue with symbolic links
>
> Brad King (4):
>   cmCTestSVN: Fix compilation with Sun CC 5.1
>   if: Document that plain 'NOTFOUND' is a false constant
>   string: Clarify regex documentation of '-' behavior
>   FortranCInterface: Pass all flags to VERIFY project (#13579)
>
> David Cole (1):
>   NSIS: Fix incorrect uninstall registry key name (#13578)
>
> Eric NOULARD (3):
>   CPACK_XX_ON_ABSOLUTE_INSTALL_DESTINATION is now properly checked
> for ON/OFF
>   Document CPACK_COMPONENT_INCLUDE_TOPLEVEL_DIRECTORY and fix some
> typo.
>   Make CPACK_SET_DESTDIR work with archive generator +
> component-based packaging
>
> Jean-Christophe Fillion-Robin (1):
>   CTest: Ensure CTEST_USE_LAUNCHERS behaves nicely in Superbuild setup
>
> Pere Nubiola i Radigales (1):
>   Find PostgreSQL headers on Debian
>
> Peter Kümmel (4):
>   Ninja: also set OBJECT_DIR when compiling
>   Ninja: don't pollute current dir when using gui (#13495)
>   Ninja: implicit dependency for custom command files
>   Fix regression: write compile definitions if any
>
> Philip Lowman (4):
>   FindGTK2: Rollback lib64 changes which broke header file finding
>   FindGTK2: #12049 fix detection of header files on multiarch systems
>   FindGTK2: #12596 Missing paths for FindGTK2 on NetBSD
>   FindGTK2: Update local changelog
>
> Rolf Eike Beer (6):
>   CTest: fix usage of memory checker with spaces in path
>   CTest: fix pre and post test commands with spaces
>   CTest: add tests that simulate memcheck runs
>   CTest: improve memory checker type detection
>   CTest: add a test for CTEST_CUSTOM_MEMCHECK_IGNORE
>   CTest: add a check with a quoted memory checker
>
> Stephen Kelly (18):
>   GenEx: It is not an error to specify an empty parameter
>   GenEx: Return after error reported.
>   GenEx: Report actual target name not found, not "0" each time.
>   GenEx: Parse comma after colon tokens specially
>   GenEx: Validate target and property names.
>   GenEx: Ensure that the empty CONFIGURATION can be used conditionally.
>   GenEx: Add test for $ with empty parameter.
>   GenEx: Add tests for "0" and "1" expressions with literal commas.
>   GenEx: Don't use std::vector::at(int).
>   Attempt to fix the compile of cmake on Sun CC.
>   GenEx: Parse colon after arguments separator colon specially.
>   GenEx: Test the use of generator expressions to generate lists.
>   GenEx: Fix termination bugs in generator expression parser.
>   GenEx: Break if there are no more