Re: [cmake-developers] Suggest if function has lte gte operators

[Harry Mallon]

That is completely fair. Perhaps a bit of Friday brain from me. It still could 
reduce complexity if you are trying to do something more complicated.

In my opinion A is easier to read than B.

A: if ( $1 STRGREATER_EQ $2 AND $3 STRLESS $4 AND $5 STRLESS_EQ $6 )
B: if ( NOT $1 STRLESS $2 AND $3 STRLESS $4 AND NOT $5 STRGREATER $6)

H


Harry Mallon
CODEX | Software Engineer
60 Poland Street | London | England | W1F 7NT
E ha...@codexdigital.com | T +44 203 7000 989
> On 8 Apr 2016, at 15:42, Ben Boeckel  wrote:
>
> On Fri, Apr 08, 2016 at 14:24:08 +, Harry Mallon wrote:
>> CMake's "if" functionality is missing greater than or equal to and
>> less than or equal to. This change could be tweaked and added to
>> provide this functionality to avoid things like "if(VERSION_STRING
>> VERSION_GREATER "4.8.0" OR VERSION_STRING VERSION_EQUAL "4.8.0")".
>
> This can also be done as:
>
>if (NOT VERSION_STRING VERSION_LESS "4.8.0")
>
> I'm ambivalent on the idea of new operators. Documentation for this
> pattern would likely help.
>
> --Ben
>

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Suggest if function has lte gte operators

[Brad King]

On 04/08/2016 10:24 AM, Harry Mallon wrote:
> "if(VERSION_STRING VERSION_GREATER "4.8.0" OR VERSION_STRING VERSION_EQUAL 
> "4.8.0")".

As others have said this can be done with

if(NOT version VERSION_LESS 4.8.0)

> Commit on github:
> https://github.com/hm1992/CMake/commit/75b318f8809ae71685cad068cd2e8ce9f19fb28a

I don't think we have a strong use case for the proposed operators,
but I've taken a small cleanup from that commit:

 cmConditionEvaluator: Use pre-allocated keywords in more places
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=aff4a5fa

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Suggest if function has lte gte operators

[Ben Boeckel]

On Fri, Apr 08, 2016 at 14:24:08 +, Harry Mallon wrote:
> CMake's "if" functionality is missing greater than or equal to and
> less than or equal to. This change could be tweaked and added to
> provide this functionality to avoid things like "if(VERSION_STRING
> VERSION_GREATER "4.8.0" OR VERSION_STRING VERSION_EQUAL "4.8.0")".

This can also be done as:

if (NOT VERSION_STRING VERSION_LESS "4.8.0")

I'm ambivalent on the idea of new operators. Documentation for this
pattern would likely help.

--Ben
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Suggest if function has lte gte operators

[Rolf Eike Beer]

Am Freitag, 8. April 2016, 14:24:08 schrieb Harry Mallon:
> CMake's "if" functionality is missing greater than or equal to and less than
> or equal to. This change could be tweaked and added to provide this
> functionality to avoid things like "if(VERSION_STRING VERSION_GREATER
> "4.8.0" OR VERSION_STRING VERSION_EQUAL "4.8.0")".
> 
> Commit on github:
> https://github.com/hm1992/CMake/commit/75b318f8809ae71685cad068cd2e8ce9f19fb
> 28a
> 
> Would this be of interest for merging? I don't really have the time to do
> extensive testing on it at the moment.

The common way is to use the power of not:

LTE -> NOT GE
GTE -> NOT LE

Greetings,

Eike

signature.asc
Description: This is a digitally signed message part.
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] Suggest if function has lte gte operators

[Harry Mallon]

CMake's "if" functionality is missing greater than or equal to and less than or 
equal to. This change could be tweaked and added to provide this functionality 
to avoid things like "if(VERSION_STRING VERSION_GREATER "4.8.0" OR 
VERSION_STRING VERSION_EQUAL "4.8.0")".

Commit on github:
https://github.com/hm1992/CMake/commit/75b318f8809ae71685cad068cd2e8ce9f19fb28a

Would this be of interest for merging? I don't really have the time to do 
extensive testing on it at the moment.

Harry

Harry Mallon

CODEX | Software Engineer

60 Poland Street | London | England | W1F 7NT

E ha...@codexdigital.com | T +44 203 7000 
989

Website | Facebook 
| Twitter

[http://www.codexdigital.com/?action=asset=83095F5A-2233-47F5-9598-19228D7E37AE]
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers