Re: [cmake-developers] Xcode COMPILE_OPTIONS escaping

2013-06-27 Thread Stephen Kelly
Brad King wrote:

> Steve,
> 
> On 6/27/2013 10:34 AM, Brad King wrote:
>> Okay, this problem is a bit deeper than I thought.
>> I'm working on a topic to resolve it.
>> 
>> For now I reverted the compiler-version-genex topic to make room.
>> I will try to get my topic ready today.
> 
> I've merged a 'refactor-compile-options' to next that should take
> care of this.  Once it is clean on the dashboard please rebase
> your compiler-version-genex topic on it and resolve conflicts in
> the CompileOptions test.

Great, thanks for that!

Steve.


--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] Xcode COMPILE_OPTIONS escaping

2013-06-27 Thread Brad King
Steve,

On 6/27/2013 10:34 AM, Brad King wrote:
> Okay, this problem is a bit deeper than I thought.
> I'm working on a topic to resolve it.
> 
> For now I reverted the compiler-version-genex topic to make room.
> I will try to get my topic ready today.

I've merged a 'refactor-compile-options' to next that should take
care of this.  Once it is clean on the dashboard please rebase
your compiler-version-genex topic on it and resolve conflicts in
the CompileOptions test.

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] Xcode COMPILE_OPTIONS escaping

2013-06-27 Thread Brad King
On 06/27/2013 03:27 AM, Stephen Kelly wrote:
> Brad King wrote:
> 
>> Part of the value of COMPILE_OPTIONS is supposed to be that it
>> takes a ;-list of options and escapes each one appropriately.
>> You'll have to go back and fix up the generators or cmTarget's
>> GetCompileOptions method to use lg->EscapeForShell when appending
>> each flag.
> 
> I did this, but it does not seem to have had any effect.

Okay, this problem is a bit deeper than I thought.
I'm working on a topic to resolve it.

For now I reverted the compiler-version-genex topic to make room.
I will try to get my topic ready today.

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers