Re: [cmake-developers] compiler version variables

2012-02-24 Thread Brad King

On 2/24/2012 1:15 PM, Rolf Eike Beer wrote:

Brad King wrote:

FYI, this variable is not set by all generators yet.  It is computed as


Ok, but they should work for GCC and Intel, no? And this stuff as part of
CMake qualifies as internal use? So I have nothing to change?


Sure it is internal use but I'm not sure whether it will always work.
Older Xcode versions use GCC under the hood, and this will not detect
the version of that GCC.  However in your particular use case it looks
like at worst the warning will be missing, and only on very old versions,
so I think it is okay.

-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] compiler version variables

2012-02-24 Thread Rolf Eike Beer
Brad King wrote:
> On 2/24/2012 11:50 AM, Rolf Eike Beer wrote:
> > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c28e2769482c12da53a3c01
> > ea45f9ae6cdc1de34 commit c28e2769482c12da53a3c01ea45f9ae6cdc1de34
> > Author: Rolf Eike Beer
> > AuthorDate: Fri Feb 24 17:48:02 2012 +0100
> > Commit: Rolf Eike Beer
> > CommitDate: Fri Feb 24 17:48:02 2012 +0100
> > 
> >  GenerateExportHeader: improve compiler identification
> >  
> >  Use CMAKE__COMPILER_VERSION instead of calling the compiler.
> >  This macro predates those useful variables. This also fixes the
> >  issue that g++ version detection was not working if C language was
> >  not enabled.
> 
> FYI, this variable is not set by all generators yet.  It is computed as
> part of the compiler identification step, but that doesn't happen for
> VS and Xcode.  For the other generators the compiler version will need
> to be detected as part of the ABI determination which always runs.  I
> haven't had time yet to add that, so currently the documentation for the
> variables just says that they are for internal use.  Note that this is
> also the case for CMAKE__COMPILER_ID.

Ok, but they should work for GCC and Intel, no? And this stuff as part of 
CMake qualifies as internal use? So I have nothing to change?

Eike
-- 

signature.asc
Description: This is a digitally signed message part.
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

[cmake-developers] compiler version variables

2012-02-24 Thread Brad King

On 2/24/2012 11:50 AM, Rolf Eike Beer wrote:

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c28e2769482c12da53a3c01ea45f9ae6cdc1de34
commit c28e2769482c12da53a3c01ea45f9ae6cdc1de34
Author: Rolf Eike Beer
AuthorDate: Fri Feb 24 17:48:02 2012 +0100
Commit: Rolf Eike Beer
CommitDate: Fri Feb 24 17:48:02 2012 +0100

 GenerateExportHeader: improve compiler identification

 Use CMAKE__COMPILER_VERSION instead of calling the compiler. This 
macro
 predates those useful variables. This also fixes the issue that g++ version
 detection was not working if C language was not enabled.


FYI, this variable is not set by all generators yet.  It is computed as
part of the compiler identification step, but that doesn't happen for
VS and Xcode.  For the other generators the compiler version will need
to be detected as part of the ABI determination which always runs.  I
haven't had time yet to add that, so currently the documentation for the
variables just says that they are for internal use.  Note that this is
also the case for CMAKE__COMPILER_ID.

-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers