Re: [cmake-developers] visual-studio-preprocessor-undefine fix for /U problems
Interesting, I’ll revisit it. On Feb 17, 2014, at 8:43 AM, Brad King wrote: > On 02/14/2014 04:24 PM, Steve Wilson wrote: >> new method OutputDefinitionsByTag and adds an argument that lets you specify >> the tag.I also fixed the test case. > > Thanks. I don't see in the new changes where it actually uses the > parsed Undefines member. It looks like it just adds the main > definitions with both UndefinePreprocessorDefintions and > PreprocessorDefintions. Shouldn't OutputDefinitionsByTag take > an argument telling it what list of definitions to use, and then > used as an implementation detail of OutputPreprocessorDefinitions > and OutputUndefinePreprocessorDefinitions? > > -Brad > signature.asc Description: Message signed with OpenPGP using GPGMail -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] visual-studio-preprocessor-undefine fix for /U problems
On 02/14/2014 04:24 PM, Steve Wilson wrote: > new method OutputDefinitionsByTag and adds an argument that lets you specify > the tag.I also fixed the test case. Thanks. I don't see in the new changes where it actually uses the parsed Undefines member. It looks like it just adds the main definitions with both UndefinePreprocessorDefintions and PreprocessorDefintions. Shouldn't OutputDefinitionsByTag take an argument telling it what list of definitions to use, and then used as an implementation detail of OutputPreprocessorDefinitions and OutputUndefinePreprocessorDefinitions? -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] visual-studio-preprocessor-undefine fix for /U problems
I pushed a updated version of the topic branch to stage. It refactors the OutputPreprocessorDefinitions method into a a new method OutputDefinitionsByTag and adds an argument that lets you specify the tag.I also fixed the test case. SteveW On Feb 14, 2014, at 11:26 AM, Brad King wrote: > On 2/13/2014 7:33 PM, Steve Wilson wrote: >> The topic is visual-studio-preprocessor-undefine. > > Thanks. The method > > cmVisualStudioGeneratorOptions > ::OutputUndefinePreprocessorDefinitions > > appears to duplicate a lot of code from > > cmVisualStudioGeneratorOptions > ::OutputPreprocessorDefinitions > > Please factor out and parameterize the common pieces to > avoid the duplication. > > Also, the test case appears to undef a macro in a specific > source file and test that it is undefined, but never defines > the macro for the whole target so of course it will never > be defined and the test will always pass. > > Thanks, > -Brad > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers signature.asc Description: Message signed with OpenPGP using GPGMail -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] visual-studio-preprocessor-undefine fix for /U problems
On 2/14/2014 3:48 PM, Steve Wilson wrote: > In the refactor of these functions, would you like to see that > refactor as a separate commit or merged in with the commit for > the other changes? I have a slight preference for a separate commit that first factors the common part out and calls it from the one site, and then the main commit that adds the new call site. I wouldn't reject it (for that reason) either way though. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] visual-studio-preprocessor-undefine fix for /U problems
On Feb 14, 2014, at 11:26 AM, Brad King wrote: > On 2/13/2014 7:33 PM, Steve Wilson wrote: >> The topic is visual-studio-preprocessor-undefine. > > Thanks. The method > > cmVisualStudioGeneratorOptions > ::OutputUndefinePreprocessorDefinitions > > appears to duplicate a lot of code from > > cmVisualStudioGeneratorOptions > ::OutputPreprocessorDefinitions In the refactor of these functions, would you like to see that refactor as a separate commit or merged in with the commit for the other changes? SteveW signature.asc Description: Message signed with OpenPGP using GPGMail -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] visual-studio-preprocessor-undefine fix for /U problems
Will do. On Feb 14, 2014, at 11:26 AM, Brad King wrote: > On 2/13/2014 7:33 PM, Steve Wilson wrote: >> The topic is visual-studio-preprocessor-undefine. > > Thanks. The method > > cmVisualStudioGeneratorOptions > ::OutputUndefinePreprocessorDefinitions > > appears to duplicate a lot of code from > > cmVisualStudioGeneratorOptions > ::OutputPreprocessorDefinitions > > Please factor out and parameterize the common pieces to > avoid the duplication. > > Also, the test case appears to undef a macro in a specific > source file and test that it is undefined, but never defines > the macro for the whole target so of course it will never > be defined and the test will always pass. > > Thanks, > -Brad > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers signature.asc Description: Message signed with OpenPGP using GPGMail -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] visual-studio-preprocessor-undefine fix for /U problems
On 2/13/2014 7:33 PM, Steve Wilson wrote: > The topic is visual-studio-preprocessor-undefine. Thanks. The method cmVisualStudioGeneratorOptions ::OutputUndefinePreprocessorDefinitions appears to duplicate a lot of code from cmVisualStudioGeneratorOptions ::OutputPreprocessorDefinitions Please factor out and parameterize the common pieces to avoid the duplication. Also, the test case appears to undef a macro in a specific source file and test that it is undefined, but never defines the macro for the whole target so of course it will never be defined and the test will always pass. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] visual-studio-preprocessor-undefine fix for /U problems
I just pushed a tiny topic branch that fixes problems in the Visual Studio generators where the generators will squash the use of /U in compile flags. The change allows /U to go through correctly to the compiler command line. The topic is visual-studio-preprocessor-undefine. SteveW signature.asc Description: Message signed with OpenPGP using GPGMail -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
