Re: [cmake-developers] [CMake] please review: fix UseJava.cmake to support dependent jars

2013-03-18 Thread Brad King
On 03/17/2013 09:14 AM, Nicolas Desprès wrote:
 He said that the project is not broken by the new patches.

Great, thanks for taking the time to report back!

-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] [CMake] please review: fix UseJava.cmake to support dependent jars

2013-03-17 Thread Nicolas Desprès
On Sun, Mar 17, 2013 at 10:49 AM, Nicolas Desprès nicolas.desp...@gmail.com
 wrote:

 On Thu, Mar 14, 2013 at 3:57 PM, Brad King brad.k...@kitware.com wrote:

 On 03/14/2013 10:47 AM, Matthew Woehlke wrote:
  This is now pushed to stage/fix-java-jar-depends. If someone
  knowledgeable could have a look, that would be much appreciated.

 Andreas, Nicholas?

 Sorry for the delayed response, but I have no longer that much time to
 spent on CMake, unfortunately.

 I have reviewed the patches and they look good to m. I cannot test them
 because I am no longer working on the Java project I used to do my previous
 patches to this module. I know someone who is still working on so I have
 asked him to give it a try.

He said that the project is not broken by the new patches.

-- 
Nicolas Desprès
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [CMake] please review: fix UseJava.cmake to support dependent jars

2013-03-14 Thread Brad King
On 03/14/2013 10:47 AM, Matthew Woehlke wrote:
 This is now pushed to stage/fix-java-jar-depends. If someone 
 knowledgeable could have a look, that would be much appreciated.

Andreas, Nicholas?

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] [CMake] please review: fix UseJava.cmake to support dependent jars

2013-03-14 Thread Andreas Schneider
On Thursday 14 March 2013 10:57:10 Brad King wrote:
 On 03/14/2013 10:47 AM, Matthew Woehlke wrote:
  This is now pushed to stage/fix-java-jar-depends. If someone
  knowledgeable could have a look, that would be much appreciated.
 
 Andreas, Nicholas?

Hi Brad,

thanks for the mail. I've reviewed the patches and they look fine for me. I'm 
sorry that I don't have the time to test them right now.


Cheers,


-- andreas

-- 
Andreas Schneider   GPG-ID: F33E3FC6
www.cryptomilk.orga...@cryptomilk.org

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers