Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake
We use it for our game engine Android development, and I must say this is definitively super awesome. Looking forward for these improvements! Thanks a lot for all this work. -Original Message- From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of Mikhail Filimonov Sent: Wednesday, July 15, 2015 10:14 AM To: Brad King Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake Thanks, Brad. As usual, we're open for community feedback on Nsight Tegra project generator. -Mikhail -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: 15 июля 2015 г. 16:10 To: Mikhail Filimonov Cc: cmake-developers@cmake.org; Dmitry Polyanitsa Subject: Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake On 07/13/2015 12:44 PM, Mikhail Filimonov wrote: I've improved the patch according to the Brad's and Dmitry's comments - namely: 1. Improved the documentation for a few target properties. 2. Removed the explicit toolchain file for Nsight Tegra generator test. 3. Improved the generator heuristics for NsightTegraProjectRevisionNumber attribute. Thanks. I've applied the patch with minor tweaks: VS: Add more Nsight Tegra generator Android property settings http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8c0afaf4 -Brad --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake
Thanks, Brad. As usual, we're open for community feedback on Nsight Tegra project generator. -Mikhail -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: 15 июля 2015 г. 16:10 To: Mikhail Filimonov Cc: cmake-developers@cmake.org; Dmitry Polyanitsa Subject: Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake On 07/13/2015 12:44 PM, Mikhail Filimonov wrote: I've improved the patch according to the Brad's and Dmitry's comments - namely: 1. Improved the documentation for a few target properties. 2. Removed the explicit toolchain file for Nsight Tegra generator test. 3. Improved the generator heuristics for NsightTegraProjectRevisionNumber attribute. Thanks. I've applied the patch with minor tweaks: VS: Add more Nsight Tegra generator Android property settings http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8c0afaf4 -Brad --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake
On 07/13/2015 12:44 PM, Mikhail Filimonov wrote: I've improved the patch according to the Brad's and Dmitry's comments - namely: 1. Improved the documentation for a few target properties. 2. Removed the explicit toolchain file for Nsight Tegra generator test. 3. Improved the generator heuristics for NsightTegraProjectRevisionNumber attribute. Thanks. I've applied the patch with minor tweaks: VS: Add more Nsight Tegra generator Android property settings http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8c0afaf4 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake
I've improved the patch according to the Brad's and Dmitry's comments - namely: 1. Improved the documentation for a few target properties. 2. Removed the explicit toolchain file for Nsight Tegra generator test. 3. Improved the generator heuristics for NsightTegraProjectRevisionNumber attribute. Thanks, -Mikhail -Original Message- From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of Mikhail Filimonov Sent: 9 июля 2015 г. 18:43 To: Brad King Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake Thanks for your feedback, Brad From: Brad King [mailto:brad.k...@kitware.com] Sent: 9 июля 2015 г. 18:02 We'd like to keep testing the default behavior without an explicit toolchain file. Also we need to be independent of the toolsets that happen to be available on the system where the test runs, so we should avoid hard-coding a toolset name if possible. Is this part of the patch needed to test everything else? If so, please look at adding more test cases for the new combinations (which can just be more builds of the same test source tree). That's more like a demonstration sample that will show the developers how the various Nsight Tegra project properties could be defined via the various CMake properties even if not directly related to Android - i.e. C_STANDARD and CMAKE_GENERATOR_TOOLSET Currently where's no samples directory in CMake source tree - so I've slightly reworked the existing test case. Maybe you could propose a better way to deliver that sample? Thanks, -Mikhail --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ExtendedNsightTegraSupport2.patch Description: ExtendedNsightTegraSupport2.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake
I've reviewed the patch and tried it locally - looks good. -Dmitry -Original Message- From: Mikhail Filimonov Sent: Monday, July 13, 2015 7:45 PM To: cmake-developers@cmake.org Subject: RE: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake I've improved the patch according to the Brad's and Dmitry's comments - namely: 1. Improved the documentation for a few target properties. 2. Removed the explicit toolchain file for Nsight Tegra generator test. 3. Improved the generator heuristics for NsightTegraProjectRevisionNumber attribute. Thanks, -Mikhail -Original Message- From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of Mikhail Filimonov Sent: 9 июля 2015 г. 18:43 To: Brad King Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake Thanks for your feedback, Brad From: Brad King [mailto:brad.k...@kitware.com] Sent: 9 июля 2015 г. 18:02 We'd like to keep testing the default behavior without an explicit toolchain file. Also we need to be independent of the toolsets that happen to be available on the system where the test runs, so we should avoid hard-coding a toolset name if possible. Is this part of the patch needed to test everything else? If so, please look at adding more test cases for the new combinations (which can just be more builds of the same test source tree). That's more like a demonstration sample that will show the developers how the various Nsight Tegra project properties could be defined via the various CMake properties even if not directly related to Android - i.e. C_STANDARD and CMAKE_GENERATOR_TOOLSET Currently where's no samples directory in CMake source tree - so I've slightly reworked the existing test case. Maybe you could propose a better way to deliver that sample? Thanks, -Mikhail --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake
On 07/08/2015 11:21 AM, Mikhail Filimonov wrote:
I've extended the Nsight Tegra project generator in CMake and added a bunch
of properties with the backing variables to fine-tune the generated projects.
Thanks! Here are some comments.
---build-options -DCMAKE_SYSTEM_NAME=Android
+--build-options -DCMAKE_SYSTEM_NAME=Android -DCMAKE_TOOLCHAIN_FILE=
${CMake_SOURCE_DIR}/Tests/VSNsightTegra/NsightTegraToolchain.cmake
[snip]
+# CMake toolchain file used for the generation of Nsight Tegra project files
+
+set(CMAKE_GENERATOR_TOOLSET clang-3.5)
+set(CMAKE_SYSTEM_NAME Android)
We'd like to keep testing the default behavior without an explicit
toolchain file. Also we need to be independent of the toolsets
that happen to be available on the system where the test runs,
so we should avoid hard-coding a toolset name if possible. Is
this part of the patch needed to test everything else? If so,
please look at adding more test cases for the new combinations
(which can just be more builds of the same test source tree).
+set_property(TARGET twolib-second APPEND PROPERTY
ANDROID_NATIVE_LIB_DIRECTORIES c:\\wrk c:\\wrk\\cmake)
The test should not name directories outside control of the test
suite. Please name directories in the test source tree or something.
Also, in Source/* C++ sources please wrap lines to keep them = 79
columns.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
