Re: [cmake-developers] [patch] treat .m files as c, not c++
>> I'll look at integrating the change. > > I've applied the patch here: > > Treat .m files consistently as C across all generators > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=95cdf132 > > with more detail in the commit message. thanks a lot! tim -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [patch] treat .m files as c, not c++
On 03/20/2014 11:38 AM, Steve Wilson wrote: > Took me a bit longer than I expected, but you can find the > 'objective-c-support' topic at: > > https://github.com/swwilso1/CMake.git Great, thanks. I encourage others to look at the topic and the discussion thread I linked earlier in this thread. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [patch] treat .m files as c, not c++
Took me a bit longer than I expected, but you can find the 'objective-c-support' topic at: https://github.com/swwilso1/CMake.git On Mar 19, 2014, at 11:55 AM, Steve Wilson wrote: > On Mar 19, 2014, at 11:09 AM, Brad King wrote: > >> On 03/19/2014 12:50 PM, Tim Blechmann wrote: >>> obj-c is a superset of c, while obj-c++ is a superset of obj-c >>> >>> this patch corrects this behavior. >> >> The incorrect behavior is left from the earliest days of CMake. >> Fixing this outright will change existing build behavior. We >> would have to do this with a CMake Policy. However, Steve Wilson >> is working on first-class Objective C and Objective C++ support: >> >> http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/9371 >> >> That will resolve this in a compatible way by allowing projects >> to enable OBJC and/or OBJCXX languages to get .m and .mm sources >> compiled properly. >> >> Steve, do you have the work-in-progress topic published somewhere? > > Not at the moment, but I’ll work on making the topic available on github > before the end of the day. > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: http://cmake.org/cmake/help/support.html > CMake Consulting: http://cmake.org/cmake/help/consulting.html > CMake Training Courses: http://cmake.org/cmake/help/training.html > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers signature.asc Description: Message signed with OpenPGP using GPGMail -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [patch] treat .m files as c, not c++
On 03/19/2014 03:58 PM, Brad King wrote: > I'll look at integrating the change. I've applied the patch here: Treat .m files consistently as C across all generators http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=95cdf132 with more detail in the commit message. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [patch] treat .m files as c, not c++
On 03/19/2014 01:29 PM, Tim Blechmann wrote: > emulating old bugs is a nice thing, but then maybe the inconsistency between > xcode and make/ninja generators should be be documented or the xcode > generator should emulate wrong behavior to be consistent with make/ninja? On second thought, since the Xcode generator already does this correctly I think it is better to just fix the inconsistency. I doubt anyone is intentionally depending on compiling .m sources with the C++ compiler. If it comes up we can add the CMake Policy for compatibility later. It looks like this was reported and "fixed" in 2008: http://www.cmake.org/Bug/view.php?id=7045 but the fix was not correct because the generators do not use the cmSystemTools::GetFileFormat hard-coded table anymore. I'll look at integrating the change. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [patch] treat .m files as c, not c++
On Mar 19, 2014, at 11:09 AM, Brad King wrote: > On 03/19/2014 12:50 PM, Tim Blechmann wrote: >> obj-c is a superset of c, while obj-c++ is a superset of obj-c >> >> this patch corrects this behavior. > > The incorrect behavior is left from the earliest days of CMake. > Fixing this outright will change existing build behavior. We > would have to do this with a CMake Policy. However, Steve Wilson > is working on first-class Objective C and Objective C++ support: > > http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/9371 > > That will resolve this in a compatible way by allowing projects > to enable OBJC and/or OBJCXX languages to get .m and .mm sources > compiled properly. > > Steve, do you have the work-in-progress topic published somewhere? Not at the moment, but I’ll work on making the topic available on github before the end of the day. signature.asc Description: Message signed with OpenPGP using GPGMail -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [patch] treat .m files as c, not c++
On 03/19/2014 12:50 PM, Tim Blechmann wrote: > obj-c is a superset of c, while obj-c++ is a superset of obj-c > > this patch corrects this behavior. The incorrect behavior is left from the earliest days of CMake. Fixing this outright will change existing build behavior. We would have to do this with a CMake Policy. However, Steve Wilson is working on first-class Objective C and Objective C++ support: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/9371 That will resolve this in a compatible way by allowing projects to enable OBJC and/or OBJCXX languages to get .m and .mm sources compiled properly. Steve, do you have the work-in-progress topic published somewhere? Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
