Re: [cmake-developers] Please apply patch from https://github.com/hunger/CMake/commits/for-upstream to master

[Daniel Pfeifer]

On Wed, Jun 29, 2016 at 10:17 AM, Tobias Hunger  wrote:
> On Mi, 2016-06-29 at 09:54 +0200, Rolf Eike Beer wrote:
>> Am 2016-06-29 09:35, schrieb Tobias Hunger:
>> > Hello Brad,
>> >
>> > I currently get more than 2000 warnings when building cmake master, all
>> > about
>> > missing overrides.
>> >
>> > Could you please take the fix warning patch from
>> > https://github.com/hunger/CMake/commits/for-upstream and apply it to
>> > master?
>> > That fixes all those pesky override warnings.
>>
>> This should be CM_OVERRIDE.
>
> Changed.

Thanks. I merged it to next.
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Please apply patch from https://github.com/hunger/CMake/commits/for-upstream to master

[Tobias Hunger]

On Mi, 2016-06-29 at 09:54 +0200, Rolf Eike Beer wrote:
> Am 2016-06-29 09:35, schrieb Tobias Hunger:
> > Hello Brad,
> > 
> > I currently get more than 2000 warnings when building cmake master, all 
> > about
> > missing overrides.
> > 
> > Could you please take the fix warning patch from
> > https://github.com/hunger/CMake/commits/for-upstream and apply it to 
> > master?
> > That fixes all those pesky override warnings.
> 
> This should be CM_OVERRIDE.

Changed.

Best Regards,
Tobias

-- 
Tobias Hunger, Senior Software Engineer | The Qt Company
The Qt Company GmbH, Rudower Chaussee 13, D-12489 Berlin
Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho. Sitz der
Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Please apply patch from https://github.com/hunger/CMake/commits/for-upstream to master

[Rolf Eike Beer]

Am 2016-06-29 09:35, schrieb Tobias Hunger:

Hello Brad,

I currently get more than 2000 warnings when building cmake master, all 
about

missing overrides.

Could you please take the fix warning patch from
https://github.com/hunger/CMake/commits/for-upstream and apply it to 
master?

That fixes all those pesky override warnings.


This should be CM_OVERRIDE.

Eike
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers