Re: [cmake-developers] Some trivial patches
On Thu, Jun 2, 2016 at 11:15 AM, Tobias Hunger wrote: > On Mi, 2016-06-01 at 11:18 -0400, Brad King wrote: >> On 06/01/2016 05:04 AM, Tobias Hunger wrote: >> > Attached you will find a couple of really small changes that add const to a >> > method and fix a couple of typos in comments. Trivial stuff. >> >> Thanks. I've applied the changes: >> >> cmSearchPath: Fix typo in comment >> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=814e774e >> >> cmSourceFileLocation: Fix typo in comment >> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd4fef64 >> >> cmGlobalGenerator: Make IsMultiConfig() const >> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2175e5bf >> >> > This is mostly to figure out how to contribute code:-) >> >> Good job. For large changes (e.g. cmake-daemon work) feel free >> to publish your branch somewhere and post a link here. For most >> changes please post here. > > Why did the typo fixes end up in the master branch and the const fix in the > next > branch? Because of the code freeze for CMake 3.6: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/16479 > Do I need to do something to get it from next to master at some point? No. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Some trivial patches
On Mi, 2016-06-01 at 11:18 -0400, Brad King wrote: > On 06/01/2016 05:04 AM, Tobias Hunger wrote: > > Attached you will find a couple of really small changes that add const to a > > method and fix a couple of typos in comments. Trivial stuff. > > Thanks. I've applied the changes: > > cmSearchPath: Fix typo in comment > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=814e774e > > cmSourceFileLocation: Fix typo in comment > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd4fef64 > > cmGlobalGenerator: Make IsMultiConfig() const > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2175e5bf > > > This is mostly to figure out how to contribute code:-) > > Good job. For large changes (e.g. cmake-daemon work) feel free > to publish your branch somewhere and post a link here. For most > changes please post here. Why did the typo fixes end up in the master branch and the const fix in the next branch? Do I need to do something to get it from next to master at some point? Best Regards, Tobias -- Tobias Hunger, Senior Software Engineer | The Qt Company The Qt Company GmbH, Rudower Chaussee 13, D-12489 Berlin Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho. Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Some trivial patches
On 06/01/2016 05:04 AM, Tobias Hunger wrote: > Attached you will find a couple of really small changes that add const to a > method and fix a couple of typos in comments. Trivial stuff. Thanks. I've applied the changes: cmSearchPath: Fix typo in comment https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=814e774e cmSourceFileLocation: Fix typo in comment https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd4fef64 cmGlobalGenerator: Make IsMultiConfig() const https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2175e5bf > This is mostly to figure out how to contribute code:-) Good job. For large changes (e.g. cmake-daemon work) feel free to publish your branch somewhere and post a link here. For most changes please post here. > Is this the preferred way you want your patches? > Or do I need to inline them somehow? Either attachments or inline is fine. > How can I create an account in the bug tracker? Unfortunately we had to turn off self-registration due to recent spam attacks (by human registrants). While we explore alternatives it is a manual process. I'll contact you privately. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
